Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Bug between p-editor and mat-dialog #13819

Closed
masartbenji opened this issue Oct 6, 2023 · 2 comments
Closed

Editor: Bug between p-editor and mat-dialog #13819

masartbenji opened this issue Oct 6, 2023 · 2 comments
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@masartbenji
Copy link

masartbenji commented Oct 6, 2023

Describe the bug

I have an encoding page on angular, in that page i can open a mat-dialog of article in not editable mode, i have a button to switch article in edition mode. After to switch the component in edit, and when I close dialog, some components who were under dialog are not rerendered correctly, so I have, per example one truncated input. In the article dialog, I have one p-editor that come from PrimeNg library, and when I remove it from dialog, the bug disappeared. This bug doesn't occur on Firefox

Environment

Angular: 15
CDK/Material: 15.2.9
Browser(s): Google chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows 11

Reproducer

No response

Angular version

15

PrimeNG version

15.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.14.0

Browser(s)

Google Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response

@masartbenji masartbenji added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 6, 2023
@masartbenji
Copy link
Author

masartbenji commented Oct 9, 2023

After some investigation, we found that the fact to change height of p-editor, who provok this bug. This is how we defined the p-editor : <p-editor *ngIf="isEdit else readonlyEditor" [style]="{ height: height + 'px' }" [readonly]="false" [(ngModel)]="value" (onTextChange)="onTextChange($event.htmlValue)" styleClass="editable-p-editor"> with a height at 250px and if I remove the style definitions, the bug disapear
image
image
image

@masartbenji masartbenji changed the title Editor: Title Editor: Bug between p-editor and mat-dialog Oct 9, 2023
Copy link

This issue has been automatically marked as stale due to a lack of activity. If this issue is still relevant to you, please leave a comment so we can keep it open. We apologize for not being able to prioritize it sooner. If you have any new information or questions, please share them in your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants