Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password | Incorrect placement of close icon when [toggleMask]="true" #13817

Closed
kevinley opened this issue Oct 6, 2023 · 2 comments · Fixed by #13823
Closed

Password | Incorrect placement of close icon when [toggleMask]="true" #13817

kevinley opened this issue Oct 6, 2023 · 2 comments · Fixed by #13823
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.4

Comments

@kevinley
Copy link
Contributor

kevinley commented Oct 6, 2023

Describe the bug

When enabling both the showClear and toggleMask flags at the same time, then the clear icon is not position well

Screenshot 2023-10-06 at 11 32 41

Environment

macOS

Reproducer

No response

Angular version

16.2.4

PrimeNG version

16.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

The icon should be vertically centred.
@kevinley kevinley added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 6, 2023
@SoyDiego
Copy link
Contributor

SoyDiego commented Oct 6, 2023

Describe the bug

When enabling both the showClear and toggleMask flags at the same time, then the clear icon is not position well
Screenshot 2023-10-06 at 11 32 41

Environment

macOS

Reproducer

No response

Angular version

16.2.4

PrimeNG version

16.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

The icon should be vertically centred.

Thanks for reported.
Tomorrow I will fix it! :)

This was referenced Oct 7, 2023
Closed
Merged
@SoyDiego
Copy link
Contributor

SoyDiego commented Oct 7, 2023

Hi @leykee,
I did a PR solving the problem. You can check it here: #13823
Now we should wait PrimeNG Team approve it if they think the solution is OK for them.

@cetincakiroglu cetincakiroglu changed the title Component: Password Password | Incorrect placement of close icon when [toggleMask]="true" Oct 11, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 11, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.2 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.4
Development

Successfully merging a pull request may close this issue.

Password: Fix alignment icons SoyDiego/primeng
3 participants
@SoyDiego @cetincakiroglu @kevinley