Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: Ensures buttons have discernible text #13803

Closed
Bryelmo opened this issue Oct 4, 2023 · 2 comments
Closed

Message: Ensures buttons have discernible text #13803

Bryelmo opened this issue Oct 4, 2023 · 2 comments
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Discussion Issue or pull request needs to be discussed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@Bryelmo
Copy link

Bryelmo commented Oct 4, 2023

Describe the feature you would like to see added

It would be better for Message component pass the accessibility WCAG 2.1 AA standard test. I'm using it in a project that requires this standard.

Is your feature request related to a problem?

Tabview component fails a WCAG 2.1 AA standard test with Axe Devtools and Accessibility insights for web extensions on Google Chrome browser.

<button type="button" pripple="" class="p-ripple p-element p-message-close p-link ng-tns-c713-50 ng-star-inserted" style="">

Describe the solution you'd like

Axe Devtools says how to solve this problem, you need to fix at least (1) of the following:

  • Element does not have inner text that is visible to screen readers
  • aria-label attribute does not exist or is empty
  • aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  • Element has no title attribute
  • Element's default semantics were not overridden with role="none" or role="presentation"

Describe alternatives you have considered

No response

Additional context

No response

@Bryelmo Bryelmo added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Oct 4, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: New Feature Issue contains a new feature or new component request Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 10, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.2 milestone Oct 10, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Is that related to tabview component or messages component?

In messages component, close button has [attr.aria-label]="'Close'" in line 45.

@cetincakiroglu cetincakiroglu added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Oct 11, 2023
@cetincakiroglu cetincakiroglu removed this from the 16.4.2 milestone Oct 11, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Discussion Issue or pull request needs to be discussed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants