Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabview: Ensures elements with an ARIA role that require child roles contain them #13802

Closed
Bryelmo opened this issue Oct 4, 2023 · 1 comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request

Comments

@Bryelmo
Copy link

Bryelmo commented Oct 4, 2023

Describe the feature you would like to see added

It would be better for Tabview component pass the accessibility WCAG 2.1 AA standard test. I'm using it in a project that requires this standard.

Is your feature request related to a problem?

Tabview component fails a WCAG 2.1 AA standard test with Axe Devtools and Accessibility insights for web extensions on Google Chrome browser.
<ul role="tablist" class="p-tabview-nav">

Describe the solution you'd like

Axe Devtools says how to solve this problem, you need to fix at least (1) of the following:

  • Element has children which are not allowed: li[tabindex]
  • Element uses aria-busy="true" while showing a loader

Describe alternatives you have considered

No response

Additional context

No response

@Bryelmo Bryelmo added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Oct 4, 2023
@Bryelmo Bryelmo changed the title Tabview: Tabview: Ensures elements with an ARIA role that require child roles contain them Oct 4, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants