Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-calendar: I18N API doesn't change translations of dayNamesMin when p-calendar is inline #13793

Closed
nidhal-belhadj opened this issue Oct 2, 2023 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@nidhal-belhadj
Copy link

Describe the bug

[X] bug report
[ ] feature request
[ ] support request

Stackblitz Case (Bug Reports)
https://stackblitz.com/edit/primeng11-localization-bug-8x9w6u

Current behavior
When calendar is inline, the i18N API doesn't change translations of dayNamesMin. (the view is not updated)

Expected behavior
days ans month names should be updated.

Environment

dev env

Reproducer

No response

Angular version

12.0.0

PrimeNG version

12.2.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

14.21.1

Browser(s)

Chrome

Steps to reproduce the behavior

1- create an app that contains the p-calendar component as inline (very important)
2- add a btn that change the language (as described by the primeng doc https://www.primefaces.org/primeng-v12-lts/#/i18n)
3- in your env, try to change the language

Expected behavior

days ans month names should be updated.

@nidhal-belhadj nidhal-belhadj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 2, 2023
@ashikjs
Copy link
Contributor

ashikjs commented Oct 3, 2023

@nidhal-belhadj but it's working on updated version did you try to upgrade it to new version and your stackblize primng & Angular version is 11.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants