Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table / EditableColumn: onEditComplete emitts old data value and not the new one as documented #13708

Closed
ThorstenKunz opened this issue Sep 20, 2023 · 0 comments · Fixed by #13719
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ThorstenKunz
Copy link

Describe the bug

The "data" field of the TableEditCompleteEvent passed to the onEditComplete handler contains the old value of the field before it was edited. But according to the API documentation for TableEditCompleteEvent the "data" field should contain the "New value.".

Environment

Its reproducible easily with the StackBlick generated from the PrimeNG documentation links

Reproducer

https://stackblitz.com/edit/hucfok?file=src%2Fapp%2Fdemo%2Ftable-cell-edit-demo.ts%3AL22,src%2Fapp%2Fdemo%2Ftable-cell-edit-demo.html

Angular version

16.2.0

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20.0

Browser(s)

Edge 117, Chromium 117

Steps to reproduce the behavior

  1. click on any editable cell
  2. change its value
  3. hit enter
  4. onEditComplet event.data will contain the old value before the edit

Expected behavior

On step 4. onEditComplete event.data should contain the new updated value, not the old one

@ThorstenKunz ThorstenKunz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 20, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Sep 23, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants