Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Disabled Dates Not Actually Disabled in Range Selection #13697

Closed
Ryan-h1 opened this issue Sep 18, 2023 · 1 comment
Closed

Calendar: Disabled Dates Not Actually Disabled in Range Selection #13697

Ryan-h1 opened this issue Sep 18, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Ryan-h1
Copy link

Ryan-h1 commented Sep 18, 2023

Describe the bug

Disabled dates are not fully disabled in range mode. When dates are disabled and the selectionMode is 'single', then disabled dates can not be selected, but when it's set to range, disabled dates can be selected so long as the start and end date are enabled.

Environment

Compiled and served on Mac OS, StackBlitz, Windows. Tested on all modern browsers.

Reproducer

No response

Angular version

16.2.5

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/github/Ryan-h1/primeng-calendar-issue-demo?file=src%2Fapp%2Fapp.component.ts
  2. Open the calendar
  3. Find a date that is disabled
  4. Select the day before and the day after as the range
  5. Observe that you have selected the disabled date, despite it being disabled

Expected behavior

Disabled dates should be prevented from being selected regardless of whether they're selected within a range or as singular dates.

@Ryan-h1 Ryan-h1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 18, 2023
@Ryan-h1 Ryan-h1 changed the title Component: Title Calendar: Disabled Dates Not Actually Disabled in Range Selection Sep 18, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants