Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: bootstrap4-dark-blue - Different CSS values #13696

Closed
psarno opened this issue Sep 18, 2023 · 1 comment
Closed

Themes: bootstrap4-dark-blue - Different CSS values #13696

psarno opened this issue Sep 18, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@psarno
Copy link

psarno commented Sep 18, 2023

Describe the bug

In 16.3.1, I noticed that the layout in a p-dialog component's content area was not correct, but this was only occuring when using the bootstrap4-dark-blue theme.

In this theme, the content padding is defined as:

.p-dialog .p-dialog-content {
   padding: 0 1.5rem 2rem 1.5rem;
}

Other themes, such as saga-blue, have this padding defined as:

.p-dialog .p-dialog-content {
   padding:1rem;
}

The 1 rem padding looks correct, in bootstrap4-dark-blue it is setting a 0 top padding, forcing the text of the content area up against the header.

It seems like this should match.

Environment

PrimeNG 16.3.1

Reproducer

No response

Angular version

16.2.2

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The padding should match across themes.

@psarno psarno added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 18, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants