Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Calendar is closed when month is selected with spacebar #13662

Closed
tom-vism opened this issue Sep 12, 2023 · 0 comments · Fixed by #13673
Closed

Calendar: Calendar is closed when month is selected with spacebar #13662

tom-vism opened this issue Sep 12, 2023 · 0 comments · Fixed by #13673
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.0

Comments

@tom-vism
Copy link

tom-vism commented Sep 12, 2023 •
edited
Loading

Describe the bug

Pressing spacebar during month selection closes calendar popup. It should behave like Enter. Issue happens on older primeng versions as well.

Environment

Any environment

Reproducer

https://stackblitz.com/edit/msb1ip?file=package.json

Angular version

16.2.4

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open calendar
  2. Use keyboard to open month view
  3. Select any available month and press spacebar

Expected behavior

Popup remains open. Initial calendar view is shown (date selection). Should work exactly like Enter.
@tom-vism tom-vism added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 12, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 14, 2023
@ashikjs
fix: primefaces#13662 || Calendar: Calendar is closed when month is s…
638f83a 
…elected with spacebar
@ashikjs ashikjs mentioned this issue Sep 14, 2023
Merged
@gucal gucal added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 17, 2023
@gucal gucal added this to the 16.3.2 milestone Sep 17, 2023
cetincakiroglu added a commit that referenced this issue Sep 21, 2023
@cetincakiroglu
Merge pull request #13673 from ashikjs/issues-13662/calender-month-se…
3990262 
…lection-by-keyboard-space-not-work

fix: #13662 || Calendar: Calendar is closed when month view press space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

fix: #13662 || Calendar: Calendar is closed when month view press space ashikjs/primeng
3 participants
@gucal @cetincakiroglu @tom-vism