Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: Suggestions list display is broken after scroll when virtual scroll enabled #13655

Closed
Ioana-Drimbarean opened this issue Sep 12, 2023 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Ioana-Drimbarean
Copy link

Ioana-Drimbarean commented Sep 12, 2023

Describe the bug

Dear team,

I have encountered an issue while testing the autocomplete component with virtual scroll enabled.
I think there is something wrong with the scrolling reset and the scroll container calculation. I suggest you use a more complex list of items while fixing the bug and not just a list of prefixed "item ".
Please check the steps to reproduce section for more details.

Environment

Prime NG demo component: https://primeng.org/autocomplete#virtualscroll
PrimeNG version: v16.3.1 (from your own demo page) or 16.0.2 (my locale environment version)
Angular version: 16

Reproducer

No response

Angular version

16.1.0

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v19.7.0

Browser(s)

Chrome, FF

Steps to reproduce the behavior

CASE 1: broken display of suggestion list

  1. Use Prime NG demo component: https://primeng.org/autocomplete#virtualscroll
  2. Search after Item and then scroll down through the list of suggestions
  3. Add 0 at the end after scrolling => the display is broken(you barely see the suggestion within the scrolling container)
  4. Add 9 instead of 9, delete input and check different combinations
    => The display is broken sometimes. It helps scrolling through the list, in order to get back to the right behaviour.
    after_scroll_6
    after_scroll_5
    after_scroll_4
    after_scroll_3
    after_scroll_2

CASE 2: inconsistent scroll area size.

  1. Use Prime NG demo component: https://primeng.org/autocomplete#virtualscroll (Please refresh the page, or open it in a new tab)
  2. Search after Item 0 => The list of suggestions shows one item and empty space.
  3. Delete 0 and then add it again => The list of suggestions shows one item and no empty space.
    item_0_first
    item_0_second_time

Expected behavior

The list of suggestions should be visible to the user and the scrolling area size for the suggestion list should be consistent.(recalculated after the number of results).
Also, this workflow also should work when the showEmptyMessage option is enabled.
Please contact me if you need more input.

@Ioana-Drimbarean Ioana-Drimbarean added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 12, 2023
@andyg3
Copy link
Contributor

andyg3 commented Nov 29, 2023

I am facing the same issue, and the demo page is still broken.

@imohammadali
Copy link

imohammadali commented Jun 10, 2024

I have the same issue, in the https://primeng.org/autocomplete we can see it's not working properly:

image

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

4 participants