Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmPopup: CloseOnEscape is not working #13652

Closed
Gykonik opened this issue Sep 11, 2023 · 3 comments · Fixed by #13675
Closed

ConfirmPopup: CloseOnEscape is not working #13652

Gykonik opened this issue Sep 11, 2023 · 3 comments · Fixed by #13675
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Gykonik
Copy link

Gykonik commented Sep 11, 2023

Describe the bug

When pressing escape on an open confirmation dialog with closeOnEscape: true, nothing happens.

Environment

Reproducer

https://stackblitz.com/edit/ztmvzt?file=src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fdemo%2Fconfirm-popup-basic-demo.ts

Angular version

16.1.0

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20.0

Browser(s)

No response

Steps to reproduce the behavior

Open the confirmation dialog and try to close it using escape.

Expected behavior

The dialog should close immediately after pressing escape.

@Gykonik Gykonik added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 11, 2023
@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 13, 2023

Hi @Gykonik, thanks for report the issue.
Tomorrow I will do the pull request solving this problem.

Regards

@SoyDiego
Copy link
Contributor

Hi @Gykonik, I did a PR here solving the problem: #13675.

Could you edit the title of your post and write ConfirmPopup instead of ConfirmDialog, please?. The correct component was ConfirmPopup

Now we should wait if PrimeNG Team approve it.

Thanks

@Gykonik Gykonik changed the title ConfirmDialog: CloseOnEscape is not working ConfirmPopup: CloseOnEscape is not working Sep 14, 2023
@Gykonik
Copy link
Author

Gykonik commented Sep 14, 2023

Sure, thanks for your effort! :)

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 22, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants