Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showClear on calendar doesn't appear if showIcon is set to true #13650

Closed
cdskill opened this issue Sep 11, 2023 · 3 comments
Closed

showClear on calendar doesn't appear if showIcon is set to true #13650

cdskill opened this issue Sep 11, 2023 · 3 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.0

Comments

@cdskill
Copy link

cdskill commented Sep 11, 2023 •
edited
Loading

Describe the bug

The @input() showClear input does'nt display the cross button icon if @input()showIcon is set to true.

https://stackblitz.com/edit/bbgayt?file=src%2Fapp%2Fdemo%2Fcalendar-basic-demo.html

Environment

Work.

Reproducer

No response

Angular version

16.2.3

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.17.1

Browser(s)

Chrome

Steps to reproduce the behavior

  1. use p-calendar
  2. set showClear and showIcon to true
  3. the icon of showIcon is displayed but not the showClear button if we set a date.

Expected behavior

The clear button should be displayed.
@cdskill cdskill added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 11, 2023
@cdskill cdskill changed the title showClear input on calendar doesn't appear if showTime is set to true showClear on calendar doesn't appear if showTime is set to true Sep 11, 2023
@cdskill cdskill changed the title showClear on calendar doesn't appear if showTime is set to true showClear on calendar doesn't appear if showIcon is set to true Sep 12, 2023
@ashikjs ashikjs mentioned this issue Sep 17, 2023
Merged
@ashikjs
Copy link
Contributor

ashikjs commented Sep 17, 2023

@cdskill I solved it Primng Theme hopefully they will merge it .

@ashikjs
Copy link
Contributor

ashikjs commented Sep 17, 2023

Here is PR: primefaces/primeng-sass-theme#45

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 26, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 26, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.0
Development

No branches or pull requests
3 participants
@cdskill @ashikjs @cetincakiroglu