Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-calendar: Cannot read properties of undefined (reading 'length') #13348

Closed
psarno opened this issue Jul 19, 2023 · 4 comments · Fixed by #13349
Closed

p-calendar: Cannot read properties of undefined (reading 'length') #13348

psarno opened this issue Jul 19, 2023 · 4 comments · Fixed by #13349
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@psarno
Copy link

psarno commented Jul 19, 2023

Describe the bug

I've reduced this down to its core repro:

<p-calendar
view="month"
dateFormat="mm/yy"
[yearNavigator]="true"
></p-calendar>

Try changing the month using the upper left/right arrows.

Environment

Angular / PrimeNG 16

Reproducer

https://stackblitz.com/edit/github-wh3ibs

Angular version

16.0.0

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

  1. https://stackblitz.com/edit/github-wh3ibs
  2. Change the month using either arrow at the top

Expected behavior

The month should change without throwing a JavaScript error.

@psarno psarno added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 19, 2023
@SoyDiego
Copy link
Contributor

Hi @psarno I have checked the problem and you are right.
I did a PR solving the problem. You can check here #13349.
Now we should wait if PrimeNG Team approve it.

Thanks! :)

@psarno
Copy link
Author

psarno commented Aug 1, 2023

@cetincakiroglu Is there any chance this PR can be reviewed?

This has a very basic repro and is throwing an exception when trying to simply change the year via arrows.

@psarno
Copy link
Author

psarno commented Aug 21, 2023

@cetincakiroglu

@SoyDiego has put in effort to resolve some of these very basic oustanding issues. Do we know when we can get a PR review?

I'm not asking PrimeNG to fix something for me outside of support, I'm only asking that they review a fix for something that is simply broken. Helps everyone!

Thanks! 👍

@gucal gucal added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 26, 2023
@gucal gucal added this to the 16.2.1 milestone Aug 26, 2023
@gucal
Copy link
Contributor

gucal commented Aug 26, 2023

Hi,

We are now fully focused on accessibility improvements. That's why there was a bit of a hitch. I will inform you after reviewing the PR.

Thank you

gucal added a commit that referenced this issue Aug 27, 2023
[#13348] - Fixed calendar component, added yearOptions onInit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants