Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: Close button receives initial focus #12643

Closed
ShawnTalbert opened this issue Feb 16, 2023 · 2 comments
Closed

DynamicDialog: Close button receives initial focus #12643

ShawnTalbert opened this issue Feb 16, 2023 · 2 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.3.0

Comments

@ShawnTalbert
Copy link

Describe the bug

Hello,

When using DynamicDialog (the dialog service) to display a dialog, the close icon gets the focus, as shown in the screenshot below.
image

I want the auto focus to instead be on one of the form controls inside the dialog - I've tried native autofocus as well as the Prime AutoFocus directive- neither seem to stop the (X) from getting focus upon opening the dialog. This also has the unfortunate side effect of pressing [ENTER] immediately after opening the dialog, closes it.

Environment

Development in WSL, running in Edge for Linux.

Reproducer

No response

Angular version

15.1

PrimeNG version

15.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@ShawnTalbert ShawnTalbert added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 16, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Feb 19, 2023
@volvachev
feat(primeng/p-dynamicDialog): add new property to dynamic dialog con…
a087f3b 
…figs for autoFocus

Fixes primefaces#12643.
@volvachev volvachev mentioned this issue Feb 19, 2023
Closed
volvachev added a commit to volvachev/primeng that referenced this issue May 23, 2023
@volvachev
feat(primeng/p-dynamicDialog): add new property to dynamic dialog con…
777e73a 
…figs for autoFocus

Fixes primefaces#12643.
volvachev added a commit to volvachev/primeng that referenced this issue Jun 12, 2023
@volvachev
feat(primeng/p-dynamicDialog): add new property to dynamic dialog con…
51ddb43 
…figs for autoFocus

Fixes primefaces#12643.
@TheNickmaster21
Copy link

We are also experiencing this issue. It appears related to #13082 and #13113 .

@mertsincan mertsincan added Type: New Feature Issue contains a new feature or new component request Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Aug 21, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
@mertsincan
Copy link
Member

Fixed in #13113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.3.0
3 participants
@ShawnTalbert @TheNickmaster21 @mertsincan