From a35bff324b149c3d14fc5376ba802afc333127c5 Mon Sep 17 00:00:00 2001 From: Tomer953 Date: Sat, 16 Sep 2023 17:00:08 +0300 Subject: [PATCH] docs: remove entryComponents from DynamicDialogs According to the current documentation for Dynamic Dialogs, it is stated that entryComponents are required for dynamic dialogs. However, with Angular 9 and above, using the Ivy rendering engine, entryComponents are generally no longer necessary. This could lead to confusion for developers using newer versions of Angular. --- src/app/showcase/doc/dynamicdialog/basicdoc.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/app/showcase/doc/dynamicdialog/basicdoc.ts b/src/app/showcase/doc/dynamicdialog/basicdoc.ts index b4b760d5a37..a73b86c32ba 100644 --- a/src/app/showcase/doc/dynamicdialog/basicdoc.ts +++ b/src/app/showcase/doc/dynamicdialog/basicdoc.ts @@ -10,8 +10,7 @@ import { ProductListDemo } from './productlistdemo'; template: `

- Dynamic dialogs require an instance of a DialogService that is responsible for displaying a dialog with a component as its content. Since the dynamically loaded content is not defined at build time, a configuration is necessary - using the entryComponents of your parent module. Calling open method of DialogService will display dynamic dialog. First parameter of open method is the type of component to load and the second parameter is + Dynamic dialogs require an instance of a DialogService that is responsible for displaying a dialog with a component as its content. Calling open method of DialogService will display dynamic dialog. First parameter of open method is the type of component to load and the second parameter is the configuration of the Dialog such as header, width and more.