From c254e4e7b71dd0f859cc27a93f424e98139d5314 Mon Sep 17 00:00:00 2001 From: Your Name Date: Wed, 1 May 2024 17:44:54 +0200 Subject: [PATCH 001/484] Calendar - add option to change step size in yearpicker --- src/app/components/calendar/calendar.ts | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/app/components/calendar/calendar.ts b/src/app/components/calendar/calendar.ts index 37fd1cd6592..e5b44344c0b 100644 --- a/src/app/components/calendar/calendar.ts +++ b/src/app/components/calendar/calendar.ts @@ -604,6 +604,11 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { * @group Props */ @Input({ transform: booleanAttribute }) timeOnly: boolean | undefined; + /** + * Years to change per step in yearpicker. + * @group Props + */ + @Input({ transform: numberAttribute }) stepYearPicker: number = 20; /** * Hours to change per step. * @group Props @@ -1284,8 +1289,8 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { yearPickerValues() { let yearPickerValues = []; - let base = this.currentYear - (this.currentYear % 10); - for (let i = 0; i < 10; i++) { + let base = this.currentYear - (this.currentYear % this.stepYearPicker); + for (let i = 0; i < this.stepYearPicker; i++) { yearPickerValues.push(base + i); } @@ -1407,7 +1412,7 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { this.updateFocus(); }, 1); } else if (this.currentView === 'year') { - this.decrementDecade(); + this.decrementYearPickerStep(); setTimeout(() => { this.updateFocus(); }, 1); @@ -1438,7 +1443,7 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { this.updateFocus(); }, 1); } else if (this.currentView === 'year') { - this.incrementDecade(); + this.incrementYearPickerStep(); setTimeout(() => { this.updateFocus(); }, 1); @@ -1465,12 +1470,12 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { } } - decrementDecade() { - this.currentYear = this.currentYear - 10; + decrementYearPickerStep() { + this.currentYear = this.currentYear - this.stepYearPicker; } - incrementDecade() { - this.currentYear = this.currentYear + 10; + incrementYearPickerStep() { + this.currentYear = this.currentYear + this.stepYearPicker; } incrementYear() { From c968e5f5dda4091045f471ec3255ed014405c086 Mon Sep 17 00:00:00 2001 From: Alexander Ciesielski Date: Mon, 6 May 2024 15:23:35 +0200 Subject: [PATCH 002/484] feat(button): make standalone --- src/app/components/api/shared.ts | 9 +++++---- src/app/components/autofocus/autofocus.ts | 7 +++---- src/app/components/button/button.ts | 15 +++++++++------ src/app/components/ripple/ripple.ts | 8 ++++---- 4 files changed, 21 insertions(+), 18 deletions(-) diff --git a/src/app/components/api/shared.ts b/src/app/components/api/shared.ts index 88735641065..cb5ecbe7e84 100755 --- a/src/app/components/api/shared.ts +++ b/src/app/components/api/shared.ts @@ -1,20 +1,22 @@ -import { CommonModule } from '@angular/common'; import { Component, Directive, Input, NgModule, TemplateRef } from '@angular/core'; @Component({ selector: 'p-header', + standalone: true, template: '' }) export class Header {} @Component({ selector: 'p-footer', + standalone: true, template: '' }) export class Footer {} @Directive({ selector: '[pTemplate]', + standalone: true, host: {} }) export class PrimeTemplate { @@ -30,8 +32,7 @@ export class PrimeTemplate { } @NgModule({ - imports: [CommonModule], - exports: [Header, Footer, PrimeTemplate], - declarations: [Header, Footer, PrimeTemplate] + imports: [Header, Footer, PrimeTemplate], + exports: [Header, Footer, PrimeTemplate] }) export class SharedModule {} diff --git a/src/app/components/autofocus/autofocus.ts b/src/app/components/autofocus/autofocus.ts index 11253f8051b..504103917b3 100644 --- a/src/app/components/autofocus/autofocus.ts +++ b/src/app/components/autofocus/autofocus.ts @@ -1,4 +1,3 @@ -import { CommonModule } from '@angular/common'; import { Directive, ElementRef, Input, NgModule, booleanAttribute } from '@angular/core'; import { DomHandler } from 'primeng/dom'; /** @@ -7,6 +6,7 @@ import { DomHandler } from 'primeng/dom'; */ @Directive({ selector: '[pAutoFocus]', + standalone: true, host: { class: 'p-element' } @@ -49,8 +49,7 @@ export class AutoFocus { } @NgModule({ - imports: [CommonModule], - exports: [AutoFocus], - declarations: [AutoFocus] + imports: [AutoFocus], + exports: [AutoFocus] }) export class AutoFocusModule {} diff --git a/src/app/components/button/button.ts b/src/app/components/button/button.ts index cd02156c196..94fafb2293f 100755 --- a/src/app/components/button/button.ts +++ b/src/app/components/button/button.ts @@ -1,4 +1,4 @@ -import { CommonModule, DOCUMENT } from '@angular/common'; +import { DOCUMENT, NgClass, NgIf, NgStyle, NgTemplateOutlet } from '@angular/common'; import { AfterContentInit, AfterViewInit, @@ -20,11 +20,11 @@ import { numberAttribute } from '@angular/core'; import { PrimeTemplate, SharedModule } from 'primeng/api'; +import { AutoFocus } from 'primeng/autofocus'; import { DomHandler } from 'primeng/dom'; import { SpinnerIcon } from 'primeng/icons/spinner'; -import { RippleModule } from 'primeng/ripple'; +import { Ripple } from 'primeng/ripple'; import { ObjectUtils } from 'primeng/utils'; -import { AutoFocusModule } from 'primeng/autofocus'; type ButtonIconPosition = 'left' | 'right' | 'top' | 'bottom'; @@ -36,12 +36,14 @@ const INTERNAL_BUTTON_CLASSES = { loading: 'p-button-loading', labelOnly: 'p-button-loading-label-only' } as const; + /** * Button directive is an extension to button component. * @group Components */ @Directive({ selector: '[pButton]', + standalone: true, host: { class: 'p-element' } @@ -329,6 +331,8 @@ export class ButtonDirective implements AfterViewInit, OnDestroy { */ @Component({ selector: 'p-button', + standalone: true, + imports: [NgIf, NgTemplateOutlet, NgStyle, NgClass, Ripple, AutoFocus, SpinnerIcon], template: ` @@ -58,6 +75,7 @@ type SplitButtonIconPosition = 'left' | 'right'; [ariaLabel]="buttonProps?.['ariaLabel']" pAutoFocus [autofocus]="autofocus" + [pTooltip]="tooltip" > @@ -60,6 +61,7 @@ type SplitButtonIconPosition = 'left' | 'right'; pAutoFocus [autofocus]="autofocus" [pTooltip]="tooltip" + [tooltipOptions]="tooltipOptions" > -
+
-
- -
@@ -2398,6 +2398,13 @@ export class TTScrollableView implements AfterViewInit, OnDestroy { preventBodyScrollPropagation: boolean | undefined; + getMergedTableStyles(contentStyle) { + return { + ...this.tt.tableStyle, + ...contentStyle + }; + } + @Input() get scrollHeight(): string | undefined | null { return this._scrollHeight; } From 3aff4fac281bb3319162bafbae860a11cb6dc1b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 11 Jul 2024 14:46:16 +0300 Subject: [PATCH 230/484] refactor | Table --- src/app/components/table/table.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/components/table/table.ts b/src/app/components/table/table.ts index 1b807503617..10453181322 100644 --- a/src/app/components/table/table.ts +++ b/src/app/components/table/table.ts @@ -221,7 +221,7 @@ export class TableService { role="table" [ngClass]="{ 'p-datatable-table': true, 'p-datatable-scrollable-table': scrollable, 'p-datatable-resizable-table': resizableColumns, 'p-datatable-resizable-table-fit': resizableColumns && columnResizeMode === 'fit' }" [class]="tableStyleClass" - [style]="tableStyle" + [ngStyle]="tableStyle" [attr.id]="id + '-table'" > @@ -242,7 +242,7 @@ export class TableService { role="rowgroup" class="p-datatable-tbody" [ngClass]="scrollerOptions.contentStyleClass" - [style]="scrollerOptions.contentStyle" + [ngStyle]="scrollerOptions.contentStyle" [value]="dataToRender(scrollerOptions.rows)" [pTableBody]="scrollerOptions.columns" [pTableBodyTemplate]="bodyTemplate" @@ -251,7 +251,7 @@ export class TableService { From 946256aa38063a444431a2124861cc1c6d70e471 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 11 Jul 2024 14:50:00 +0300 Subject: [PATCH 231/484] refactor | tree --- src/app/components/tree/tree.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/tree/tree.ts b/src/app/components/tree/tree.ts index 46512ddb7fe..fc291dd0f3d 100755 --- a/src/app/components/tree/tree.ts +++ b/src/app/components/tree/tree.ts @@ -844,7 +844,7 @@ export class UITreeNode implements OnInit { -
+
`, - typescript: `import { Component, OnInit } from '@angular/core'; + typescript: `import { Component } from '@angular/core'; import { FormsModule } from '@angular/forms'; import { MultiSelectModule } from 'primeng/multiselect'; @@ -67,7 +67,7 @@ interface City { standalone: true, imports: [FormsModule, MultiSelectModule] }) -export class MultiSelectChipsDemo implements OnInit { +export class MultiSelectChipsDemo { cities!: City[]; selectedCities!: City[]; From d8936c0536111cc81089e6ad9c927a1755373058 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:01:10 +0300 Subject: [PATCH 288/484] Fixed #16133 - pBadge | Add missing badgeStyle & badgeStyleClass to directive --- src/app/components/badge/badge.ts | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/app/components/badge/badge.ts b/src/app/components/badge/badge.ts index bc36926dd44..fb1fdc95e2d 100755 --- a/src/app/components/badge/badge.ts +++ b/src/app/components/badge/badge.ts @@ -47,9 +47,21 @@ export class BadgeDirective implements OnChanges, AfterViewInit { * @group Props */ @Input() public value: string | number; + /** + * Inline style of the element. + * @group Props + */ + @Input() badgeStyle: { [klass: string]: any } | null | undefined; + /** + * Class of the element. + * @group Props + */ + @Input() badgeStyleClass: string; private id!: string; + badgeEl: HTMLElement; + private get activeElement(): HTMLElement { return this.el.nativeElement.nodeName.indexOf('-') != -1 ? this.el.nativeElement.firstChild : this.el.nativeElement; } @@ -60,7 +72,7 @@ export class BadgeDirective implements OnChanges, AfterViewInit { constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, private renderer: Renderer2) {} - public ngOnChanges({ value, size, severity, disabled }: SimpleChanges): void { + public ngOnChanges({ value, size, severity, disabled, badgeStyle, badgeStyleClass }: SimpleChanges): void { if (disabled) { this.toggleDisableState(); } @@ -80,6 +92,10 @@ export class BadgeDirective implements OnChanges, AfterViewInit { if (value) { this.setValue(); } + + if (badgeStyle || badgeStyleClass) { + this.applyStyles(); + } } public ngAfterViewInit(): void { @@ -165,6 +181,19 @@ export class BadgeDirective implements OnChanges, AfterViewInit { this.setValue(badge); DomHandler.addClass(el, 'p-overlay-badge'); this.renderer.appendChild(el, badge); + this.badgeEl = badge; + this.applyStyles(); + } + + private applyStyles(): void { + if (this.badgeEl && this.badgeStyle && typeof this.badgeStyle === 'object') { + for (const [key, value] of Object.entries(this.badgeStyle)) { + this.renderer.setStyle(this.badgeEl, key, value); + } + } + if (this.badgeEl && this.badgeStyleClass) { + this.badgeEl.classList.add(...this.badgeStyleClass.split(' ')); + } } private setSeverity(oldSeverity?: 'success' | 'info' | 'warning' | 'danger' | null, element?: HTMLElement): void { From 9d885e5780c9141f451f491eefb3586e3bbbf870 Mon Sep 17 00:00:00 2001 From: PC0 Date: Tue, 30 Jul 2024 12:57:14 +0330 Subject: [PATCH 289/484] closes #16070 Table> double call to (onLazyLoad) event #16070 Table> double call to (onLazyLoad) event --- src/app/components/table/table.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/components/table/table.ts b/src/app/components/table/table.ts index 26d4a331141..fb748be1f9f 100644 --- a/src/app/components/table/table.ts +++ b/src/app/components/table/table.ts @@ -1586,7 +1586,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable field: field, order: order }); - } else { + } else if (!this.lazy) { this.value.sort((data1, data2) => { let value1 = ObjectUtils.resolveFieldData(data1, field); let value2 = ObjectUtils.resolveFieldData(data2, field); @@ -1604,7 +1604,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable this._value = [...this.value]; } - if (this.hasFilter()) { + if ((!this.lazy || this.customSort) && this.hasFilter()) { this._filter(); } } @@ -1634,7 +1634,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable mode: this.sortMode, multiSortMeta: this.multiSortMeta }); - } else { + } else if (!this.lazy) { this.value.sort((data1, data2) => { return this.multisortField(data1, data2, this.multiSortMeta, 0); }); @@ -1642,7 +1642,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable this._value = [...this.value]; } - if (this.hasFilter()) { + if ((!this.lazy || this.customSort) && this.hasFilter()) { this._filter(); } } From 03f4523984fdd2b2f8d68fe00606a5e1c5f4a80b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 10:36:05 +0300 Subject: [PATCH 290/484] Fixed #16139 - Breadcrumb | tabindex property not working --- src/app/components/breadcrumb/breadcrumb.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/components/breadcrumb/breadcrumb.ts b/src/app/components/breadcrumb/breadcrumb.ts index 1f4631c3049..8cb81ec370f 100755 --- a/src/app/components/breadcrumb/breadcrumb.ts +++ b/src/app/components/breadcrumb/breadcrumb.ts @@ -33,7 +33,7 @@ import { BreadcrumbItemClickEvent } from './breadcrumb.interface'; (click)="onClick($event, home)" [target]="home.target" [attr.title]="home.title" - [attr.tabindex]="home.disabled ? null : '0'" + [attr.tabindex]="home.disabled ? '-1' : home.tabindex || '0'" [attr.ariaCurrentWhenActive]="isCurrentUrl(home)" > @@ -54,7 +54,7 @@ import { BreadcrumbItemClickEvent } from './breadcrumb.interface'; (click)="onClick($event, home)" [target]="home.target" [attr.title]="home.title" - [attr.tabindex]="home.disabled ? '-1' : '0'" + [attr.tabindex]="home.disabled ? '-1' : home.tabindex || '0'" [attr.ariaCurrentWhenActive]="isCurrentUrl(home)" [fragment]="home.fragment" [queryParamsHandling]="home.queryParamsHandling" @@ -84,7 +84,7 @@ import { BreadcrumbItemClickEvent } from './breadcrumb.interface'; (click)="onClick($event, item)" [target]="item.target" [attr.title]="item.title" - [attr.tabindex]="item.disabled ? null : '0'" + [attr.tabindex]="item.disabled ? '-1' : item.tabindex || '0'" [attr.ariaCurrentWhenActive]="isCurrentUrl(item)" > @@ -108,7 +108,7 @@ import { BreadcrumbItemClickEvent } from './breadcrumb.interface'; (click)="onClick($event, item)" [target]="item.target" [attr.title]="item.title" - [attr.tabindex]="item.disabled ? null : '0'" + [attr.tabindex]="item.disabled ? '-1' : item.tabindex || '0'" [fragment]="item.fragment" [queryParamsHandling]="item.queryParamsHandling" [preserveFragment]="item.preserveFragment" From 5498e1381f5c22111e33636cf6b11965ce63ef15 Mon Sep 17 00:00:00 2001 From: navedqb <109583873+navedqb@users.noreply.github.com> Date: Thu, 1 Aug 2024 17:07:00 +0530 Subject: [PATCH 291/484] fix tabview demo code --- src/app/showcase/doc/tabview/dynamicdoc.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/showcase/doc/tabview/dynamicdoc.ts b/src/app/showcase/doc/tabview/dynamicdoc.ts index faded60fef1..195b1cdd8c9 100644 --- a/src/app/showcase/doc/tabview/dynamicdoc.ts +++ b/src/app/showcase/doc/tabview/dynamicdoc.ts @@ -54,12 +54,12 @@ import { TabViewModule } from 'primeng/tabview'; import { CommonModule } from '@angular/common'; @Component({ - selector: 'tab-view-basic-demo', - templateUrl: './tab-view-basic-demo.html', + selector: 'tab-view-dynamic-demo', + templateUrl: './tab-view-dynamic-demo.html', standalone: true, imports: [TabViewModule, CommonModule] }) -export class TabViewBasicDemo imlements onInit { +export class TabViewDynamicDemo implements OnInit { tabs: { title: string, content: string }[] = []; ngOnInit() { From 77d4189eb4da2ae2b3bb5909be92f46e651fef14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 15:55:56 +0300 Subject: [PATCH 292/484] Set new version & update changelog --- CHANGELOG.md | 17 +++++++++++++++++ package-lock.json | 4 ++-- package.json | 2 +- src/app/components/package.json | 2 +- src/app/showcase/data/versions.json | 2 +- .../showcase/layout/doc/codeeditor/templates.ts | 2 +- 6 files changed, 23 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cbffb5f19d0..71b1193fea1 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,21 @@ # Changelog +## [17.18.7](https://github.com/primefaces/primeng/tree/17.18.7) (2024-08-01) +[Full Changelog](https://github.com/primefaces/primeng/compare/17.18.6...17.18.7) + +**Fixed bugs:** +- tabmenu: emits change event twice when an item is clicked [\#16123](https://github.com/primefaces/primeng/issues/16123) +- Table: Frozen columns are displaced [\#15852](https://github.com/primefaces/primeng/issues/15852) +- Password: Tooltip with tooltipEvent='focus' is never displayed [\#16106](https://github.com/primefaces/primeng/issues/16106) +- p-datepicker-current-day is not applied to the selected day [\#15969](https://github.com/primefaces/primeng/issues/15969) +- TabView: Demo code for TabViewDynamic is wrong [\#16148](https://github.com/primefaces/primeng/issues/16148) +- Component: TabView [\#16076](https://github.com/primefaces/primeng/issues/16076) +- Dialog: Material Design close button regression [\#14916](https://github.com/primefaces/primeng/issues/14916) +- Breadcrumb | Disabled breadcrumbs should have 'aria-disabled' [\#16125](https://github.com/primefaces/primeng/issues/16125) +- Table> double call to (onLazyLoad) event [\#16070](https://github.com/primefaces/primeng/issues/16070) +- pBadge | Add missing badgeStyle & badgeStyleClass to directive [\#16133](https://github.com/primefaces/primeng/issues/16133) +- Breadcrumb | 'tabindex' property not working [\#16139](https://github.com/primefaces/primeng/issues/16139) +- Menubar: autoDisplay and autoHide broken [\#13512](https://github.com/primefaces/primeng/issues/13512) + ## [17.18.6](https://github.com/primefaces/primeng/tree/17.18.6) (2024-07-25) [Full Changelog](https://github.com/primefaces/primeng/compare/17.18.5...17.18.6) diff --git a/package-lock.json b/package-lock.json index f3ff17ec2e2..081e14a8d44 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "primeng", - "version": "17.18.6", + "version": "17.18.7", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "primeng", - "version": "17.18.6", + "version": "17.18.7", "license": "SEE LICENSE IN LICENSE.md", "devDependencies": { "@angular-devkit/build-angular": "^18.0.2", diff --git a/package.json b/package.json index c60e10e45b6..afb40f6a6f6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "primeng", - "version": "17.18.6", + "version": "17.18.7", "license": "SEE LICENSE IN LICENSE.md", "scripts": { "ng": "ng", diff --git a/src/app/components/package.json b/src/app/components/package.json index 86cd6536b2e..993cff7758a 100644 --- a/src/app/components/package.json +++ b/src/app/components/package.json @@ -1,6 +1,6 @@ { "name": "primeng", - "version": "17.18.6", + "version": "17.18.7", "repository": { "type": "git", "url": "https://github.com/primefaces/primeng" diff --git a/src/app/showcase/data/versions.json b/src/app/showcase/data/versions.json index d994b96b15f..6260dab3907 100644 --- a/src/app/showcase/data/versions.json +++ b/src/app/showcase/data/versions.json @@ -1,6 +1,6 @@ [ { - "version": "v17.18.6", + "version": "v17.18.7", "name": "v17", "url": "https://primeng.org" }, diff --git a/src/app/showcase/layout/doc/codeeditor/templates.ts b/src/app/showcase/layout/doc/codeeditor/templates.ts index 0f9aedf112f..91780578032 100644 --- a/src/app/showcase/layout/doc/codeeditor/templates.ts +++ b/src/app/showcase/layout/doc/codeeditor/templates.ts @@ -15,7 +15,7 @@ export interface Props { const app_dependencies = pkg ? pkg.devDependencies : {}; const PrimeNG = { - version: '17.18.6', + version: '17.18.7', description: 'PrimeNG is an open source UI library for Angular featuring a rich set of 80+ components, a theme designer, various theme alternatives such as Material, Bootstrap, Tailwind, premium templates and professional support. In addition, it integrates with PrimeBlock, which has 370+ ready to use UI blocks to build spectacular applications in no time.' }; From 30cd9e873a9864404379c2a0a7844b3cabcfa616 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 15:58:44 +0300 Subject: [PATCH 293/484] code format --- src/app/components/dialog/dialog.ts | 1 - src/app/components/tooltip/tooltip.ts | 5 +-- .../doc/contribution/contribution.module.ts | 1 - .../doc/contribution/helpneededdoc.ts | 34 +++++++++---------- .../showcase/doc/contribution/keypoints.ts | 12 +++---- .../showcase/doc/contribution/pathwaydoc.ts | 18 +++++----- .../contribution-routing.module.ts | 1 - 7 files changed, 30 insertions(+), 42 deletions(-) diff --git a/src/app/components/dialog/dialog.ts b/src/app/components/dialog/dialog.ts index f59723a20d2..65c404aa3b7 100755 --- a/src/app/components/dialog/dialog.ts +++ b/src/app/components/dialog/dialog.ts @@ -1064,4 +1064,3 @@ export class Dialog implements AfterContentInit, OnInit, OnDestroy { declarations: [Dialog] }) export class DialogModule {} - diff --git a/src/app/components/tooltip/tooltip.ts b/src/app/components/tooltip/tooltip.ts index 038d05533d1..f623e528f9c 100755 --- a/src/app/components/tooltip/tooltip.ts +++ b/src/app/components/tooltip/tooltip.ts @@ -668,9 +668,7 @@ export class Tooltip implements AfterViewInit, OnDestroy { this.el.nativeElement.removeEventListener('click', this.clickListener); } if (tooltipEvent === 'focus' || tooltipEvent === 'both') { - - let target = this.getTarget(this.el.nativeElement); - + let target = this.getTarget(this.el.nativeElement); target.removeEventListener('focus', this.focusListener); target.removeEventListener('blur', this.blurListener); @@ -734,4 +732,3 @@ export class Tooltip implements AfterViewInit, OnDestroy { declarations: [Tooltip] }) export class TooltipModule {} - diff --git a/src/app/showcase/doc/contribution/contribution.module.ts b/src/app/showcase/doc/contribution/contribution.module.ts index c1dd62f3321..1448eb10239 100644 --- a/src/app/showcase/doc/contribution/contribution.module.ts +++ b/src/app/showcase/doc/contribution/contribution.module.ts @@ -11,7 +11,6 @@ import { BenefitsDoc } from './benefitsdoc'; import { ClaDoc } from './cladoc'; import { KeyPointsDoc } from './keypoints'; - @NgModule({ imports: [CommonModule, RouterModule, AppCodeModule, AppDocModule], declarations: [IntroductionDoc, HelpNeededDoc, KeyPointsDoc, CommunicationDoc, PathwayDoc, BenefitsDoc, ClaDoc], diff --git a/src/app/showcase/doc/contribution/helpneededdoc.ts b/src/app/showcase/doc/contribution/helpneededdoc.ts index c956a83d958..fa983031a98 100644 --- a/src/app/showcase/doc/contribution/helpneededdoc.ts +++ b/src/app/showcase/doc/contribution/helpneededdoc.ts @@ -4,26 +4,24 @@ import { Component } from '@angular/core'; selector: 'helpneeded-doc', template: ` -

PrimeNG is a community-driven project backed by the expertise and sponsorship of PrimeTek, and we appreciate any help you can provide. Here are some areas where you can contribute:

-

Issue Triage

-

Help us manage issues by;

-
    -
  • Reproducing reported bugs
    • -
  • Clarifying issue descriptions
    • -
  • Tagging issues with appropriate labels
    • -
+

PrimeNG is a community-driven project backed by the expertise and sponsorship of PrimeTek, and we appreciate any help you can provide. Here are some areas where you can contribute:

+

Issue Triage

+

Help us manage issues by;

+
    +
  • Reproducing reported bugs
    • +
  • Clarifying issue descriptions
    • +
  • Tagging issues with appropriate labels
    • +
-

Sending Pull Requests

-

We encourage you to send pull requests, especially for issues tagged with the help-needed label.

+

Sending Pull Requests

+

We encourage you to send pull requests, especially for issues tagged with the help-needed label.

-

Community Support

-

- Assist other users by participating in the issue tracker, GitHub discussions, and the - PrimeLand Discord server. Your expertise can help others solve problems and improve their experience with PrimeNG. -

+

Community Support

+

+ Assist other users by participating in the issue tracker, GitHub discussions, and the + PrimeLand Discord server. Your expertise can help others solve problems and improve their experience with PrimeNG. +

` }) -export class HelpNeededDoc { - -} +export class HelpNeededDoc {} diff --git a/src/app/showcase/doc/contribution/keypoints.ts b/src/app/showcase/doc/contribution/keypoints.ts index b125eeac039..266855bd552 100644 --- a/src/app/showcase/doc/contribution/keypoints.ts +++ b/src/app/showcase/doc/contribution/keypoints.ts @@ -4,13 +4,11 @@ import { Component } from '@angular/core'; selector: 'keypoints-doc', template: ` -

- PrimeNG has several add-ons such as UI Kit, Premium Templates, and Blocks that rely on design tokens and styling. Any core structural changes, such as adding new props, events, or updating design tokens, should be communicated with the - core team to ensure consistency and compatibility. -

+

+ PrimeNG has several add-ons such as UI Kit, Premium Templates, and Blocks that rely on design tokens and styling. Any core structural changes, such as adding new props, events, or updating design tokens, should be communicated with + the core team to ensure consistency and compatibility. +

` }) -export class KeyPointsDoc { - -} +export class KeyPointsDoc {} diff --git a/src/app/showcase/doc/contribution/pathwaydoc.ts b/src/app/showcase/doc/contribution/pathwaydoc.ts index b5ffd0d5e31..f418aa927e0 100644 --- a/src/app/showcase/doc/contribution/pathwaydoc.ts +++ b/src/app/showcase/doc/contribution/pathwaydoc.ts @@ -4,18 +4,16 @@ import { Component } from '@angular/core'; selector: 'pathway-doc', template: ` -

PrimeTek offers an organization structure involving contributors and the core team:

-

Contributor Role

-

After a certain period of frequent contributions, a community member is offered the Contributor role. On average, it may take about three months, but the exact duration can vary depending on the individual commitment.

+

PrimeTek offers an organization structure involving contributors and the core team:

+

Contributor Role

+

After a certain period of frequent contributions, a community member is offered the Contributor role. On average, it may take about three months, but the exact duration can vary depending on the individual commitment.

-

Committer Role

-

If a contributor actively participates in the codebase and PRs, their role may be upgraded to a Committer level, providing direct commit access to the PrimeNG codebase.

+

Committer Role

+

If a contributor actively participates in the codebase and PRs, their role may be upgraded to a Committer level, providing direct commit access to the PrimeNG codebase.

-

Employment

-

PrimeTek prefers to hire team members from open source committers, so you may be offered a full-time position when a position becomes available.

+

Employment

+

PrimeTek prefers to hire team members from open source committers, so you may be offered a full-time position when a position becomes available.

 ` }) -export class PathwayDoc { - -} +export class PathwayDoc {} diff --git a/src/app/showcase/pages/contribution/contribution-routing.module.ts b/src/app/showcase/pages/contribution/contribution-routing.module.ts index 90c36197bb2..58544789aab 100755 --- a/src/app/showcase/pages/contribution/contribution-routing.module.ts +++ b/src/app/showcase/pages/contribution/contribution-routing.module.ts @@ -2,7 +2,6 @@ import { NgModule } from '@angular/core'; import { RouterModule } from '@angular/router'; import { ContributionComponent } from './contribution'; - @NgModule({ imports: [RouterModule.forChild([{ path: '', component: ContributionComponent }])], exports: [RouterModule] From 427612af20d2a8c3bd167dddfb37c2980c52f159 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 16:44:26 +0300 Subject: [PATCH 294/484] update changelog --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 71b1193fea1..e80c77311bc 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -814,6 +814,16 @@ - TypeError: this.focusedItemInfo.mutate is not a function [\#14119](https://github.com/primefaces/primeng/issues/14119) - Upgrade to Angular 17? [\#14063](https://github.com/primefaces/primeng/issues/14063) +## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [16.9.14-LTS](https://www.npmjs.com/package/primeng/v/16.9.14-lts) (2024-08-01) + +**Fixed bugs:** +- Password: Tooltip with tooltipEvent='focus' is never displayed [\#16106](https://github.com/primefaces/primeng/issues/16106) +- Breadcrumb | Disabled breadcrumbs should have 'aria-disabled' [\#16125](https://github.com/primefaces/primeng/issues/16125) +- Table> double call to (onLazyLoad) event [\#16070](https://github.com/primefaces/primeng/issues/16070) +- pBadge | Add missing badgeStyle & badgeStyleClass to directive [\#16133](https://github.com/primefaces/primeng/issues/16133) +- Breadcrumb | 'tabindex' property not working [\#16139](https://github.com/primefaces/primeng/issues/16139) +- Menubar: autoDisplay and autoHide broken [\#13512](https://github.com/primefaces/primeng/issues/13512) + ## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [16.9.13-LTS](https://www.npmjs.com/package/primeng/v/16.9.13-lts) (2024-07-18) **Fixed bugs:** From d204e645fd0cd74335ff0c2793fea4601fe9b836 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 16:46:08 +0300 Subject: [PATCH 295/484] update changelog --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 71b1193fea1..e80c77311bc 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -814,6 +814,16 @@ - TypeError: this.focusedItemInfo.mutate is not a function [\#14119](https://github.com/primefaces/primeng/issues/14119) - Upgrade to Angular 17? [\#14063](https://github.com/primefaces/primeng/issues/14063) +## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [16.9.14-LTS](https://www.npmjs.com/package/primeng/v/16.9.14-lts) (2024-08-01) + +**Fixed bugs:** +- Password: Tooltip with tooltipEvent='focus' is never displayed [\#16106](https://github.com/primefaces/primeng/issues/16106) +- Breadcrumb | Disabled breadcrumbs should have 'aria-disabled' [\#16125](https://github.com/primefaces/primeng/issues/16125) +- Table> double call to (onLazyLoad) event [\#16070](https://github.com/primefaces/primeng/issues/16070) +- pBadge | Add missing badgeStyle & badgeStyleClass to directive [\#16133](https://github.com/primefaces/primeng/issues/16133) +- Breadcrumb | 'tabindex' property not working [\#16139](https://github.com/primefaces/primeng/issues/16139) +- Menubar: autoDisplay and autoHide broken [\#13512](https://github.com/primefaces/primeng/issues/13512) + ## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [16.9.13-LTS](https://www.npmjs.com/package/primeng/v/16.9.13-lts) (2024-07-18) **Fixed bugs:** From 8a02632970fc880251c9356b1f350b6b78f57ca3 Mon Sep 17 00:00:00 2001 From: Aaron Shim <5382864+aaronshim@users.noreply.github.com> Date: Thu, 1 Aug 2024 10:11:06 -0400 Subject: [PATCH 296/484] Change .innerHTML assignments in table.ts to .textContent --- src/app/components/table/table.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/components/table/table.ts b/src/app/components/table/table.ts index 23b7f931c85..c5fba8770c2 100644 --- a/src/app/components/table/table.ts +++ b/src/app/components/table/table.ts @@ -2689,7 +2689,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable } `; }); - this.renderer.setProperty(this.styleElement, 'innerHTML', innerHTML); + this.renderer.setProperty(this.styleElement, 'textContent', innerHTML); } onRowDragStart(event: any, index: number) { @@ -2943,7 +2943,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable `; }); - this.styleElement.innerHTML = innerHTML; + this.styleElement.textContent = innerHTML; } } } @@ -3040,7 +3040,7 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable } } `; - this.renderer.setProperty(this.responsiveStyleElement, 'innerHTML', innerHTML); + this.renderer.setProperty(this.responsiveStyleElement, 'textContent', innerHTML); } } } From aaae556d9794d80a005821530b2f82c77faa32b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 17:12:48 +0300 Subject: [PATCH 297/484] update changelog --- CHANGELOG.md | 7 +++++++ src/app/showcase/data/versions.json | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e80c77311bc..6efe30bf820 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1486,6 +1486,13 @@ - Checkbox in p-treeNode always checked when using custom icon [\#12951](https://github.com/primefaces/primeng/issues/12951) - ConfirmDialog: Duplicated AcceptIcons [\#13001](https://github.com/primefaces/primeng/issues/13001) +## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [15.4.24-LTS](https://www.npmjs.com/package/primeng/v/15.4.24-lts) (2024-08-01) + +**Fixed bugs:** +- Password: Tooltip with tooltipEvent='focus' is never displayed [\#16106](https://github.com/primefaces/primeng/issues/16106) +- Table> double call to (onLazyLoad) event [\#16070](https://github.com/primefaces/primeng/issues/16070) +- pBadge | Add missing badgeStyle & badgeStyleClass to directive [\#16133](https://github.com/primefaces/primeng/issues/16133) + ## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [15.4.24-LTS](https://www.npmjs.com/package/primeng/v/15.4.24-lts) (2024-07-24) **Fixed bugs:** diff --git a/src/app/showcase/data/versions.json b/src/app/showcase/data/versions.json index 6260dab3907..e8eac2bf0d0 100644 --- a/src/app/showcase/data/versions.json +++ b/src/app/showcase/data/versions.json @@ -5,12 +5,12 @@ "url": "https://primeng.org" }, { - "version": "v16.9.13-lts", + "version": "v16.9.14-lts", "name": "v16", "url": "https://www.primefaces.org/primeng-v16-lts/" }, { - "version": "v15.4.24-lts", + "version": "v15.4.25-lts", "name": "v15", "url": "https://www.primefaces.org/primeng-v15-lts/" }, From 512f03d001eeb1479786425931ab14be759e0f97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Thu, 1 Aug 2024 17:22:20 +0300 Subject: [PATCH 298/484] fix typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6efe30bf820..e82264ce16d 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1486,7 +1486,7 @@ - Checkbox in p-treeNode always checked when using custom icon [\#12951](https://github.com/primefaces/primeng/issues/12951) - ConfirmDialog: Duplicated AcceptIcons [\#13001](https://github.com/primefaces/primeng/issues/13001) -## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [15.4.24-LTS](https://www.npmjs.com/package/primeng/v/15.4.24-lts) (2024-08-01) +## ![LTS](https://www.primefaces.org/wp-content/uploads/2020/01/lts-icon-24.png "PrimeNG LTS") [15.4.25-LTS](https://www.npmjs.com/package/primeng/v/15.4.25-lts) (2024-08-01) **Fixed bugs:** - Password: Tooltip with tooltipEvent='focus' is never displayed [\#16106](https://github.com/primefaces/primeng/issues/16106) From f72af89c4e80f3a5876fd5544dd01093218b481b Mon Sep 17 00:00:00 2001 From: Janik Schumacher Date: Thu, 1 Aug 2024 16:34:26 +0200 Subject: [PATCH 299/484] Fix for #15281 --- .../components/autocomplete/autocomplete.ts | 18 +++++++++++++----- src/app/components/overlay/overlay.ts | 16 ++++++++-------- 2 files changed, 21 insertions(+), 13 deletions(-) diff --git a/src/app/components/autocomplete/autocomplete.ts b/src/app/components/autocomplete/autocomplete.ts index 6dace6205bd..9687bc41837 100755 --- a/src/app/components/autocomplete/autocomplete.ts +++ b/src/app/components/autocomplete/autocomplete.ts @@ -880,7 +880,14 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr return typeof this.modelValue() === 'string' && this.optionValue; } - constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, public renderer: Renderer2, public cd: ChangeDetectorRef, public config: PrimeNGConfig, public overlayService: OverlayService, private zone: NgZone) { + constructor( + public el: ElementRef, + public renderer: Renderer2, + public cd: ChangeDetectorRef, + public config: PrimeNGConfig, + public overlayService: OverlayService, + private zone: NgZone + ) { effect(() => { this.filled = ObjectUtils.isNotEmpty(this.modelValue()); }); @@ -1100,12 +1107,12 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr this.updateModel(query); } - if (query.length === 0 && !this.multiple) { + if (query.length === 0 && !this.multiple && !this.completeOnFocus) { this.onClear.emit(); setTimeout(() => { this.hide(); - }, this.delay / 2); + }); } else { if (query.length >= this.minLength) { this.focusedOptionIndex.set(-1); @@ -1147,6 +1154,7 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr if (!this.dirty && this.completeOnFocus) { this.search(event, event.target.value, 'focus'); + this.show(); } this.dirty = true; this.focused = true; @@ -1458,8 +1466,8 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr return; } - //do not search blank values on input change - if (source === 'input' && query.trim().length === 0) { + //do not search on input change if minLength is not met + if (source === 'input' && query.trim().length < this.minLength) { return; } this.loading = true; diff --git a/src/app/components/overlay/overlay.ts b/src/app/components/overlay/overlay.ts index 2d2e02a7b51..6d13ee08d48 100644 --- a/src/app/components/overlay/overlay.ts +++ b/src/app/components/overlay/overlay.ts @@ -524,16 +524,15 @@ export class Overlay implements AfterContentInit, OnDestroy { case 'void': if (!this.visible) { this.hide(container, true); - } - - this.unbindListeners(); + this.modalVisible = false; + this.unbindListeners(); - DomHandler.appendOverlay(this.overlayEl, this.targetEl, this.appendTo); - ZIndexUtils.clear(container); - this.modalVisible = false; - this.cd.markForCheck(); + DomHandler.appendOverlay(this.overlayEl, this.targetEl, this.appendTo); + ZIndexUtils.clear(container); + this.cd.markForCheck(); - break; + break; + } } this.handleEvents('onAnimationDone', event); @@ -546,6 +545,7 @@ export class Overlay implements AfterContentInit, OnDestroy { } bindListeners() { + this.unbindListeners(); this.bindScrollListener(); this.bindDocumentClickListener(); this.bindDocumentResizeListener(); From 882089edaf1fffbef5d85ea96d1fb38770f2be33 Mon Sep 17 00:00:00 2001 From: Janik Schumacher Date: Fri, 2 Aug 2024 13:25:34 +0200 Subject: [PATCH 300/484] fix(autocomplete): enter keypress event --- src/app/components/autocomplete/autocomplete.ts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/app/components/autocomplete/autocomplete.ts b/src/app/components/autocomplete/autocomplete.ts index 6dace6205bd..86411498abe 100755 --- a/src/app/components/autocomplete/autocomplete.ts +++ b/src/app/components/autocomplete/autocomplete.ts @@ -880,7 +880,15 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr return typeof this.modelValue() === 'string' && this.optionValue; } - constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, public renderer: Renderer2, public cd: ChangeDetectorRef, public config: PrimeNGConfig, public overlayService: OverlayService, private zone: NgZone) { + constructor( + @Inject(DOCUMENT) private document: Document, + public el: ElementRef, + public renderer: Renderer2, + public cd: ChangeDetectorRef, + public config: PrimeNGConfig, + public overlayService: OverlayService, + private zone: NgZone + ) { effect(() => { this.filled = ObjectUtils.isNotEmpty(this.modelValue()); }); @@ -1368,12 +1376,11 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr } else { if (this.focusedOptionIndex() !== -1) { this.onOptionSelect(event, this.visibleOptions()[this.focusedOptionIndex()]); + event.preventDefault(); } this.hide(); } - - event.preventDefault(); } onEscapeKey(event) { From e7b611ba4c554aa4beeebe7a8a1ac8d74534507e Mon Sep 17 00:00:00 2001 From: PC0 Date: Sat, 3 Aug 2024 12:38:53 +0330 Subject: [PATCH 301/484] Update scroller.ts no need to set fixed height when scrollHeight === '100%' which is coming from scrollHeight = flex of all other components --- src/app/components/scroller/scroller.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/scroller/scroller.ts b/src/app/components/scroller/scroller.ts index f05ab77826d..b7e706533cc 100644 --- a/src/app/components/scroller/scroller.ts +++ b/src/app/components/scroller/scroller.ts @@ -866,7 +866,7 @@ export class Scroller implements OnInit, AfterContentInit, AfterViewChecked, OnD } setSpacerSize() { - if (this._items) { + if (this._scrollHeight !== '100%' && this._items) { const contentPos = this.getContentPosition(); const setProp = (_name: string, _value: any, _size: number, _cpos: number = 0) => (this.spacerStyle = { ...this.spacerStyle, ...{ [`${_name}`]: (_value || []).length * _size + _cpos + 'px' } }); From 7e9799e18a55aded864f3ecf72b265b50b85fe3a Mon Sep 17 00:00:00 2001 From: Khalil Khaled Date: Mon, 5 Aug 2024 15:19:13 +0100 Subject: [PATCH 302/484] Fix typo in calendar documentation Fix typo in Popup Keyboard Support section. --- src/app/showcase/doc/calendar/accessibilitydoc.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/showcase/doc/calendar/accessibilitydoc.ts b/src/app/showcase/doc/calendar/accessibilitydoc.ts index 0279ff16ec5..43bead30ba5 100644 --- a/src/app/showcase/doc/calendar/accessibilitydoc.ts +++ b/src/app/showcase/doc/calendar/accessibilitydoc.ts @@ -87,7 +87,7 @@ import { Code } from '@domain/code'; shift + tab - Moves focus to the next focusable element within the popup. + Moves focus to the previous focusable element within the popup. From d74108b90827cca43bd827ed644ab30c81b602fc Mon Sep 17 00:00:00 2001 From: Khalil Khaled Date: Tue, 6 Aug 2024 16:07:02 +0100 Subject: [PATCH 303/484] Fixed #16176 - Calendar | add checks on panelStyle width and min-width before applying alignOverlay styles --- src/app/components/calendar/calendar.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/app/components/calendar/calendar.ts b/src/app/components/calendar/calendar.ts index d02590d3f60..ad25df2ec3a 100644 --- a/src/app/components/calendar/calendar.ts +++ b/src/app/components/calendar/calendar.ts @@ -3069,10 +3069,16 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { } else if (this.overlay) { if (this.appendTo) { if (this.view === 'date') { - this.overlay.style.width = DomHandler.getOuterWidth(this.overlay) + 'px'; - this.overlay.style.minWidth = DomHandler.getOuterWidth(this.inputfieldViewChild?.nativeElement) + 'px'; + if (!this.overlay.style.width) { + this.overlay.style.width = DomHandler.getOuterWidth(this.overlay) + 'px'; + } + if (!this.overlay.style.minWidth) { + this.overlay.style.minWidth = DomHandler.getOuterWidth(this.inputfieldViewChild?.nativeElement) + 'px'; + } } else { - this.overlay.style.width = DomHandler.getOuterWidth(this.inputfieldViewChild?.nativeElement) + 'px'; + if (!this.overlay.style.width) { + this.overlay.style.width = DomHandler.getOuterWidth(this.inputfieldViewChild?.nativeElement) + 'px'; + } } DomHandler.absolutePosition(this.overlay, this.inputfieldViewChild?.nativeElement); From c512569f8cc1d243ebc542cae4d0ee51aa7483c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Wed, 7 Aug 2024 11:58:46 +0300 Subject: [PATCH 304/484] Fixed #16152 - ListBox component accessibility issues --- src/app/components/listbox/listbox.ts | 40 ++++++++++++--------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/src/app/components/listbox/listbox.ts b/src/app/components/listbox/listbox.ts index 5897cd07b21..6deea4d394e 100755 --- a/src/app/components/listbox/listbox.ts +++ b/src/app/components/listbox/listbox.ts @@ -49,16 +49,7 @@ export const LISTBOX_VALUE_ACCESSOR: any = { selector: 'p-listbox', template: `
- - +
@@ -105,6 +96,7 @@ export const LISTBOX_VALUE_ACCESSOR: any = { [tabindex]="!disabled && !focused ? tabindex : -1" (input)="onFilterChange($event)" (keydown)="onFilterKeyDown($event)" + (focus)="onFilterFocus($event)" (blur)="onFilterBlur($event)" /> @@ -117,7 +109,7 @@ export const LISTBOX_VALUE_ACCESSOR: any = {
-
+
@@ -226,16 +218,7 @@ export const LISTBOX_VALUE_ACCESSOR: any = { {{ selectedMessageText }} - - +
`, providers: [LISTBOX_VALUE_ACCESSOR], @@ -545,6 +528,8 @@ export class Listbox implements AfterContentInit, OnInit, ControlValueAccessor, @ViewChild('list') listViewChild: Nullable; + @ViewChild('wrapper') wrapperViewChild: Nullable; + @ContentChild(Header) headerFacet: Nullable>; @ContentChild(Footer) footerFacet: Nullable>; @@ -593,6 +578,8 @@ export class Listbox implements AfterContentInit, OnInit, ControlValueAccessor, focused: boolean | undefined; + scrollerTabIndex: string = '0'; + get containerClass() { return { 'p-listbox p-component': true, @@ -949,6 +936,8 @@ export class Listbox implements AfterContentInit, OnInit, ControlValueAccessor, onFocusout(event: FocusEvent) { if (!this.el.nativeElement.contains(event.relatedTarget) && this.lastHiddenFocusableElement && this.firstHiddenFocusableElement) { this.firstHiddenFocusableElement.nativeElement.tabIndex = this.lastHiddenFocusableElement.nativeElement.tabIndex = undefined; + this.wrapperViewChild.nativeElement.tabIndex = '0'; + this.scrollerTabIndex = '0'; } } @@ -957,6 +946,9 @@ export class Listbox implements AfterContentInit, OnInit, ControlValueAccessor, const focusedOptionIndex = this.focusedOptionIndex() !== -1 ? this.focusedOptionIndex() : this.autoOptionFocus ? this.findFirstFocusedOptionIndex() : -1; this.focusedOptionIndex.set(focusedOptionIndex); this.onFocus.emit(event); + + this.wrapperViewChild.nativeElement.tabIndex = '-1'; + this.scrollerTabIndex = '-1'; } onListBlur(event: FocusEvent) { @@ -1010,6 +1002,10 @@ export class Listbox implements AfterContentInit, OnInit, ControlValueAccessor, !this.virtualScrollerDisabled && this.scroller.scrollToIndex(0); } + + onFilterFocus(event: FocusEvent){ + this.wrapperViewChild.nativeElement.tabIndex = '-1'; + } onFilterBlur(event: FocusEvent) { this.focusedOptionIndex.set(-1); From 0bb5e41bcea2b589daf0dddb3b2e92707ed6349f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Wed, 7 Aug 2024 13:57:39 +0300 Subject: [PATCH 305/484] Fixed #16169 - Component: colorPicker - inline=true property doesnt set the appropriate color --- src/app/components/colorpicker/colorpicker.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/app/components/colorpicker/colorpicker.ts b/src/app/components/colorpicker/colorpicker.ts index fb2c2593dd0..ef242fc3bf6 100755 --- a/src/app/components/colorpicker/colorpicker.ts +++ b/src/app/components/colorpicker/colorpicker.ts @@ -401,9 +401,11 @@ export class ColorPicker implements ControlValueAccessor, OnDestroy { this.value = this.HEXtoHSB(this.defaultColor); } - this.updateColorSelector(); - this.updateUI(); - this.cd.markForCheck(); + setTimeout(() => { + this.updateColorSelector(); + this.updateUI(); + this.cd.markForCheck(); + }); } updateColorSelector() { From 641f569ce14a0afcbb633e284b77e61f1da8bcba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Wed, 7 Aug 2024 14:18:53 +0300 Subject: [PATCH 306/484] Fixed #16156 - Tree: Accessibility issues --- src/app/components/tree/tree.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/tree/tree.ts b/src/app/components/tree/tree.ts index be53fb4c1b9..1aba63b5063 100755 --- a/src/app/components/tree/tree.ts +++ b/src/app/components/tree/tree.ts @@ -100,7 +100,7 @@ import { (dragend)="onDragStop($event)" [ngClass]="{ 'p-treenode-selectable': tree.selectionMode && node.selectable !== false, 'p-treenode-dragover': draghoverNode, 'p-highlight': isSelected() }" > -
-
+
PanelMenu)) public panelMenu: PanelMenu, public el: ElementRef @@ -267,6 +269,7 @@ export class PanelMenuSub { onItemClick(event, processedItem) { if (!this.isItemDisabled(processedItem)) { + this.animating = true; this.getItemProp(processedItem, 'command', { originalEvent: event, item: processedItem.item }); this.itemToggle.emit({ processedItem, expanded: !this.isItemActive(processedItem) }); } @@ -275,6 +278,10 @@ export class PanelMenuSub { onItemToggle(event) { this.itemToggle.emit(event); } + + onToggleDone() { + this.animating = false; + } } @Component({ From 0116d6e61d5bc7fb5e591d2c1411d83504ab3be2 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Thu, 21 Nov 2024 10:57:35 +0000 Subject: [PATCH 435/484] Update issue-labeled.yml --- .github/workflows/issue-labeled.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/issue-labeled.yml b/.github/workflows/issue-labeled.yml index 74d6833a25e..8f1b02a35fd 100644 --- a/.github/workflows/issue-labeled.yml +++ b/.github/workflows/issue-labeled.yml @@ -62,4 +62,4 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} issue-number: ${{ github.event.issue.number }} body: | - Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. **Make sure to reference this issue in your pull request.** :sparkles: Thank you for your contribution! :sparkles: + Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. [**Make sure to reference this issue in your pull request.**](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) :sparkles: Thank you for your contribution! :sparkles: From 7c9ffdb94f353bfe73470150855ac68b11ac68d2 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Thu, 21 Nov 2024 11:25:28 +0000 Subject: [PATCH 436/484] Update pr-checker.yml --- .github/workflows/pr-checker.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index acc4a070a15..cef7115ab74 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -46,10 +46,13 @@ jobs: - name: Add Code Format Fail Comment if: always() && steps.codeFormat.outcome == 'failure' - uses: thollander/actions-comment-pull-request@v1 + uses: actions-cool/issues-helper@v3 with: - message: | - Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. + actions: 'create-comment' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + body: | + Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. #- name: Add Unit Test Fail Comment # if: always() && steps.unitTest.outcome == 'failure' From 92078a30b38a814b52e4d1f659b0c6215f143e9f Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Thu, 21 Nov 2024 11:26:59 +0000 Subject: [PATCH 437/484] Update pr-checker.yml --- .github/workflows/pr-checker.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index cef7115ab74..5d271a91212 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -32,12 +32,12 @@ jobs: - name: Install packages run: | - npm install + pnpm install - name: Code Format id: codeFormat run: | - npm run format:check + pnpm run format:check #- name: Unit Test # id: unitTest From 00ce2e5724514d64edc7ca83bb53cf5a6ee5febd Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Thu, 21 Nov 2024 11:27:58 +0000 Subject: [PATCH 438/484] Update pr-checker.yml --- .github/workflows/pr-checker.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index 5d271a91212..cef7115ab74 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -32,12 +32,12 @@ jobs: - name: Install packages run: | - pnpm install + npm install - name: Code Format id: codeFormat run: | - pnpm run format:check + npm run format:check #- name: Unit Test # id: unitTest From d82247ebcb67dec50ead1b6416b7b4ab06b6d6c6 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Thu, 21 Nov 2024 11:44:33 +0000 Subject: [PATCH 439/484] Update inputotp.ts --- src/app/components/inputotp/inputotp.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/inputotp/inputotp.ts b/src/app/components/inputotp/inputotp.ts index 698e9d34b37..5d76f5baed8 100644 --- a/src/app/components/inputotp/inputotp.ts +++ b/src/app/components/inputotp/inputotp.ts @@ -326,7 +326,7 @@ export class InputOtp implements AfterContentInit { if (paste.length) { let pastedCode = paste.substring(0, this.length); - + if (!this.integerOnly || !isNaN(pastedCode)) { this.tokens = pastedCode.split(''); this.updateModel(event); From cb341b86f9a85bf99a9f53dd4c78789c99b3d2e8 Mon Sep 17 00:00:00 2001 From: Mark Paniterce <73551111+mark7p@users.noreply.github.com> Date: Fri, 22 Nov 2024 21:05:42 +0800 Subject: [PATCH 440/484] fix lack of optional chaining (#16807) --- src/app/components/scroller/scroller.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/scroller/scroller.ts b/src/app/components/scroller/scroller.ts index 0b18c2778ba..7241896072d 100644 --- a/src/app/components/scroller/scroller.ts +++ b/src/app/components/scroller/scroller.ts @@ -882,7 +882,7 @@ export class Scroller implements OnInit, AfterContentInit, AfterViewChecked, OnD setProp('height', numItems, this._itemSize[0]); setProp('width', this._columns?.length || this._items[1]?.length, this._itemSize[1]); } else { - this.horizontal ? setProp('width', this._columns.length || this._items.length, this._itemSize) : setProp('height', numItems, this._itemSize); + this.horizontal ? setProp('width', this._columns?.length || this._items.length, this._itemSize) : setProp('height', numItems, this._itemSize); } } } From cc764e891208ce6f59328e041af45286e95b739f Mon Sep 17 00:00:00 2001 From: Sulidi Maimaitiming Date: Mon, 25 Nov 2024 11:02:52 +0100 Subject: [PATCH 441/484] feat(angular): allow Angular 19 and zone.js 0.15 (#16783) Co-authored-by: Sulidi Maimaitiming --- src/app/components/package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/components/package.json b/src/app/components/package.json index 53abed82b7d..9a647fc0f2c 100644 --- a/src/app/components/package.json +++ b/src/app/components/package.json @@ -18,10 +18,10 @@ "module": "primeng.js", "typings": "primeng.d.ts", "peerDependencies": { - "@angular/core": "^17.0.0 || ^18.0.0", - "@angular/common": "^17.0.0 || ^18.0.0", - "@angular/forms": "^17.0.0 || ^18.0.0", + "@angular/core": "^17.0.0 || ^18.0.0 || ^19.0.0", + "@angular/common": "^17.0.0 || ^18.0.0 || ^19.0.0", + "@angular/forms": "^17.0.0 || ^18.0.0 || ^19.0.0", "rxjs": "^6.0.0 || ^7.8.1", - "zone.js": "~0.14.0" + "zone.js": "~0.14.0 || ~0.15.0" } } From c2556eb087974502168106e51e8d999ff8a22b51 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Mon, 25 Nov 2024 10:03:48 +0000 Subject: [PATCH 442/484] Revert "feat(angular): allow Angular 19 and zone.js 0.15 (#16783)" (#16829) This reverts commit cc764e891208ce6f59328e041af45286e95b739f. --- src/app/components/package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/components/package.json b/src/app/components/package.json index 9a647fc0f2c..53abed82b7d 100644 --- a/src/app/components/package.json +++ b/src/app/components/package.json @@ -18,10 +18,10 @@ "module": "primeng.js", "typings": "primeng.d.ts", "peerDependencies": { - "@angular/core": "^17.0.0 || ^18.0.0 || ^19.0.0", - "@angular/common": "^17.0.0 || ^18.0.0 || ^19.0.0", - "@angular/forms": "^17.0.0 || ^18.0.0 || ^19.0.0", + "@angular/core": "^17.0.0 || ^18.0.0", + "@angular/common": "^17.0.0 || ^18.0.0", + "@angular/forms": "^17.0.0 || ^18.0.0", "rxjs": "^6.0.0 || ^7.8.1", - "zone.js": "~0.14.0 || ~0.15.0" + "zone.js": "~0.14.0" } } From 99aaa9aa92580bd8bd372ed0e047e8833970535a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Mon, 2 Dec 2024 12:46:22 +0300 Subject: [PATCH 443/484] revert discount --- src/app/showcase/layout/templates/templatelicense.ts | 4 ++-- src/app/showcase/pages/lts/lts.component.html | 7 +++---- src/app/showcase/pages/templates/apollo/apollo.ts | 2 +- src/app/showcase/pages/templates/avalon/avalon.ts | 2 +- src/app/showcase/pages/templates/diamond/diamond.ts | 2 +- src/app/showcase/pages/templates/freya/freya.ts | 2 +- src/app/showcase/pages/templates/poseidon/poseidon.ts | 2 +- src/app/showcase/pages/templates/ultima/ultima.ts | 2 +- src/app/showcase/pages/templates/verona/verona.ts | 2 +- src/app/showcase/pages/uikit/uikit.component.html | 6 ++---- 10 files changed, 14 insertions(+), 17 deletions(-) diff --git a/src/app/showcase/layout/templates/templatelicense.ts b/src/app/showcase/layout/templates/templatelicense.ts index 1ed195cbd87..00b2621f71d 100644 --- a/src/app/showcase/layout/templates/templatelicense.ts +++ b/src/app/showcase/layout/templates/templatelicense.ts @@ -12,8 +12,8 @@ import { SharedModule } from 'primeng/api';
{{ licenseData?.title }}
-

{{ licenseData?.price }}

-

{{ licenseData?.discount }}

+

{{ licenseData?.price }}

+

{{ licenseData?.discount }}

diff --git a/src/app/showcase/pages/lts/lts.component.html b/src/app/showcase/pages/lts/lts.component.html index c3b7fb0b722..589e56edf0a 100755 --- a/src/app/showcase/pages/lts/lts.component.html +++ b/src/app/showcase/pages/lts/lts.component.html @@ -134,8 +134,8 @@
- $249 - $149 + + $249
@@ -175,8 +175,7 @@
- $990 - $490 + $990
diff --git a/src/app/showcase/pages/templates/apollo/apollo.ts b/src/app/showcase/pages/templates/apollo/apollo.ts index f91efa3d721..ec63c225609 100644 --- a/src/app/showcase/pages/templates/apollo/apollo.ts +++ b/src/app/showcase/pages/templates/apollo/apollo.ts @@ -257,7 +257,7 @@ export class ApolloPage { license = { documentLink: 'https://apollo.primeng.org/documentation/', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/avalon/avalon.ts b/src/app/showcase/pages/templates/avalon/avalon.ts index 3dc3ef53e30..29470e19f16 100644 --- a/src/app/showcase/pages/templates/avalon/avalon.ts +++ b/src/app/showcase/pages/templates/avalon/avalon.ts @@ -223,7 +223,7 @@ export class AvalonPage { license = { documentLink: 'https://avalon.primeng.org/documentation', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/diamond/diamond.ts b/src/app/showcase/pages/templates/diamond/diamond.ts index abeb224f473..8f98d442773 100644 --- a/src/app/showcase/pages/templates/diamond/diamond.ts +++ b/src/app/showcase/pages/templates/diamond/diamond.ts @@ -222,7 +222,7 @@ export class DiamondPage { license = { documentLink: 'https://diamond.primeng.org/documentation/', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/freya/freya.ts b/src/app/showcase/pages/templates/freya/freya.ts index 54de94cbdf7..2de9dc7868a 100644 --- a/src/app/showcase/pages/templates/freya/freya.ts +++ b/src/app/showcase/pages/templates/freya/freya.ts @@ -215,7 +215,7 @@ export class FreyaPage { license = { documentLink: 'https://freya.primeng.org/documentation', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/poseidon/poseidon.ts b/src/app/showcase/pages/templates/poseidon/poseidon.ts index 9002937ed15..04c48b409d0 100644 --- a/src/app/showcase/pages/templates/poseidon/poseidon.ts +++ b/src/app/showcase/pages/templates/poseidon/poseidon.ts @@ -172,7 +172,7 @@ export class PoseidonPage { license = { documentLink: 'https://poseidon.primeng.org/documentation/', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/ultima/ultima.ts b/src/app/showcase/pages/templates/ultima/ultima.ts index 1655c6b280a..412b3f47b55 100644 --- a/src/app/showcase/pages/templates/ultima/ultima.ts +++ b/src/app/showcase/pages/templates/ultima/ultima.ts @@ -217,7 +217,7 @@ export class UltimaPage { license = { documentLink: 'https://ultima.primeng.org/documentation/', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/templates/verona/verona.ts b/src/app/showcase/pages/templates/verona/verona.ts index b13b4971d95..49541a60eb6 100644 --- a/src/app/showcase/pages/templates/verona/verona.ts +++ b/src/app/showcase/pages/templates/verona/verona.ts @@ -207,7 +207,7 @@ export class VeronaPage { license = { documentLink: 'https://verona.primeng.org/documentation', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/uikit/uikit.component.html b/src/app/showcase/pages/uikit/uikit.component.html index 6deabf155cb..1fbfcd5246d 100755 --- a/src/app/showcase/pages/uikit/uikit.component.html +++ b/src/app/showcase/pages/uikit/uikit.component.html @@ -150,8 +150,7 @@
For individual designers
- $99 - $49 + $249
    @@ -194,8 +193,7 @@
    - $249 - $149 + $990
    From 4cff23ca56d3ccd5ab25a98be921358b73b8e5c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Mon, 2 Dec 2024 15:14:45 +0300 Subject: [PATCH 444/484] update uikit & atlantis --- src/app/showcase/pages/templates/atlantis/atlantis.ts | 2 +- src/app/showcase/pages/uikit/uikit.component.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/showcase/pages/templates/atlantis/atlantis.ts b/src/app/showcase/pages/templates/atlantis/atlantis.ts index 65f8d13a682..adf4ea40a6c 100644 --- a/src/app/showcase/pages/templates/atlantis/atlantis.ts +++ b/src/app/showcase/pages/templates/atlantis/atlantis.ts @@ -199,7 +199,7 @@ export class AtlantisPage { license = { documentLink: 'https://atlantis.primeng.org/documentation', description: 'The download package is an Angular CLI-based project containing all source code of the application deployed at the live demo. The project code is written in TypeScript.', - showDiscount: true, + showDiscount: false, licenseDetails: [ { title: 'Basic License', diff --git a/src/app/showcase/pages/uikit/uikit.component.html b/src/app/showcase/pages/uikit/uikit.component.html index 1fbfcd5246d..4d41732bbf2 100755 --- a/src/app/showcase/pages/uikit/uikit.component.html +++ b/src/app/showcase/pages/uikit/uikit.component.html @@ -236,7 +236,7 @@
    For large teams
    - EXCLUSIVE DEALS + EXCLUSIVE DEALS
      From 00843a739c0f92311cabe9870ac945ba96fb55bd Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 10:53:04 +0000 Subject: [PATCH 445/484] Update issue-labeled.yml --- .github/workflows/issue-labeled.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/issue-labeled.yml b/.github/workflows/issue-labeled.yml index 8f1b02a35fd..1f3c1b0f9c6 100644 --- a/.github/workflows/issue-labeled.yml +++ b/.github/workflows/issue-labeled.yml @@ -22,7 +22,7 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} issue-number: ${{ github.event.issue.number }} body: | - We're unable to replicate your issue, if you are able to create a reproducer by using [PrimeNG Issue Template](https://stackblitz.com/github/primefaces/primeng-issue-template) or add details please edit this issue. This issue will be closed if no activities in 20 days. + We're unable to replicate your issue. Could you please try it with the latest PrimeNG version? If the problem continues, could you create a reproducer using [PrimeNG Issue Template](https://stackblitz.com/github/primefaces/primeng-issue-template) or provide additional details by editing this issue? This issue will be closed if no activities in 20 days. - name: Needs Upvote if: contains(github.event.label.name, 'Needs Upvote') From e76082019bcb91ad43dedb26a95c16223dad2def Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 10:57:40 +0000 Subject: [PATCH 446/484] Update issue-inactive-checker.yml --- .github/workflows/issue-inactive-checker.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/issue-inactive-checker.yml b/.github/workflows/issue-inactive-checker.yml index a0e3272ac6d..1bf11a48988 100644 --- a/.github/workflows/issue-inactive-checker.yml +++ b/.github/workflows/issue-inactive-checker.yml @@ -14,9 +14,10 @@ jobs: pull-requests: write runs-on: ubuntu-latest steps: - - name: cannot replicate + - name: Cannot Replicate uses: actions-cool/issues-helper@v3 with: actions: "close-issues" - labels: "cannot replicate" + labels: "Resolution: Cannot Replicate" + token: ${{ secrets.GITHUB_TOKEN }} inactive-day: 20 From d57ed76e5399f2421f2614b4bf76411aac30dda6 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:38:21 +0000 Subject: [PATCH 447/484] Create add-projects --- .github/workflows/add-projects | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/workflows/add-projects diff --git a/.github/workflows/add-projects b/.github/workflows/add-projects new file mode 100644 index 00000000000..95efa160d54 --- /dev/null +++ b/.github/workflows/add-projects @@ -0,0 +1,30 @@ +name: Add to GitHub Project +on: + issues: + types: + - milestoned + pull_request: + types: + - milestoned + +jobs: + add-to-project: + runs-on: ubuntu-latest + steps: + - name: Determine Event Type + id: determine-type + run: | + if [[ "${{ github.event_name }}" == "issues" ]]; then + echo "type=issue" >> $GITHUB_OUTPUT + echo "content_id=${{ github.event.issue.node_id }}" >> $GITHUB_OUTPUT + elif [[ "${{ github.event_name }}" == "pull_request" ]]; then + echo "type=pull_request" >> $GITHUB_OUTPUT + echo "content_id=${{ github.event.pull_request.node_id }}" >> $GITHUB_OUTPUT + fi + + - name: Add to GitHub Project + uses: actions/add-to-project@v1 + with: + project-url: https://github.com/orgs/primefaces/projects/4 + github-token: ${{ secrets.GITHUB_TOKEN }} + content-id: ${{ steps.determine-type.outputs.content_id }} From 9bc2383e2b1540fc8e66ed02fa43d791aa89a73d Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:38:58 +0000 Subject: [PATCH 448/484] Delete .github/workflows/add-projects --- .github/workflows/add-projects | 30 ------------------------------ 1 file changed, 30 deletions(-) delete mode 100644 .github/workflows/add-projects diff --git a/.github/workflows/add-projects b/.github/workflows/add-projects deleted file mode 100644 index 95efa160d54..00000000000 --- a/.github/workflows/add-projects +++ /dev/null @@ -1,30 +0,0 @@ -name: Add to GitHub Project -on: - issues: - types: - - milestoned - pull_request: - types: - - milestoned - -jobs: - add-to-project: - runs-on: ubuntu-latest - steps: - - name: Determine Event Type - id: determine-type - run: | - if [[ "${{ github.event_name }}" == "issues" ]]; then - echo "type=issue" >> $GITHUB_OUTPUT - echo "content_id=${{ github.event.issue.node_id }}" >> $GITHUB_OUTPUT - elif [[ "${{ github.event_name }}" == "pull_request" ]]; then - echo "type=pull_request" >> $GITHUB_OUTPUT - echo "content_id=${{ github.event.pull_request.node_id }}" >> $GITHUB_OUTPUT - fi - - - name: Add to GitHub Project - uses: actions/add-to-project@v1 - with: - project-url: https://github.com/orgs/primefaces/projects/4 - github-token: ${{ secrets.GITHUB_TOKEN }} - content-id: ${{ steps.determine-type.outputs.content_id }} From 47f3b0f16a2cce35ba9f51ff5de87d60a01b7264 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:40:10 +0000 Subject: [PATCH 449/484] Create add-projects.yml --- .github/workflows/add-projects.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/workflows/add-projects.yml diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml new file mode 100644 index 00000000000..95efa160d54 --- /dev/null +++ b/.github/workflows/add-projects.yml @@ -0,0 +1,30 @@ +name: Add to GitHub Project +on: + issues: + types: + - milestoned + pull_request: + types: + - milestoned + +jobs: + add-to-project: + runs-on: ubuntu-latest + steps: + - name: Determine Event Type + id: determine-type + run: | + if [[ "${{ github.event_name }}" == "issues" ]]; then + echo "type=issue" >> $GITHUB_OUTPUT + echo "content_id=${{ github.event.issue.node_id }}" >> $GITHUB_OUTPUT + elif [[ "${{ github.event_name }}" == "pull_request" ]]; then + echo "type=pull_request" >> $GITHUB_OUTPUT + echo "content_id=${{ github.event.pull_request.node_id }}" >> $GITHUB_OUTPUT + fi + + - name: Add to GitHub Project + uses: actions/add-to-project@v1 + with: + project-url: https://github.com/orgs/primefaces/projects/4 + github-token: ${{ secrets.GITHUB_TOKEN }} + content-id: ${{ steps.determine-type.outputs.content_id }} From b8394e14c4a5035a28eb38416bb10bc44e3fd6e9 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:45:08 +0000 Subject: [PATCH 450/484] Update add-projects.yml --- .github/workflows/add-projects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml index 95efa160d54..c2e81be08ea 100644 --- a/.github/workflows/add-projects.yml +++ b/.github/workflows/add-projects.yml @@ -23,7 +23,7 @@ jobs: fi - name: Add to GitHub Project - uses: actions/add-to-project@v1 + uses: actions/add-to-project@1.0.2 with: project-url: https://github.com/orgs/primefaces/projects/4 github-token: ${{ secrets.GITHUB_TOKEN }} From 6f070f06f030c7410005ea61cf9f56a1dd1022eb Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:49:24 +0000 Subject: [PATCH 451/484] Update add-projects.yml --- .github/workflows/add-projects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml index c2e81be08ea..5b62a147acd 100644 --- a/.github/workflows/add-projects.yml +++ b/.github/workflows/add-projects.yml @@ -23,7 +23,7 @@ jobs: fi - name: Add to GitHub Project - uses: actions/add-to-project@1.0.2 + uses: actions/add-to-project@v1.0.2 with: project-url: https://github.com/orgs/primefaces/projects/4 github-token: ${{ secrets.GITHUB_TOKEN }} From 8c50966168b029a2469addd155a7a6a505eccb31 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:56:33 +0000 Subject: [PATCH 452/484] Update add-projects.yml --- .github/workflows/add-projects.yml | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml index 5b62a147acd..a9c2062ada4 100644 --- a/.github/workflows/add-projects.yml +++ b/.github/workflows/add-projects.yml @@ -11,20 +11,9 @@ jobs: add-to-project: runs-on: ubuntu-latest steps: - - name: Determine Event Type - id: determine-type - run: | - if [[ "${{ github.event_name }}" == "issues" ]]; then - echo "type=issue" >> $GITHUB_OUTPUT - echo "content_id=${{ github.event.issue.node_id }}" >> $GITHUB_OUTPUT - elif [[ "${{ github.event_name }}" == "pull_request" ]]; then - echo "type=pull_request" >> $GITHUB_OUTPUT - echo "content_id=${{ github.event.pull_request.node_id }}" >> $GITHUB_OUTPUT - fi - - - name: Add to GitHub Project - uses: actions/add-to-project@v1.0.2 + - name: Add Issue/PR to GitHub Project + uses: actions/add-to-project@v1 with: project-url: https://github.com/orgs/primefaces/projects/4 github-token: ${{ secrets.GITHUB_TOKEN }} - content-id: ${{ steps.determine-type.outputs.content_id }} + content-id: ${{ github.event.issue.node_id || github.event.pull_request.node_id }} From deb0605a5c164bd68dc2ef2d7f48fa8d81b9a138 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 11:57:39 +0000 Subject: [PATCH 453/484] Update add-projects.yml --- .github/workflows/add-projects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml index a9c2062ada4..7245638fde6 100644 --- a/.github/workflows/add-projects.yml +++ b/.github/workflows/add-projects.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Add Issue/PR to GitHub Project - uses: actions/add-to-project@v1 + uses: actions/add-to-project@v1.0.2 with: project-url: https://github.com/orgs/primefaces/projects/4 github-token: ${{ secrets.GITHUB_TOKEN }} From 989ab2568da648b210a960f4dd1338ba1cf3748f Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Wed, 4 Dec 2024 12:07:49 +0000 Subject: [PATCH 454/484] Delete .github/workflows/add-projects.yml --- .github/workflows/add-projects.yml | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 .github/workflows/add-projects.yml diff --git a/.github/workflows/add-projects.yml b/.github/workflows/add-projects.yml deleted file mode 100644 index 7245638fde6..00000000000 --- a/.github/workflows/add-projects.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Add to GitHub Project -on: - issues: - types: - - milestoned - pull_request: - types: - - milestoned - -jobs: - add-to-project: - runs-on: ubuntu-latest - steps: - - name: Add Issue/PR to GitHub Project - uses: actions/add-to-project@v1.0.2 - with: - project-url: https://github.com/orgs/primefaces/projects/4 - github-token: ${{ secrets.GITHUB_TOKEN }} - content-id: ${{ github.event.issue.node_id || github.event.pull_request.node_id }} From 8c33acc94514f798653457cfd3f4ea83413d124c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Fri, 6 Dec 2024 16:52:27 +0300 Subject: [PATCH 455/484] update changelog --- CHANGELOG.md | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c75ae25500..6289bc9254d 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,47 @@ # Changelog +## [18.0.0](https://github.com/primefaces/primeng/tree/18.0.0) (2024-11-06) +[Full Changelog](https://github.com/primefaces/primeng/compare/18.0.0-rc.2...18.0.0) + +**Fixed bugs:** +- v18-rc.2 Component: ConfirmationDialog [\#16963](https://github.com/primefaces/primeng/issues/16963) +- Component: Accordion import documentation out of date [\#16961](https://github.com/primefaces/primeng/issues/16961) +- Autocomplete [\#16907](https://github.com/primefaces/primeng/issues/16907) +- Table: Cell/Row edit examples not working [\#16891](https://github.com/primefaces/primeng/issues/16891) +- Component: Password input pPassword meter does not update in v18 beta 2 version [\#16632](https://github.com/primefaces/primeng/issues/16632) +- Drawer: deprecated showCloseIcon needed [\#16848](https://github.com/primefaces/primeng/issues/16848) +- 18.0.0-rc.2: Stepper content duplicated when stepper is in Dialog [\#16936](https://github.com/primefaces/primeng/issues/16936) +- Tree: Missing Drag and Drop Indicator [\#16930](https://github.com/primefaces/primeng/issues/16930) +- Component: Tree Template Not Working (V18 RC2) [\#16934](https://github.com/primefaces/primeng/issues/16934) +- Component: pInputText size attribute (18.0.0-rc.1) [\#16761](https://github.com/primefaces/primeng/issues/16761) +- pInputText & pTextarea | rename "size" property to avoid conflict [\#16949](https://github.com/primefaces/primeng/issues/16949) +- Ripple | Ripple effect remains active when disabled [\#16944](https://github.com/primefaces/primeng/issues/16944) +- Component: toggleswitch [\#16900](https://github.com/primefaces/primeng/issues/16900) +- Showcase: Misaligned Country Flags in Components Showcase [\#16925](https://github.com/primefaces/primeng/issues/16925) +- Showcase | save appState [\#16803](https://github.com/primefaces/primeng/issues/16803) +- Docs: Textarea import typo [\#16928](https://github.com/primefaces/primeng/issues/16928) +- Splitter: vertical mode not working (v18-rc.2) [\#16893](https://github.com/primefaces/primeng/issues/16893) +- Splitter: V18-beta - leaves a gap after resizing [\#16526](https://github.com/primefaces/primeng/issues/16526) +- Splitter: V18-beta - Can't set minSizes [\#16527](https://github.com/primefaces/primeng/issues/16527) +- Autocomplete: dropdown arrow and clear icon overlap [\#16846](https://github.com/primefaces/primeng/issues/16846) +- Component: PickList (18.0.0-rc.1) [\#16762](https://github.com/primefaces/primeng/issues/16762) +- Component: Table — misaligned table-like footer [\#16614](https://github.com/primefaces/primeng/issues/16614) +- Table footer ignores table layout [\#16672](https://github.com/primefaces/primeng/issues/16672) +- Component: select, multiselect, autocomplete [\#16658](https://github.com/primefaces/primeng/issues/16658) +- menu: appendTo values other than body not working correctly in v18 [\#16795](https://github.com/primefaces/primeng/issues/16795) +- Multiselect | Issue with displaying the number of selected items [\#16920](https://github.com/primefaces/primeng/issues/16920) +- Component: p-checkbox no longer has the attribute label in version 18 [\#16707](https://github.com/primefaces/primeng/issues/16707) +- Theme variables undefined if component doesn't use a Primeng component in it's template in v18.rc1 [\#16890](https://github.com/primefaces/primeng/issues/16890) +- providePrimeNG: translation not supported [\#16832](https://github.com/primefaces/primeng/issues/16832) +- Table documentation missing lazy load example [\#16745](https://github.com/primefaces/primeng/issues/16745) +- v18-rc.1 Drawer: visible change DOM of menubar [\#16801](https://github.com/primefaces/primeng/issues/16801) +- Stepper: Missing orientation property [\#16897](https://github.com/primefaces/primeng/issues/16897) +- FloatLabel/Select: Issues when select value is string, then float label is over the Value [\#16856](https://github.com/primefaces/primeng/issues/16856) +- Customers table demo filter problem [\#16746](https://github.com/primefaces/primeng/issues/16746) +- p-sortIcon Selector Not Working in PrimeNG Table [\#16902](https://github.com/primefaces/primeng/issues/16902) +- Component: Button primary focus styling broken, missing semi-colon (v18.0.0-rc.1) [\#16774](https://github.com/primefaces/primeng/issues/16774) +- Component: ConfirmDialog [\#16861](https://github.com/primefaces/primeng/issues/16861) +- Showcase (v18): Table of Contents not updating on scroll. [\#16892](https://github.com/primefaces/primeng/issues/16892) + ## [17.18.12](https://github.com/primefaces/primeng/tree/17.18.12) (2024-11-13) [Full Changelog](https://github.com/primefaces/primeng/compare/17.18.11...17.18.12) @@ -15,6 +58,59 @@ - When using stateStorage for the p-table I always get the following error in the console when the component first loads: [\#15043](https://github.com/primefaces/primeng/issues/15043) - p-dropdown: selected item is not changing when typing the first character of the items in the list [\#16462](https://github.com/primefaces/primeng/issues/16462) + +## [18.0.0-rc.2](https://github.com/primefaces/primeng/tree/18.0.0-rc.2) (2024-10-29) +[Full Changelog](https://github.com/primefaces/primeng/compare/18.0.0-rc.1...18.0.0-rc.2) + +**Implemented New Features and Enhancements:** +- Add ImageCompare Component [\#16865](https://github.com/primefaces/primeng/issues/16865) +- RTL Support [\#16793](https://github.com/primefaces/primeng/issues/16793) + +**Fixed bugs:** +- MultiSelect v18: Wrong placeholder color - missing p-placeholder class [\#16479](https://github.com/primefaces/primeng/issues/16479) +- Improve CascadeSelect's functionality [\#16884](https://github.com/primefaces/primeng/issues/16884) +- PanelMenu | Hover is not working on child items. [\#16882](https://github.com/primefaces/primeng/issues/16882) +- Focus state visuals does not apply to invalid form components [\#16855](https://github.com/primefaces/primeng/issues/16855) +- Select (v18): overlap between outline and border with invalid state [\#16577](https://github.com/primefaces/primeng/issues/16577) +- Tree | Tree component throws an error when pressing the Enter key: 'Cannot set properties of undefined.' [\#16879](https://github.com/primefaces/primeng/issues/16879) +- Tree: Arrow Up not working [\#16874](https://github.com/primefaces/primeng/issues/16874) +- ERROR TypeError: this.document.head.prepend is not a function in 18.0.0-rc.1 [\#16875](https://github.com/primefaces/primeng/issues/16875) +- DatePicker: Calling focus on non existent selector breaks overlay [\#16872](https://github.com/primefaces/primeng/issues/16872) +- DatePicker: Icons are wrong in RTL mode [\#16873](https://github.com/primefaces/primeng/issues/16873) +- Fileupload | add chooseButtonProps & uploadButtonProps & cancelButtonProps [\#16869](https://github.com/primefaces/primeng/issues/16869) +- v18 - CSS Layers for example with Tailwind CSS fail when appending styles to header and SSR enabled [\#16595](https://github.com/primefaces/primeng/issues/16595) +- Splitter: Totally broken in v18 [\#16770](https://github.com/primefaces/primeng/issues/16770) +- Component: AutoComplete virtualScroll broken (v18.0.0-rc.1) [\#16822](https://github.com/primefaces/primeng/issues/16822) +- Filter button triggers sort [\#16817](https://github.com/primefaces/primeng/issues/16817) +- Accordion - Ripple | unexpected behavior [\#16804](https://github.com/primefaces/primeng/issues/16804) +- Component: FloatLabel, IftaLabel [\#16601](https://github.com/primefaces/primeng/issues/16601) +- Component: FloatLabel and IftaLabel (v18) documentation lacks "Features" tab [\#16797](https://github.com/primefaces/primeng/issues/16797) +- TreeTable (18.0.0-beta.3) - Disclosure triangles are missing [\#16712](https://github.com/primefaces/primeng/issues/16712) +- DatePicker: "Cannot read properties of null" error when clicking on next/previous month button (18.0.0-beta.3) [\#16590](https://github.com/primefaces/primeng/issues/16590) +- CascadeSelect | Set the default value of autoOptionFocus to false [\#16850](https://github.com/primefaces/primeng/issues/16850) +- MultiSelect | Set the default value of autoOptionFocus to false [\#16847](https://github.com/primefaces/primeng/issues/16847) +- Select | Set the default value of autoOptionFocus to false [\#16845](https://github.com/primefaces/primeng/issues/16845) +- p-picklist Filter stop working in v18 beta-3 [\#16622](https://github.com/primefaces/primeng/issues/16622) +- Password: ExpressionChangedAfterItHasBeenCheckedError on ToggleMask [\#16719](https://github.com/primefaces/primeng/issues/16719) +- Panel Menu - wrong class when using routerLink [\#16683](https://github.com/primefaces/primeng/issues/16683) +- Select v18: Checkmark not working [\#16419](https://github.com/primefaces/primeng/issues/16419) +- Menu component templates not rendered v18.0.0-beta.4 [\#16765](https://github.com/primefaces/primeng/issues/16765) +- p-buttonGroup throws console errors when styleClass is applied [\#16559](https://github.com/primefaces/primeng/issues/16559) +- Data filter and sorting issue on v18 table [\#16360](https://github.com/primefaces/primeng/issues/16360) +- DatePicker Component - Error on Month Switch: "Cannot read properties of null (reading 'focus')" [\#16720](https://github.com/primefaces/primeng/issues/16720) +- Component: ConfirmDialog doesn't render buttons (v18.0.0-rc.1) [\#16780](https://github.com/primefaces/primeng/issues/16780) +- Docs: Setting defined custom preset [\#16647](https://github.com/primefaces/primeng/issues/16647) +- Input group with filled input visuals broken in Material Theme [\#16810](https://github.com/primefaces/primeng/issues/16810) +- Better compatability with CSS libraries like Tailwind, Bootstrap [\#16809](https://github.com/primefaces/primeng/issues/16809) +- Docs: "Icon Only" code example [\#16645](https://github.com/primefaces/primeng/issues/16645) +- Component: Textarea, style is not being applied. [\#16678](https://github.com/primefaces/primeng/issues/16678) +- Missleading typo leads to no theme in documentary [\#16763](https://github.com/primefaces/primeng/issues/16763) +- Tab: disabled input is not disabling tab [\#16768](https://github.com/primefaces/primeng/issues/16768) +- Docs: Theming is outdated (PrimeNg 18.0.0-rc.1) [\#16759](https://github.com/primefaces/primeng/issues/16759) +- Typo code example in /showcase/doc/theming/themedoc.ts [\#16695](https://github.com/primefaces/primeng/issues/16695) +- fix(docs): typo in theming#component [\#16643](https://github.com/primefaces/primeng/issues/16643) + + ## [18.0.0-beta.3](https://github.com/primefaces/primeng/tree/18.0.0-beta.3) (2024-10-16) [Full Changelog](https://github.com/primefaces/primeng/compare/18.0.0-beta.2...18.0.0-beta.3) From b36290ca180e10f91703b99b6733b0f4e3d535b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Fri, 6 Dec 2024 16:53:57 +0300 Subject: [PATCH 456/484] update versions.json --- src/app/showcase/data/versions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/showcase/data/versions.json b/src/app/showcase/data/versions.json index 787dcd40859..63b5ff82f5a 100644 --- a/src/app/showcase/data/versions.json +++ b/src/app/showcase/data/versions.json @@ -5,7 +5,7 @@ "url": "https://primeng.org" }, { - "version": "v18.0.0-beta.3", + "version": "v18.0.0", "name": "v18", "url": "https://v18.primeng.org" }, From 984181f84530a51d0a8f788058433e9909e2d40f Mon Sep 17 00:00:00 2001 From: JeremyHefti <142236298+JeremyHefti@users.noreply.github.com> Date: Fri, 6 Dec 2024 16:38:04 +0100 Subject: [PATCH 457/484] #16607 fixed bug in inputnumber for dead keys (#16965) Co-authored-by: Jeremy Hefti --- src/app/components/inputnumber/inputnumber.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/inputnumber/inputnumber.ts b/src/app/components/inputnumber/inputnumber.ts index e7595eaee4b..9739b677374 100644 --- a/src/app/components/inputnumber/inputnumber.ts +++ b/src/app/components/inputnumber/inputnumber.ts @@ -835,7 +835,7 @@ export class InputNumber implements OnInit, AfterContentInit, OnChanges, Control } this.lastValue = (event.target as HTMLInputElement).value; - if ((event as KeyboardEvent).shiftKey || (event as KeyboardEvent).altKey) { + if ((event as KeyboardEvent).shiftKey || (event as KeyboardEvent).altKey || event.key === "Dead") { this.isSpecialChar = true; return; } From a67565961ee3d23ec78a94bf374fd544c24ddf00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Bo=C5=82towicz?= <64536313+PaterMajkel@users.noreply.github.com> Date: Fri, 6 Dec 2024 16:46:47 +0100 Subject: [PATCH 458/484] #16833 component mutliselect (#16942) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create npm-grunt.yml Do ewentualnej modyfikacji w przyszłości * create an index.html file * Update index.html * Update index.html * removing chips now also emits onclear event * removing previous changes * deleted extra file --------- Co-authored-by: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> --- src/app/components/multiselect/multiselect.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/components/multiselect/multiselect.ts b/src/app/components/multiselect/multiselect.ts index 22f832f8330..9ac76dd51b6 100755 --- a/src/app/components/multiselect/multiselect.ts +++ b/src/app/components/multiselect/multiselect.ts @@ -2149,6 +2149,7 @@ export class MultiSelect implements OnInit, AfterViewInit, AfterContentInit, Aft value: value, itemValue: optionValue }); + this.onClear.emit(); event && event.stopPropagation(); } From 7bfe80fab2a2123b907053d7e6f4ace753af025e Mon Sep 17 00:00:00 2001 From: navedqb <109583873+navedqb@users.noreply.github.com> Date: Fri, 6 Dec 2024 22:59:03 +0530 Subject: [PATCH 459/484] fix incorrect property used in hasOffLabel getter (#16917) --- src/app/components/togglebutton/togglebutton.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/togglebutton/togglebutton.ts b/src/app/components/togglebutton/togglebutton.ts index c8694269380..aa7c8b11d2d 100755 --- a/src/app/components/togglebutton/togglebutton.ts +++ b/src/app/components/togglebutton/togglebutton.ts @@ -210,7 +210,7 @@ export class ToggleButton implements ControlValueAccessor { } get hasOffLabel(): boolean { - return (this.onLabel && this.onLabel.length > 0) as boolean; + return (this.offLabel && this.offLabel.length > 0) as boolean; } } From 67c375636707a24adf386337ad8b328bfb7ffaa4 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Fri, 6 Dec 2024 17:30:15 +0000 Subject: [PATCH 460/484] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2d51c7d2287..5963edaf0cb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ ### Defect Fixes -When submitting a PR, please also **create an issue** documenting the error and [manually link to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-or-branch-to-an-issue-using-the-issue-sidebar) or mention it in the description using #. +When submitting a PR, please also **create an issue** documenting the error and [manually link to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-or-branch-to-an-issue-using-the-issue-sidebar). ### Feature Requests Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes. From 703f397231c0b3764f01b52fa7829f66cb9b62d4 Mon Sep 17 00:00:00 2001 From: pointers-enjoyer <187055050+pointers-enjoyer@users.noreply.github.com> Date: Fri, 6 Dec 2024 18:40:46 +0100 Subject: [PATCH 461/484] fix: incorrect month value in Calendar component (#16894) --- src/app/components/calendar/calendar.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/calendar/calendar.ts b/src/app/components/calendar/calendar.ts index c68f731ab8a..62d2c4274e5 100644 --- a/src/app/components/calendar/calendar.ts +++ b/src/app/components/calendar/calendar.ts @@ -1643,7 +1643,7 @@ export class Calendar implements OnInit, OnDestroy, ControlValueAccessor { } formatDateKey(date: Date): string { - return `${date.getFullYear()}-${date.getMonth()}-${date.getDate()}`; + return `${date.getFullYear()}-${date.getMonth() + 1}-${date.getDate()}`; } setCurrentHourPM(hours: number) { From f03542f55328a3f5b6578b7eff9acfa10b337df9 Mon Sep 17 00:00:00 2001 From: dermartinschmitz <48032221+dermartinschmitz@users.noreply.github.com> Date: Fri, 6 Dec 2024 18:50:18 +0100 Subject: [PATCH 462/484] fix(#16630): ensure aria-describedby is dynamically set and removed for tooltip (#16889) This fix improves accessibility by maintaining proper ARIA relationships for tooltips. - Added `setAriaDescribedBy` to dynamically set `aria-describedby` attribute on the target element when the tooltip is created. - Added `removeAriaDescribedBy` to remove the `aria-describedby` attribute when the tooltip is removed. Co-authored-by: Martin Schmitz --- src/app/components/tooltip/tooltip.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/app/components/tooltip/tooltip.ts b/src/app/components/tooltip/tooltip.ts index db49acf0c5f..8fcda3fb50f 100755 --- a/src/app/components/tooltip/tooltip.ts +++ b/src/app/components/tooltip/tooltip.ts @@ -206,6 +206,18 @@ export class Tooltip implements AfterViewInit, OnDestroy { }); } } + + setAriaDescribedBy() { + const tooltipId = this.getOption('id'); + if (tooltipId && this.active) { + this.renderer.setAttribute(this.el.nativeElement, 'aria-describedby', tooltipId); + } + } + + removeAriaDescribedBy() { + this.renderer.removeAttribute(this.el.nativeElement, 'aria-describedby'); + } + ngOnChanges(simpleChange: SimpleChanges) { if (simpleChange.tooltipPosition) { @@ -423,6 +435,8 @@ export class Tooltip implements AfterViewInit, OnDestroy { this.container.style.pointerEvents = 'unset'; this.bindContainerMouseleaveListener(); } + + this.setAriaDescribedBy(); } bindContainerMouseleaveListener() { @@ -705,6 +719,7 @@ export class Tooltip implements AfterViewInit, OnDestroy { this.unbindScrollListener(); this.unbindContainerMouseleaveListener(); this.clearTimeouts(); + this.removeAriaDescribedBy(); this.container = null; this.scrollHandler = null; } From b7b8e2ac99a36414e9df65a247ec0a8f1c2b7561 Mon Sep 17 00:00:00 2001 From: Federico Piana Date: Fri, 6 Dec 2024 19:08:56 +0100 Subject: [PATCH 463/484] Fix autocomplete updateOn blur on select (#16805) (#16828) --- src/app/components/autocomplete/autocomplete.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/app/components/autocomplete/autocomplete.ts b/src/app/components/autocomplete/autocomplete.ts index 119043a5973..2671f1fd5e6 100755 --- a/src/app/components/autocomplete/autocomplete.ts +++ b/src/app/components/autocomplete/autocomplete.ts @@ -1209,7 +1209,11 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr this.dirty = false; this.focused = false; this.focusedOptionIndex.set(-1); - this.onModelTouched(); + /** triggered only if user can input freely text + * Later on it must set touched also onSelect */ + if(!this.forceSelection){ + this.onModelTouched(); + } this.onBlur.emit(event); } @@ -1446,6 +1450,9 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr this.updateModel(value); } + /** triggers model touched to update FormControl + * value in case updateOn is set to "blur" */ + this.onModelTouched(); this.onSelect.emit({ originalEvent: event, value: option }); isHide && this.hide(true); From 3770faa58bb807a86e3a66cd7e84330924e1cb03 Mon Sep 17 00:00:00 2001 From: Stefan Bildl Date: Fri, 6 Dec 2024 19:10:22 +0100 Subject: [PATCH 464/484] fix: #16825 Editor: reactive forms setValue does not work while editor formControl is in dialog that is not visible (#16826) --- src/app/components/editor/editor.ts | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/src/app/components/editor/editor.ts b/src/app/components/editor/editor.ts index 29bd656ae13..4003bcad0a4 100755 --- a/src/app/components/editor/editor.ts +++ b/src/app/components/editor/editor.ts @@ -174,8 +174,6 @@ export class Editor implements AfterContentInit, ControlValueAccessor { value: Nullable; - delayedCommand: Function | null = null; - _readonly: boolean = false; onModelChange: Function = () => {}; @@ -188,10 +186,6 @@ export class Editor implements AfterContentInit, ControlValueAccessor { headerTemplate: Nullable>; - private get isAttachedQuillEditorToDOM(): boolean | undefined { - return this.quillElements?.editorElement?.isConnected; - } - private quillElements!: { editorElement: HTMLElement; toolbarElement: HTMLElement }; constructor( @@ -222,25 +216,9 @@ export class Editor implements AfterContentInit, ControlValueAccessor { if (this.quill) { if (value) { - const command = (): void => { - this.quill.setContents(this.quill.clipboard.convert(this.dynamicQuill.version.startsWith('2') ? { html: this.value } : this.value)); - }; - - if (this.isAttachedQuillEditorToDOM) { - command(); - } else { - this.delayedCommand = command; - } + this.quill.setContents(this.quill.clipboard.convert(this.dynamicQuill.version.startsWith('2') ? { html: this.value } : this.value)); } else { - const command = (): void => { - this.quill.setText(''); - }; - - if (this.isAttachedQuillEditorToDOM) { - command(); - } else { - this.delayedCommand = command; - } + this.quill.setText(''); } } } From eea77239e37a4b602286a73380b0b07aa36908fe Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Fri, 6 Dec 2024 19:12:23 +0100 Subject: [PATCH 465/484] Fix:16755 - dropdown emit event (#16816) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create npm-grunt.yml Do ewentualnej modyfikacji w przyszłości * create an index.html file * Update index.html * Update index.html * Fix: Add ripple effect to AccordionTab header * Restore index.html * Fix: Dropdown respects emitEvent=false when setting value (#16755) * Drop uneccessary changes --------- Co-authored-by: joaanyk --- src/app/components/dropdown/dropdown.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/components/dropdown/dropdown.ts b/src/app/components/dropdown/dropdown.ts index deee2ccda73..7165882f26c 100755 --- a/src/app/components/dropdown/dropdown.ts +++ b/src/app/components/dropdown/dropdown.ts @@ -1212,13 +1212,15 @@ export class Dropdown implements OnInit, AfterViewInit, AfterContentInit, AfterV this.selectedOptionUpdated = true; } - writeValue(value: any): void { + writeValue(value: any, emitEvent: boolean = true): void { if (this.filter) { this.resetFilter(); } this.value = value; - this.allowModelChange() && this.onModelChange(value); + if (emitEvent && this.allowModelChange()) { + this.onModelChange(value); + } this.modelValue.set(this.value); this.updateEditableLabel(); this.cd.markForCheck(); From eff80f88fe6726d473d747d3179c201a014c46b2 Mon Sep 17 00:00:00 2001 From: Mark Paniterce <73551111+mark7p@users.noreply.github.com> Date: Sat, 7 Dec 2024 06:13:30 +0800 Subject: [PATCH 466/484] rearranged proper resize sequence that causes wrong height update (#16808) --- src/app/components/scroller/scroller.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/app/components/scroller/scroller.ts b/src/app/components/scroller/scroller.ts index 7241896072d..37837215763 100644 --- a/src/app/components/scroller/scroller.ts +++ b/src/app/components/scroller/scroller.ts @@ -834,6 +834,11 @@ export class Scroller implements OnInit, AfterContentInit, AfterViewChecked, OnD this.contentEl.style.minHeight = this.contentEl.style.minWidth = ''; this.contentEl.style.position = ''; (this.elementViewChild).nativeElement.style.contain = ''; + + this.defaultWidth = width; + this.defaultHeight = height; + this.defaultContentWidth = contentWidth; + this.defaultContentHeight = contentHeight; } }); } @@ -1059,12 +1064,6 @@ export class Scroller implements OnInit, AfterContentInit, AfterViewChecked, OnD reinit && this.zone.run(() => { this.d_numToleratedItems = this._numToleratedItems; - this.defaultWidth = width; - this.defaultHeight = height; - if (this.contentEl) { - this.defaultContentWidth = DomHandler.getWidth(this.contentEl); - this.defaultContentHeight = DomHandler.getHeight(this.contentEl); - } this.init(); this.calculateAutoSize(); From b51a27f3144919f68ea5627d97f5c18043f7fef5 Mon Sep 17 00:00:00 2001 From: Mark Paniterce <73551111+mark7p@users.noreply.github.com> Date: Sat, 7 Dec 2024 06:18:51 +0800 Subject: [PATCH 467/484] Fix: PanelMenu(15403) - Submenu displays angledownicon when submenu is collapsed (#16790) * fixed expanded properties overwriten as undefined onChanges * fixed formating --- src/app/components/panelmenu/panelmenu.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/app/components/panelmenu/panelmenu.ts b/src/app/components/panelmenu/panelmenu.ts index 0404e71aafc..c7fc514ae88 100644 --- a/src/app/components/panelmenu/panelmenu.ts +++ b/src/app/components/panelmenu/panelmenu.ts @@ -364,7 +364,17 @@ export class PanelMenuList implements OnChanges { constructor(private el: ElementRef) {} ngOnChanges(changes: SimpleChanges) { - this.processedItems.set(this.createProcessedItems(changes?.items?.currentValue || this.items || [])); + const hasItems = !!changes?.items?.currentValue; + + if (hasItems) { + this.processedItems.set(this.createProcessedItems(changes?.items?.currentValue || this.items || [])); + return; + } + + // Update and keep `expanded` property from previous data + else { + this.processedItems.update((prev) => prev.map((i) => ({ ...i, expanded: i.expanded }))); + } } getItemProp(processedItem, name) { From 971ce5fd77206c4e2dd807b8c146e8b33d5b3df7 Mon Sep 17 00:00:00 2001 From: joaanyk <51395540+joaanyk@users.noreply.github.com> Date: Fri, 6 Dec 2024 23:20:29 +0100 Subject: [PATCH 468/484] Fix #16744: Prevent click event from triggering on disabled p-toggleButton (#16787) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create npm-grunt.yml Do ewentualnej modyfikacji w przyszłości * create an index.html file * Update index.html * Update index.html * Fix autoOptionFocus to focus the first option in MultiSelect filter * Remove unnecessary files: npm-grunt.yml and index.html * Remove unnecessary blank spaces * Fix: Prevent toggle action and event emission for disabled state (#16744) * Revert changes to multiselect.ts * restored useful changes * restored useful changess * restored useful changess --------- Co-authored-by: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Co-authored-by: Mateusz Adamczyk --- .../components/togglebutton/togglebutton.ts | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/app/components/togglebutton/togglebutton.ts b/src/app/components/togglebutton/togglebutton.ts index aa7c8b11d2d..44952652f23 100755 --- a/src/app/components/togglebutton/togglebutton.ts +++ b/src/app/components/togglebutton/togglebutton.ts @@ -157,17 +157,19 @@ export class ToggleButton implements ControlValueAccessor { } toggle(event: Event) { - if (!this.disabled) { - this.checked = !this.checked; - this.onModelChange(this.checked); - this.onModelTouched(); - this.onChange.emit({ - originalEvent: event, - checked: this.checked - }); - - this.cd.markForCheck(); + if (this.disabled) { + event.preventDefault(); + event.stopPropagation(); + return; } + this.checked = !this.checked; + this.onModelChange(this.checked); + this.onModelTouched(); + this.onChange.emit({ + originalEvent: event, + checked: this.checked + }); + this.cd.markForCheck(); } onKeyDown(event: KeyboardEvent) { From 70376cdd7642c2404b1e8a77989f808a27e46ab9 Mon Sep 17 00:00:00 2001 From: Akshay Antony <123446355+akshayaqburst@users.noreply.github.com> Date: Sat, 7 Dec 2024 04:10:57 +0530 Subject: [PATCH 469/484] fix: #16684, MultiSelect: Unable to select remove icon of chips through keyboard (#16685) Co-authored-by: ANTONA09 --- src/app/components/multiselect/multiselect.ts | 32 ++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/src/app/components/multiselect/multiselect.ts b/src/app/components/multiselect/multiselect.ts index 9ac76dd51b6..b8dba14bc25 100755 --- a/src/app/components/multiselect/multiselect.ts +++ b/src/app/components/multiselect/multiselect.ts @@ -199,10 +199,20 @@ export class MultiSelectItem { [ngClass]="{ 'p-disabled': isOptionDisabled(item) }" [styleClass]="'p-multiselect-token-icon'" (click)="removeOption(item, event)" + (keydown)="onremoveTokenIconKeyDown($event, item)" + [attr.tabindex]="0" [attr.data-pc-section]="'clearicon'" [attr.aria-hidden]="true" /> - + @@ -1916,6 +1926,26 @@ export class MultiSelect implements OnInit, AfterViewInit, AfterContentInit, Aft } } + onremoveTokenIconKeyDown(event, item) { + if (this.disabled) { + event.preventDefault(); + + return; + } + + switch (event.code) { + case 'Space': + case 'Enter': + case 'NumpadEnter': + this.removeOption(item, event); + break; + default: + break; + } + event.preventDefault(); + event.stopPropagation(); + } + onFilterBlur(event) { this.focusedOptionIndex.set(-1); } From 52c59ea262f9e4c154a1a45b03120fafded09276 Mon Sep 17 00:00:00 2001 From: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Date: Fri, 6 Dec 2024 23:42:28 +0100 Subject: [PATCH 470/484] Issue 16653 tab fix (#16655) * Fix TAB navigation in InputOtp component (issue #16653) * adapt to the rest * revert previous changes * Fix code formatting issues --------- Co-authored-by: Mateusz Adamczyk Co-authored-by: Mateusz Adamczyk --- src/app/components/inputotp/inputotp.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/app/components/inputotp/inputotp.ts b/src/app/components/inputotp/inputotp.ts index 5d76f5baed8..687ab7b9ea1 100644 --- a/src/app/components/inputotp/inputotp.ts +++ b/src/app/components/inputotp/inputotp.ts @@ -311,6 +311,9 @@ export class InputOtp implements AfterContentInit { break; + case 'Tab': + break; + default: if ((this.integerOnly && !((event.code.startsWith('Digit') || event.code.startsWith('Numpad')) && Number(event.key) >= 0 && Number(event.key) <= 9)) || (this.tokens.join('').length >= this.length && event.code !== 'Delete')) { event.preventDefault(); From 807fa641b26113db1af48fc5fac41a892aea7fe9 Mon Sep 17 00:00:00 2001 From: Akshay Antony <123446355+akshayaqburst@users.noreply.github.com> Date: Sat, 7 Dec 2024 04:24:53 +0530 Subject: [PATCH 471/484] fix: #16555, Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. (#16556) Co-authored-by: ANTONA09 --- src/app/components/password/password.ts | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/app/components/password/password.ts b/src/app/components/password/password.ts index 6582e19af40..0caec07cced 100644 --- a/src/app/components/password/password.ts +++ b/src/app/components/password/password.ts @@ -379,13 +379,13 @@ export const Password_VALUE_ACCESSOR: any = { - + - + @@ -732,6 +732,17 @@ export class Password implements AfterContentInit, OnInit { this.onFocus.emit(event); } + onEyeIconPress(event: KeyboardEvent) { + switch (event.code) { + case 'Enter': + this.onMaskToggle(); + event.preventDefault(); + break; + default: + break; + } + } + onInputBlur(event: Event) { this.focused = false; if (this.feedback) { From bc0c9ef9b4a8f80a7abb016d8fc67ab6849c1cae Mon Sep 17 00:00:00 2001 From: petrf22 Date: Sat, 7 Dec 2024 00:02:51 +0100 Subject: [PATCH 472/484] Accept the locale for the file size of the format (#16383) Co-authored-by: Petr Franta --- src/app/components/fileupload/fileupload.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/app/components/fileupload/fileupload.ts b/src/app/components/fileupload/fileupload.ts index b65b32348bf..bf2295efdc9 100755 --- a/src/app/components/fileupload/fileupload.ts +++ b/src/app/components/fileupload/fileupload.ts @@ -11,6 +11,7 @@ import { EventEmitter, Inject, Input, + LOCALE_ID, NgModule, NgZone, OnDestroy, @@ -527,9 +528,12 @@ export class FileUpload implements AfterViewInit, AfterContentInit, OnInit, OnDe private fileUploadSubcription: Subscription; + private formatter; + constructor( @Inject(DOCUMENT) private document: Document, @Inject(PLATFORM_ID) private platformId: any, + @Inject(LOCALE_ID) private locale: string, private renderer: Renderer2, private el: ElementRef, public sanitizer: DomSanitizer, @@ -537,7 +541,9 @@ export class FileUpload implements AfterViewInit, AfterContentInit, OnInit, OnDe private http: HttpClient, public cd: ChangeDetectorRef, public config: PrimeNGConfig - ) {} + ) { + this.formatter = new Intl.NumberFormat(this.locale, { maximumFractionDigits: 3 }) + } ngAfterContentInit() { this.templates?.forEach((item) => { @@ -952,7 +958,6 @@ export class FileUpload implements AfterViewInit, AfterContentInit, OnInit, OnDe formatSize(bytes: number) { const k = 1024; - const dm = 3; const sizes = this.getTranslation(TranslationKeys.FILE_SIZE_TYPES); if (bytes === 0) { @@ -960,7 +965,7 @@ export class FileUpload implements AfterViewInit, AfterContentInit, OnInit, OnDe } const i = Math.floor(Math.log(bytes) / Math.log(k)); - const formattedSize = (bytes / Math.pow(k, i)).toFixed(dm); + const formattedSize = this.formatter.format(bytes / Math.pow(k, i)); return `${formattedSize} ${sizes[i]}`; } From 846c5d9851485a146587a453dd283f552a321367 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Fri, 6 Dec 2024 23:40:31 +0000 Subject: [PATCH 473/484] Format fixes --- src/app/components/autocomplete/autocomplete.ts | 2 +- src/app/components/fileupload/fileupload.ts | 2 +- src/app/components/inputnumber/inputnumber.ts | 2 +- src/app/components/tooltip/tooltip.ts | 3 +-- src/app/showcase/layout/templates/templatelicense.ts | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/app/components/autocomplete/autocomplete.ts b/src/app/components/autocomplete/autocomplete.ts index 2671f1fd5e6..61b751ef052 100755 --- a/src/app/components/autocomplete/autocomplete.ts +++ b/src/app/components/autocomplete/autocomplete.ts @@ -1211,7 +1211,7 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr this.focusedOptionIndex.set(-1); /** triggered only if user can input freely text * Later on it must set touched also onSelect */ - if(!this.forceSelection){ + if (!this.forceSelection) { this.onModelTouched(); } this.onBlur.emit(event); diff --git a/src/app/components/fileupload/fileupload.ts b/src/app/components/fileupload/fileupload.ts index bf2295efdc9..7539a2d5574 100755 --- a/src/app/components/fileupload/fileupload.ts +++ b/src/app/components/fileupload/fileupload.ts @@ -542,7 +542,7 @@ export class FileUpload implements AfterViewInit, AfterContentInit, OnInit, OnDe public cd: ChangeDetectorRef, public config: PrimeNGConfig ) { - this.formatter = new Intl.NumberFormat(this.locale, { maximumFractionDigits: 3 }) + this.formatter = new Intl.NumberFormat(this.locale, { maximumFractionDigits: 3 }); } ngAfterContentInit() { diff --git a/src/app/components/inputnumber/inputnumber.ts b/src/app/components/inputnumber/inputnumber.ts index 9739b677374..1b7ed7d44be 100644 --- a/src/app/components/inputnumber/inputnumber.ts +++ b/src/app/components/inputnumber/inputnumber.ts @@ -835,7 +835,7 @@ export class InputNumber implements OnInit, AfterContentInit, OnChanges, Control } this.lastValue = (event.target as HTMLInputElement).value; - if ((event as KeyboardEvent).shiftKey || (event as KeyboardEvent).altKey || event.key === "Dead") { + if ((event as KeyboardEvent).shiftKey || (event as KeyboardEvent).altKey || event.key === 'Dead') { this.isSpecialChar = true; return; } diff --git a/src/app/components/tooltip/tooltip.ts b/src/app/components/tooltip/tooltip.ts index 8fcda3fb50f..b0cf0c1d983 100755 --- a/src/app/components/tooltip/tooltip.ts +++ b/src/app/components/tooltip/tooltip.ts @@ -206,7 +206,7 @@ export class Tooltip implements AfterViewInit, OnDestroy { }); } } - + setAriaDescribedBy() { const tooltipId = this.getOption('id'); if (tooltipId && this.active) { @@ -218,7 +218,6 @@ export class Tooltip implements AfterViewInit, OnDestroy { this.renderer.removeAttribute(this.el.nativeElement, 'aria-describedby'); } - ngOnChanges(simpleChange: SimpleChanges) { if (simpleChange.tooltipPosition) { this.setOption({ tooltipPosition: simpleChange.tooltipPosition.currentValue }); diff --git a/src/app/showcase/layout/templates/templatelicense.ts b/src/app/showcase/layout/templates/templatelicense.ts index 00b2621f71d..27f9644eeb9 100644 --- a/src/app/showcase/layout/templates/templatelicense.ts +++ b/src/app/showcase/layout/templates/templatelicense.ts @@ -12,7 +12,7 @@ import { SharedModule } from 'primeng/api';
      {{ licenseData?.title }}
      -

      {{ licenseData?.price }}

      +

      {{ licenseData?.price }}

      {{ licenseData?.discount }}

      From 5f5f28c833f630733b3ea7c0ddf53e34b761b869 Mon Sep 17 00:00:00 2001 From: Oleksandr Date: Sat, 7 Dec 2024 01:57:18 +0200 Subject: [PATCH 474/484] Fix #16634 - reset accordion ActiveTab public method (#16838) * reset accordion ActiveTab * revert package-lock.json changes --- src/app/components/accordion/accordion.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/app/components/accordion/accordion.ts b/src/app/components/accordion/accordion.ts index f4759c232f5..46c58a727f1 100755 --- a/src/app/components/accordion/accordion.ts +++ b/src/app/components/accordion/accordion.ts @@ -568,6 +568,15 @@ export class Accordion implements BlockableUI, AfterContentInit, OnDestroy { event.preventDefault(); } + public resetActiveTab() { + this.tabs?.forEach((tab: AccordionTab) => { + tab.selected = false; + tab.changeDetector.markForCheck(); + }); + + this.activeIndex = null; + } + ngAfterContentInit() { this.initTabs(); From cee4ae09dd344673ad7aa8cbc8888f84b65249ee Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Sat, 7 Dec 2024 14:17:50 +0000 Subject: [PATCH 475/484] Create vercel.json --- vercel.json | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 vercel.json diff --git a/vercel.json b/vercel.json new file mode 100644 index 00000000000..6a63aa2e632 --- /dev/null +++ b/vercel.json @@ -0,0 +1,9 @@ +{ + "version": 2, + "git": { + "deploymentEnabled": { + "master": false, + "v18": false + } + } +} From 2dc37611d2408fb2022a01d3e7a852f391716245 Mon Sep 17 00:00:00 2001 From: Jose Manuel Garcia Maestre Date: Mon, 9 Dec 2024 10:53:26 +0100 Subject: [PATCH 476/484] Fix #14529 - Google Gboard and inputmask control (#16232) * Fix #14529 - Google Gboard and inputmask control * Refactor --- src/app/components/inputmask/inputmask.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/app/components/inputmask/inputmask.ts b/src/app/components/inputmask/inputmask.ts index 6d2bc5956c2..786fa2c2cb5 100755 --- a/src/app/components/inputmask/inputmask.ts +++ b/src/app/components/inputmask/inputmask.ts @@ -556,13 +556,21 @@ export class InputMask implements OnInit, ControlValueAccessor { if (this.oldVal && this.oldVal.length && this.oldVal.length > curVal.length) { // a deletion or backspace happened this.checkVal(true); - while (pos.begin > 0 && !this.tests[pos.begin - 1]) pos.begin--; + while (pos.begin > 0 && !this.tests[pos.begin]) pos.begin--; if (pos.begin === 0) { while (pos.begin < (this.firstNonMaskPos as number) && !this.tests[pos.begin]) pos.begin++; } setTimeout(() => { - this.caret(pos.begin, pos.begin); + const begin = pos.begin; + const end = this.seekNext(begin) + this.caret(begin, begin); + this.clearBuffer(begin, end-1); + if (this.keepBuffer) { + this.shiftL(begin, end - 2); + } else { + this.shiftL(begin, end - 1); + } this.updateModel(e); if (this.isCompleted()) { this.onComplete.emit(); @@ -570,7 +578,7 @@ export class InputMask implements OnInit, ControlValueAccessor { }, 0); } else { this.checkVal(true); - while (pos.begin < (this.len as number) && !this.tests[pos.begin]) pos.begin++; + while (pos.begin < (this.len as number) && !this.tests[pos.begin - 1]) pos.begin++; setTimeout(() => { this.caret(pos.begin, pos.begin); From 5f8304fbc3e275734ea7f935ea5c3d74ac09b5e3 Mon Sep 17 00:00:00 2001 From: navedqb <109583873+navedqb@users.noreply.github.com> Date: Mon, 9 Dec 2024 15:25:02 +0530 Subject: [PATCH 477/484] fix: move all columns with CTRL+A in picklist (#16465) --- src/app/components/picklist/picklist.ts | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/app/components/picklist/picklist.ts b/src/app/components/picklist/picklist.ts index 1646796d0a5..464e17a3201 100755 --- a/src/app/components/picklist/picklist.ts +++ b/src/app/components/picklist/picklist.ts @@ -1130,11 +1130,14 @@ export class PickList implements AfterViewChecked, AfterContentInit { moveRight() { if (this.selectedItemsSource && this.selectedItemsSource.length) { - for (let i = 0; i < this.selectedItemsSource.length; i++) { - let selectedItem = this.selectedItemsSource[i]; + const selectedItemsCopy = [...this.selectedItemsSource]; + for (let i = 0; i < selectedItemsCopy.length; i++) { + let selectedItem = selectedItemsCopy[i]; if (ObjectUtils.findIndexInList(selectedItem, this.target) == -1) { - this.target?.push(this.source?.splice(ObjectUtils.findIndexInList(selectedItem, this.source), 1)[0]); - + let indexInSource = ObjectUtils.findIndexInList(selectedItem, this.source); + if (indexInSource !== -1) { + this.target?.push(this.source?.splice(indexInSource, 1)[0]); + } if (this.visibleOptionsSource?.includes(selectedItem)) { this.visibleOptionsSource.splice(ObjectUtils.findIndexInList(selectedItem, this.visibleOptionsSource), 1); } @@ -1190,11 +1193,14 @@ export class PickList implements AfterViewChecked, AfterContentInit { moveLeft() { if (this.selectedItemsTarget && this.selectedItemsTarget.length) { - for (let i = 0; i < this.selectedItemsTarget.length; i++) { - let selectedItem = this.selectedItemsTarget[i]; + const selectedItemsCopy = [...this.selectedItemsTarget]; + for (let i = 0; i < selectedItemsCopy.length; i++) { + let selectedItem = selectedItemsCopy[i]; if (ObjectUtils.findIndexInList(selectedItem, this.source) == -1) { - this.source?.push(this.target?.splice(ObjectUtils.findIndexInList(selectedItem, this.target), 1)[0]); - + let indexInTarget = ObjectUtils.findIndexInList(selectedItem, this.target); + if (indexInTarget !== -1) { + this.source?.push(this.target?.splice(indexInTarget, 1)[0]); + } if (this.visibleOptionsTarget?.includes(selectedItem)) { this.visibleOptionsTarget.splice(ObjectUtils.findIndexInList(selectedItem, this.visibleOptionsTarget), 1)[0]; } From 01c332f4dae34932c6c10e6695d189551a6d337b Mon Sep 17 00:00:00 2001 From: Rahul Kumar Patro Date: Mon, 9 Dec 2024 15:28:27 +0530 Subject: [PATCH 478/484] fixed issue #16313 (p-tabview closing active first tab opens not the next tab) (#16531) * fixed issue #16313 * code formated --- src/app/components/tabview/tabview.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/tabview/tabview.ts b/src/app/components/tabview/tabview.ts index 25969ee36c7..2558ca32a31 100755 --- a/src/app/components/tabview/tabview.ts +++ b/src/app/components/tabview/tabview.ts @@ -763,7 +763,7 @@ export class TabView implements AfterContentInit, AfterViewChecked, OnDestroy, B tab.selected = false; for (let i = 0; i < this.tabs.length; i++) { let tabPanel = this.tabs[i]; - if (!tabPanel.closed && !tab.disabled) { + if (!tabPanel.closed && !tab.disabled && tabPanel != tab) { tabPanel.selected = true; break; } From fbfb6db933b018c5ea2834adde3807e17a6298c9 Mon Sep 17 00:00:00 2001 From: mperezd Date: Mon, 9 Dec 2024 11:01:50 +0100 Subject: [PATCH 479/484] Fix variable in getOptionValue in multiselect (#16652) Co-authored-by: mperez --- src/app/components/multiselect/multiselect.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/components/multiselect/multiselect.ts b/src/app/components/multiselect/multiselect.ts index b8dba14bc25..61854fef919 100755 --- a/src/app/components/multiselect/multiselect.ts +++ b/src/app/components/multiselect/multiselect.ts @@ -1557,7 +1557,7 @@ export class MultiSelect implements OnInit, AfterViewInit, AfterContentInit, Aft } getOptionValue(option: any) { - return this.optionValue ? ObjectUtils.resolveFieldData(option, this.optionValue) : !this.optionLabel && option && option.value !== undefined ? option.value : option; + return this.optionValue ? ObjectUtils.resolveFieldData(option, this.optionValue) : !this.optionValue && option && option.value !== undefined ? option.value : option; } getOptionGroupLabel(optionGroup: any) { From 9df2f0b5ae62d2c300d7777aa1e5d5dc64d5a1c7 Mon Sep 17 00:00:00 2001 From: joaanyk <51395540+joaanyk@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:28:28 +0100 Subject: [PATCH 480/484] #16957 Fix: Dynamic style updates not applied in p-avatar component #16957 (#16978) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create npm-grunt.yml Do ewentualnej modyfikacji w przyszłości * create an index.html file * Update index.html * Update index.html * Fix: Improve dynamic styling for avatar component * Remove unnecessary files * Remove comment --------- Co-authored-by: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Co-authored-by: mateuszstudentzero <71056@student.pb.edu.pl> --- src/app/components/avatar/avatar.ts | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/app/components/avatar/avatar.ts b/src/app/components/avatar/avatar.ts index a88c95f31a8..3aff898e23a 100755 --- a/src/app/components/avatar/avatar.ts +++ b/src/app/components/avatar/avatar.ts @@ -1,5 +1,6 @@ import { CommonModule } from '@angular/common'; -import { ChangeDetectionStrategy, Component, EventEmitter, Input, NgModule, Output, ViewEncapsulation } from '@angular/core'; +import { ChangeDetectionStrategy, Component, EventEmitter, Input, NgModule, Output, ViewEncapsulation, SimpleChanges, OnChanges } from '@angular/core'; + /** * Avatar represents people using icons, labels and images. * @group Components @@ -7,7 +8,7 @@ import { ChangeDetectionStrategy, Component, EventEmitter, Input, NgModule, Outp @Component({ selector: 'p-avatar', template: ` -
      +
      {{ label }} @@ -21,7 +22,7 @@ import { ChangeDetectionStrategy, Component, EventEmitter, Input, NgModule, Outp class: 'p-element' } }) -export class Avatar { +export class Avatar implements OnChanges { /** * Defines the text to display. * @group Props @@ -74,6 +75,11 @@ export class Avatar { */ @Output() onImageError: EventEmitter = new EventEmitter(); + /** + * Holds the current style of the component to allow dynamic updates. + */ + currentStyle: { [klass: string]: any } | null | undefined = {}; + containerClass() { return { 'p-avatar p-component': true, @@ -84,6 +90,15 @@ export class Avatar { }; } + /** + * Lifecycle hook to detect changes in inputs. + */ + ngOnChanges(changes: SimpleChanges): void { + if (changes['style']) { + this.currentStyle = { ...changes['style'].currentValue }; + } + } + imageError(event: Event) { this.onImageError.emit(event); } From 5ce92d20cfea29a774cd41d008364c2a9bb38996 Mon Sep 17 00:00:00 2001 From: joaanyk <51395540+joaanyk@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:29:40 +0100 Subject: [PATCH 481/484] Fix: Ensure p-scroller updates height after clearing filters (#16954) (#16979) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create npm-grunt.yml Do ewentualnej modyfikacji w przyszłości * create an index.html file * Update index.html * Update index.html * Fix: Improve dynamic styling for avatar component * Remove unnecessary files * Fix dropdown virtual scroll filter bug * Restore changes for previous issue * Restore changes for previous issu --------- Co-authored-by: Mateusz Adamczyk <163399256+mateuszstudentzero@users.noreply.github.com> Co-authored-by: mateuszstudentzero <71056@student.pb.edu.pl> --- src/app/components/scroller/scroller.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/app/components/scroller/scroller.ts b/src/app/components/scroller/scroller.ts index 37837215763..602939b3ed1 100644 --- a/src/app/components/scroller/scroller.ts +++ b/src/app/components/scroller/scroller.ts @@ -554,6 +554,12 @@ export class Scroller implements OnInit, AfterContentInit, AfterViewChecked, OnD } } + if (simpleChanges.items) { + this.setSpacerSize(); + this.setSize(); + this.cd.detectChanges(); + } + if (this.initialized) { const isChanged = !isLoadingChanged && (simpleChanges.items?.previousValue?.length !== simpleChanges.items?.currentValue?.length || simpleChanges.itemSize || simpleChanges.scrollHeight || simpleChanges.scrollWidth); From 83255159c7e86b8d074508c9b2f08572a9dcbf17 Mon Sep 17 00:00:00 2001 From: Daniel Oberlechner Date: Mon, 9 Dec 2024 11:30:25 +0100 Subject: [PATCH 482/484] Fix linear stepper stackblitz example not working due to misspelling (#16980) --- src/app/showcase/doc/stepper/lineardoc.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/showcase/doc/stepper/lineardoc.ts b/src/app/showcase/doc/stepper/lineardoc.ts index 7e8c89afb30..554a01d3c87 100644 --- a/src/app/showcase/doc/stepper/lineardoc.ts +++ b/src/app/showcase/doc/stepper/lineardoc.ts @@ -131,8 +131,8 @@ import { StepperModule } from 'primeng/stepper'; import { ButtonModule } from 'primeng/button'; @Component({ - selector: 'stepper-linear-demo-demo', - templateUrl: './stepper-linear-demo-demo.html', + selector: 'stepper-linear-demo', + templateUrl: './stepper-linear-demo.html', standalone: true, imports: [StepperModule, ButtonModule] }) From 75100dac3b3550720a2208243d87a529f2168535 Mon Sep 17 00:00:00 2001 From: Mert Sincan Date: Mon, 9 Dec 2024 11:05:39 +0000 Subject: [PATCH 483/484] Format fixes --- src/app/components/inputmask/inputmask.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/components/inputmask/inputmask.ts b/src/app/components/inputmask/inputmask.ts index 786fa2c2cb5..02fe40d2509 100755 --- a/src/app/components/inputmask/inputmask.ts +++ b/src/app/components/inputmask/inputmask.ts @@ -563,9 +563,9 @@ export class InputMask implements OnInit, ControlValueAccessor { setTimeout(() => { const begin = pos.begin; - const end = this.seekNext(begin) + const end = this.seekNext(begin); this.caret(begin, begin); - this.clearBuffer(begin, end-1); + this.clearBuffer(begin, end - 1); if (this.keepBuffer) { this.shiftL(begin, end - 2); } else { From 2a4ff1dd8989e621d6de512b62ae268b9ebe973d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20=C3=87etin?= <92744169+mehmetcetin01140@users.noreply.github.com> Date: Mon, 9 Dec 2024 14:23:16 +0300 Subject: [PATCH 484/484] update changelog --- CHANGELOG.md | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6289bc9254d..d5b180356aa 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,60 @@ # Changelog +## [17.18.13](https://github.com/primefaces/primeng/tree/17.18.13) (2024-11-09) + +[Full Changelog](https://github.com/primefaces/primeng/compare/17.18.12...17.18.13) + +**Fixed bugs:** +- stepper linear - stackblitz not working because of wrong file name [\#16967](https://github.com/primefaces/primeng/issues/16967) +- Component: Dropdown virtualScroll filter bug [\#16954](https://github.com/primefaces/primeng/issues/16954) +- Component: Avatar [\#16957](https://github.com/primefaces/primeng/issues/16957) +- Multiselect: When opntionName is not set, getting value in template is failing [\#16651](https://github.com/primefaces/primeng/issues/16651) +- p-tabview closing active first tab opens not the next tab [\#16313](https://github.com/primefaces/primeng/issues/16313) +- Picklist: CTRL+A Does Not Move All Columns When Using Move Icon [\#16260](https://github.com/primefaces/primeng/issues/16260) +- Google Gboard and inputmask control [\#14529](https://github.com/primefaces/primeng/issues/14529) +- Component: Accordion do not reset selected active Tab on new dynamic tab data [\#16634](https://github.com/primefaces/primeng/issues/16634) +- FileUpload: Format file size to accept locale in error message [\#16382](https://github.com/primefaces/primeng/issues/16382) +- Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. [\#16555](https://github.com/primefaces/primeng/issues/16555) +- Component: Otp Input Component does not focus next element when TAB is pressed in last input [\#16653](https://github.com/primefaces/primeng/issues/16653) +- MultiSelect: Unable to select remove icon of chips through keyboard [\#16684](https://github.com/primefaces/primeng/issues/16684) +- p-toggleButton trigger "click" event handler when disabled. [\#16744](https://github.com/primefaces/primeng/issues/16744) +- PanelMenu nested subitems no longer get the expanded prop [\#15403](https://github.com/primefaces/primeng/issues/15403) +- Component: AutoComplete with virtual scroll [\#16727](https://github.com/primefaces/primeng/issues/16727) +- Component: MultiSelect with virtual scroll [\#16708](https://github.com/primefaces/primeng/issues/16708) +- Dropdown: does not respect emitEvent false [\#16755](https://github.com/primefaces/primeng/issues/16755) +- Editor: reactive forms setValue does not work while editor formControl is in dialog that is not visible [\#16825](https://github.com/primefaces/primeng/issues/16825) +- Component: Autocomplete with updateOn blur [\#16805](https://github.com/primefaces/primeng/issues/16805) +- Tooltip: aria-describedBy not applied to target [\#16630](https://github.com/primefaces/primeng/issues/16630) +- Component: Calendar [\#16686](https://github.com/primefaces/primeng/issues/16686) +- ToggleButton: Incorrect Property Used in hasOffLabel Getter [\#16916](https://github.com/primefaces/primeng/issues/16916) +- Component: Mutliselect [\#16833](https://github.com/primefaces/primeng/issues/16833) +- InputNumber: Cannot delete character with backspace after inserting Up Arrowhead ^ [\#16607](https://github.com/primefaces/primeng/issues/16607) +- Component: Scroll behaiviour is broken in Scroller [\#16564](https://github.com/primefaces/primeng/issues/16564) +- Component: Table Virtual Scroll does not correctly work with Row Expansion [\#16438](https://github.com/primefaces/primeng/issues/16438) +- PanelMenu: Submenu's not using animations [\#15124](https://github.com/primefaces/primeng/issues/15124) +- Component: PanelMenu: Submenu displays angledownicon when submenu is collapsed [\#16781](https://github.com/primefaces/primeng/issues/16781) +- Component: InputOtp - pasting a too long string doesn't work correctly [\#16777](https://github.com/primefaces/primeng/issues/16777) +- Scrollbar offsets at the initialization of the scroll panel [\#16757](https://github.com/primefaces/primeng/issues/16757) +- Table: Column Resize broken with sortable columns [\#16734](https://github.com/primefaces/primeng/issues/16734) +- Enhancement to Chip Component: Expose secondary click (contextmenu) on a chip [\#16769](https://github.com/primefaces/primeng/issues/16769) +- Distinguish between a drop on the nodes and a drop between the nodes [\#16170](https://github.com/primefaces/primeng/issues/16170) +- p-tree drag and drop breaks with virtualScroll [\#16296](https://github.com/primefaces/primeng/issues/16296) +- Dropdown: Floating placeholder overlapping when value is null or undefined. [\#16411](https://github.com/primefaces/primeng/issues/16411) +- Galleria: Next & Previous Buttons role [\#16446](https://github.com/primefaces/primeng/issues/16446) +- p-table & p-columnfilter - Error on console and matchmode not show correctly when using filters [\#16452](https://github.com/primefaces/primeng/issues/16452) +- Tree / TreeSelect: no initial selection of node with empty key [\#16494](https://github.com/primefaces/primeng/issues/16494) +- Picklist: Movebottom Button has wrong aria label [\#16498](https://github.com/primefaces/primeng/issues/16498) +- Primeicons.ts icon missing and wrong icons key [\#16543](https://github.com/primefaces/primeng/issues/16543) +- Component: RadioButton [\#16553](https://github.com/primefaces/primeng/issues/16553) +- SelectedItemGroup: Type should be a generic [\#16561](https://github.com/primefaces/primeng/issues/16561) +- Autocomplete: Do not clear input on Backspace [\#16570](https://github.com/primefaces/primeng/issues/16570) +- InputNumber: InputNumber with horizontal and vertical buttons are not accessible through keyboard. [\#16591](https://github.com/primefaces/primeng/issues/16591) +- Menu closes itself immediately when the menu and its button toggle is inside ShadowDom [\#16298](https://github.com/primefaces/primeng/issues/16298) +- Component: Auto Complete - with Force Selection, selected option is overriding with the matched value [\#16625](https://github.com/primefaces/primeng/issues/16625) +- Component: Carousel accessibility issue [\#16552](https://github.com/primefaces/primeng/issues/16552) +- Component: p-splitButton Issue with plain textual class to the button [\#16731](https://github.com/primefaces/primeng/issues/16731) +- Blocker: unresponsive browser if pressing ESC-key in combination with lots of tooltips or overlay panels [\#16729](https://github.com/primefaces/primeng/issues/16729) +- Component: p-inputNumber [\#16733](https://github.com/primefaces/primeng/issues/16733) + ## [18.0.0](https://github.com/primefaces/primeng/tree/18.0.0) (2024-11-06) [Full Changelog](https://github.com/primefaces/primeng/compare/18.0.0-rc.2...18.0.0)