-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialogue Text Names #63
Comments
I think your idea is nice.
And, I looked at the other repos, like pokered, and they used the same convention. In my opinion, it's good to minimize the count of delimiter for readability. Combining the speaker and the prefix seems nice, as by combining them they can be considered as a specific postfix(or prefix) including the meaning of a text. In this way, we can put the 'text' before the speaker, for considering the exception where it has no speaker, like: |
I would say the most important thing would be to enforce consistency. I also like the Actually, I think something like |
I also think that for clarity it would be good to put together the name and the suffix. And, I think we can also use different suffixes for different cases like:
|
I personally prefer using an underscore, but I understand and agree that it makes sense not to since text currently does not use underscores to separate things. I think we should go with Text rather than Dialogue. I know it's a bit less descriptive, but I don't think it's super necessary, and I'm worried the labels are already going to be pretty long with NPCs like Ishihara and Imakuni who have longer names. I think the general consensus I'm seeing (and agreeing with) is: [name][Scenario]Text ---- Jidoc's message arrived right as I was hitting comment, so I'm just going to append my thoughts: If there's an NPC's name attached to the label, we would already know there's a speaker. I do think [Scenario][name]Text is also acceptable, though I like how immediately recognizable having the NPC's name at the beginning is. |
I agree. With someone's name on it, we can discern easily whether the text has a speaker. Of course, it's easy to recognize if it's a name or somewhat, but with a structural point it could be better to have something to reveal its structure, as the two types(Text and Dialogue) have different structure on label(the former has no name). For example, when the content has some name like And, I also think we can shorten Dialogue to Dialog, as the latter is shorter and also being used frequently. Actually, I would prefer to using only the "Text", as it's very short, and all the things I said above isn't that critical in real situations lol. Plus, I think that having a name at the beginning looks more clear! |
Currently, the style guide touches on how to name shorter texts like UI (try to use the words in the text, or shave off a few and use the key words), and Names (use the full name).
I think that it'd be a good idea to come up with a consensus on how longer Dialogue texts should be renamed. They can span many lines, and can't be condensed as easily as UI texts can be.
My idea is that we find some way to describe what's being talked about, but add the speaker to the beginning. Something like
Imakuni_IntroductionText
orImakuniAskToDuelText
for texts 0467 and 0468 respectively. I personally prefer with the underscore.Please share any thoughts on how naming texts could work, thank you!
The text was updated successfully, but these errors were encountered: