Upgrade function not respecting JAVA8_HOME settings.

[kien-truong]

Upgrading presto server will fail with custom JDK location due to java's version check.

[akshatnair]

Can you post the command you ran and also the error you are seeing?

[kien-truong]

On a Centos 7 server with a custom jdk version 1.8_131 I ran

presto-admin server upgrade presto-server-rpm-0.179.rpm

The command failed during pre_install check because the default java7 was detected, instead of the custom jdk8 specified in java8_home. Checking the _rpm_upgrade function in package.py reveals that the variable is not sourced.

def _rpm_upgrade(package_name):
    return sudo('rpm -U %s%s' % (_nodeps_rpm_option(), package_name))

It should be similar to the _rpm_install, such as

def _rpm_upgrade(package_name):
    nodeps = _nodeps_rpm_option()
    if 'java8_home' not in env or env.java8_home is None:
        return sudo('rpm -U %s%s' % (nodeps, package_name))
    else:
        with shell_env(JAVA8_HOME='%s' % env.java8_home):
            return sudo('rpm -U %s%s' % (nodeps, package_name))