Workflow releasing docker container does not build master branch

[BenjaminRodenberg]

python-bindings/.github/workflows/build-docker.yml

Lines 54 to 62 in c0288c8

	- name: Build and push Dockerfile
	uses: docker/build-push-action@v2
	with:
	push: true
	file: "./tools/releasing/packaging/docker/Dockerfile"
	tags: ${{ env.docker_username }}/python-bindings:${{ env.TAG }}
	build-args: |
	PRECICE_TAG=${{ env.PRECICE_TAG }}
	PYTHON_BINDINGS_REF=${{ env.BINDINGS_REF }}

The code above does not provide the correct branch to the dockerfile, if running from master, i.e. a release. This results in an incorrect release.

If I run the following locally, everything works:

python-bindings/tools/releasing/packaging/docker$ docker build -t precice/python-bindings:latest --build-arg branch=v3.0.0.0 .

Note: --build-arg=v3.0.0.0 is needed and not --build-arg=master, because master contains 536d385

One can check for the correct version of the bindings being packaged by

docker run -ti precice/python-bindings:latest
python3 -c "import precice; print(precice.__version__)"

At the current state this breaks our automated packaging pipeline and requires manually releasing the docker container.

[BenjaminRodenberg]

I manually released the latest version of the python bindings now to precice/python-bindings:latest. Before the next release we should either fix this issue or deactivate the workflow. The way how things are working currently is very misleading.

[MakisH]

Sounds like duplicate of #191

[BenjaminRodenberg]

It's not a duplicate, but it was a false alert. The Dockerfile I used to manually do the release was outdated. With the up-to-date Dockerfile I now run into the issue described in #191, but this is a different story.