Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dockerfile from respective fork or branch for CI runs #119

Open
IshaanDesai opened this issue Aug 12, 2021 · 0 comments
Open

Use dockerfile from respective fork or branch for CI runs #119

IshaanDesai opened this issue Aug 12, 2021 · 0 comments
Assignees
@IshaanDesai

Comments

@IshaanDesai
Copy link
Member

Currently the dockerfile used in CI runs is precice/ci-spack-pyprecice-deps-1804 which is the dockerfile on python-bindings/develop whereas actually the dockerfile from the respective fork or branch needs to be used in CI runs, for example this file from a recent PR. This happens because the file tag is hard coded in the workflow files:

python-bindings/.github/workflows/build-env.yml

Line 28 in 36e4782

tags: precice/ci-spack-pyprecice-deps-1804

python-bindings/.github/workflows/build-spack.yml

Line 17 in 36e4782

container: precice/ci-spack-pyprecice-deps-1804

@IshaanDesai IshaanDesai self-assigned this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshaanDesai IshaanDesai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IshaanDesai