From 03ad208eb14a9ded2467137f1cb2c153b7ea75e7 Mon Sep 17 00:00:00 2001 From: Gerasimos Chourdakis Date: Thu, 21 Mar 2024 07:36:02 +0100 Subject: [PATCH 1/4] Introduce a bug to test the tests --- FSI/ForceBase.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FSI/ForceBase.C b/FSI/ForceBase.C index 48297cdf..139a7cc4 100644 --- a/FSI/ForceBase.C +++ b/FSI/ForceBase.C @@ -160,7 +160,7 @@ std::size_t preciceAdapter::FSI::ForceBase::writeToBuffer(double* buffer, if (solverType_.compare("incompressible") == 0) { forceField.boundaryFieldRef()[patchID] = - surface * pb[patchID] * rhob[patchID]; + pb[patchID] * rhob[patchID]; } else if (solverType_.compare("compressible") == 0) { From bbe375240b84a8ca3fb7f27b768ba34fdd5857ef Mon Sep 17 00:00:00 2001 From: Gerasimos Chourdakis Date: Thu, 21 Mar 2024 07:49:35 +0100 Subject: [PATCH 2/4] Introduce a numerical bug, but still compile --- FSI/ForceBase.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FSI/ForceBase.C b/FSI/ForceBase.C index 139a7cc4..42f7f0ce 100644 --- a/FSI/ForceBase.C +++ b/FSI/ForceBase.C @@ -160,7 +160,7 @@ std::size_t preciceAdapter::FSI::ForceBase::writeToBuffer(double* buffer, if (solverType_.compare("incompressible") == 0) { forceField.boundaryFieldRef()[patchID] = - pb[patchID] * rhob[patchID]; + 0.5 * surface * pb[patchID] * rhob[patchID]; } else if (solverType_.compare("compressible") == 0) { From 73978bf6b9cad9f3c8e368c40e78785be3a56473 Mon Sep 17 00:00:00 2001 From: Gerasimos Chourdakis Date: Thu, 21 Mar 2024 09:54:19 +0100 Subject: [PATCH 3/4] Remove bug, to test how results compare to v2 --- FSI/ForceBase.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FSI/ForceBase.C b/FSI/ForceBase.C index 42f7f0ce..48297cdf 100644 --- a/FSI/ForceBase.C +++ b/FSI/ForceBase.C @@ -160,7 +160,7 @@ std::size_t preciceAdapter::FSI::ForceBase::writeToBuffer(double* buffer, if (solverType_.compare("incompressible") == 0) { forceField.boundaryFieldRef()[patchID] = - 0.5 * surface * pb[patchID] * rhob[patchID]; + surface * pb[patchID] * rhob[patchID]; } else if (solverType_.compare("compressible") == 0) { From a7ee56919d1c035643c5e984f2d89b9421dc4181 Mon Sep 17 00:00:00 2001 From: Gerasimos Chourdakis Date: Thu, 21 Mar 2024 10:19:19 +0100 Subject: [PATCH 4/4] Introduce a bug --- FSI/ForceBase.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FSI/ForceBase.C b/FSI/ForceBase.C index 48297cdf..42f7f0ce 100644 --- a/FSI/ForceBase.C +++ b/FSI/ForceBase.C @@ -160,7 +160,7 @@ std::size_t preciceAdapter::FSI::ForceBase::writeToBuffer(double* buffer, if (solverType_.compare("incompressible") == 0) { forceField.boundaryFieldRef()[patchID] = - surface * pb[patchID] * rhob[patchID]; + 0.5 * surface * pb[patchID] * rhob[patchID]; } else if (solverType_.compare("compressible") == 0) {