Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group the modules together to reduce code duplication #16

Open
MakisH opened this issue Feb 28, 2018 · 3 comments
Open

Group the modules together to reduce code duplication #16

MakisH opened this issue Feb 28, 2018 · 3 comments
Labels
dev Not directly affecting users, but helping future development

Comments

@MakisH
Copy link
Member

MakisH commented Feb 28, 2018

At the moment, when writing a new module, the developer has to write almost the same code in order e.g. to load the new module. If we created a list of modules and iterated onto them, we would make it easier to add a new module. At the end, we could even really allow to deliver modules as "plug-ins".

This is a good issue for anyone interested in design patterns, but it is also of low priority, since at the end we don't need many modules. I will try to tackle this issue after the FSI module is ready.

@MakisH MakisH added the enhancement Nice to have, but not a problem label Feb 28, 2018
@floli
Copy link

floli commented Mar 1, 2018

What is a module in that context?

@MakisH
Copy link
Member Author

MakisH commented Mar 1, 2018

A set of classes in a different namespace, which treat all the problem-specific operations. We currently have a module for Conjugate Heat Transfer, we are now also developing a module for Fluid-Structure Interaction.

They are mostly decoupled from the core of the adapter, but still using a new module at the moment would require to duplicate a few lines of code in the main Adapter.C file.

@MakisH MakisH added dev Not directly affecting users, but helping future development and removed enhancement Nice to have, but not a problem labels Dec 26, 2018
@MakisH
Copy link
Member Author

MakisH commented Feb 17, 2023

Looking back, I am not sure anymore if the current separation into modules makes much sense. We already have an example where temperature can be provided by two modules, which may need to interoperate: #276

I think that, in the long term, what would be nice would be:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Not directly affecting users, but helping future development
Projects
None yet
Development

No branches or pull requests

2 participants