Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping-tester doesn't respect full cross product of rank choices #174

Open
fsimonis opened this issue Mar 15, 2023 · 2 comments
Open

Mapping-tester doesn't respect full cross product of rank choices #174

fsimonis opened this issue Mar 15, 2023 · 2 comments
Labels

Comments

@fsimonis
Copy link
Member

When using the mapping-tester based on branch precice-v3 with

{
  "general": {
    "ranks": {
      "A": [1,2],
      "B": [2,4]
    }
  }
}

Then the expected runs are 1-2, 1-4, 2-2, 2-4.
The actual runs are 1-2, 2-4

@fsimonis fsimonis added the bug label Mar 15, 2023
@kursatyurt
Copy link
Collaborator

Do we expect a cross-product or pairing? From the implementation does not seem like a bug but rather a choice

for ranksA, ranksB in zip(
as_iter(setup["general"]["ranks"].get("A", 1)),
as_iter(setup["general"]["ranks"].get("B", 1)),
):

@davidscn
Copy link
Member

Related question might also be: how do you want to process all runs when evaluating all combinations. Seems related to #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants