Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for an FSI example: Write an adapter for WaterLily.jl #11

Open
MakisH opened this issue Feb 2, 2022 · 5 comments
Open

Idea for an FSI example: Write an adapter for WaterLily.jl #11

MakisH opened this issue Feb 2, 2022 · 5 comments

Comments

@MakisH
Copy link
Member

MakisH commented Feb 2, 2022

WaterLily.jl seems to be a very easy to use flow solver in Julia: https://julialang.org/blog/2021/08/sharks/

Writing an adapter for this would give us a first tutorial case where we could demonstrate the Julia bindings.

(I have no idea if there are more mature flow solvers in Julia, I just discovered this and it looks easy and interesting.

@uekerman
Copy link
Member

uekerman commented Feb 3, 2022

After a quick first look: It seems the code uses a fixed Cartesian mesh. If moving boundaries are done similarly as in the "CFD-Lab code", FSI with preCICE will be complicated to do.
Easier could be to extend the code with heat transport and go for CHT.
Or directly for fluid-fluid coupling.

@IshaanDesai IshaanDesai added the good first issue Good for newcomers label Mar 8, 2022
@dynamic-queries
Copy link

https://github.com/trixi-framework/Trixi.jl has some nice solvers and examples for PDEs with conservation laws.
This could be looked into.

WaterLily.jl is not a conventional solver per se. It is a data generation package for Deep Learning models. And the way they approximate the vector field is really dubious. See https://www.youtube.com/watch?v=YsPkfZqbNSQ , for an intro into the WaterLilly.jl package.

@uekerman uekerman removed the good first issue Good for newcomers label Nov 4, 2022
@marinlauber
Copy link

marinlauber commented Oct 27, 2023

@uekerman @MakisH

Would a Julia binding with Waterlily.jl still be useful? I am currently working on adding FSI to WaterLily, and I ran into this issue. (I already implemented a fully coupled FSI solver with Waterlily's bigger brother using preCICE)

@uekerman
Copy link
Member

uekerman commented Nov 3, 2023

@marinlauber Definitely. We currently have no Julia-based solver in our tutorials. Anything there to continuously test the Julia bindings could be very helpful.
I have no idea, however, how complicated this would be.
Who is Waterlily's bigger brother? 😁

@marinlauber
Copy link

@uekerman Sounds good! I already have the preCICE coupling working for WaterLily, but for a simple IGA solver. Together with @hverhelst we are actually looking at binding WaterLily.jl and G+Smo to preCICE and running some example cases.
WaterLily's big brother is our in-house fortran solver, it's essentially the same solver, but it uses openmpi and has some additional capabilities. Unfortunatly, it's not open-source but, ideally, WaterLily with multi-GPU will replace it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants