Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only last 30 releases are checked if token is given #195

Open
aib opened this issue Jun 25, 2024 · 0 comments · May be fixed by #196
Open

Only last 30 releases are checked if token is given #195

aib opened this issue Jun 25, 2024 · 0 comments · May be fixed by #196

Comments

@aib
Copy link

aib commented Jun 25, 2024 •
edited
Loading

The API request for fetching releases here only checks the first page, not finding the asset if its version is too old. (per_page is 30 by default, 100 max)

We could check all the pages, or perhaps fall back to using the downloadUrl we already know? Why are we downloading by asset when we already know the download URL?
@aib aib linked a pull request Jun 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check multiple release pages when a GitHub token is given aib/prebuild-install
1 participant
@aib