Missena: Update params #4057

jney · 2024-11-18T14:01:11Z

No description provided.

github-actions · 2024-11-18T14:02:00Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9144aec

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99:	makeRequest	87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:209:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:229:	MakeBids	94.1%
total:									(statements)	90.7%

github-actions · 2024-11-19T08:25:50Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 091ffa9

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99:	makeRequest	87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:209:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:229:	MakeBids	94.1%
total:									(statements)	90.7%

ysfbsf · 2024-11-19T11:33:39Z

static/bidder-info/missena.yaml

Suggested change

url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&t={{.APIKey}}&redirect={{.RedirectURL}}

url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}

{{.APIKey}} is not a supported macro in Prebid Server

github-actions · 2024-11-19T14:37:10Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9398c8a

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99:	makeRequest	87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:228:	MakeBids	94.1%
total:									(statements)	90.7%

github-actions · 2024-11-19T14:45:41Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 75e77ba

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:76:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:83:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:99:	makeRequest	87.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:165:	MakeRequests	91.3%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:208:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:228:	MakeBids	94.1%
total:									(statements)	90.7%

github-actions · 2024-11-19T15:05:39Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7c92744

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:64:	Builder		80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:75:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:91:	getEndPoint	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:98:	makeRequest	84.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:167:	MakeRequests	89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:201:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:221:	MakeBids	94.1%
total:									(statements)	88.8%

github-actions · 2024-11-19T15:07:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, dd7c2c1

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:64:	Builder		80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:75:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:91:	getEndPoint	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:98:	makeRequest	84.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:167:	MakeRequests	89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:201:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:221:	MakeBids	94.1%
total:									(statements)	88.8%

SyntaxNode · 2024-11-20T22:24:42Z

static/bidder-info/missena.yaml

Is an api key from Missena now required for user syncing?

SyntaxNode · 2024-11-20T22:25:34Z

adapters/missena/missena.go

+	}
+	currency, err := getCurrency(request.Cur)
+	if err != nil {
+		// TODO: convert unsupported currency on response


Please resolve the TODO.

I'd actually like to manage it on a next release. is it possible? should I remove the comment and consider some currencies unsupported

github-actions · 2024-11-26T14:20:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8f5c3f5

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/missena/missena.go:66:	Builder		80.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:77:	getCurrency	77.8%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:93:	getEndPoint	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:100:	makeRequest	68.6%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:182:	MakeRequests	89.5%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:216:	readGDPR	100.0%
github.com/prebid/prebid-server/v3/adapters/missena/missena.go:236:	MakeBids	94.1%
total:									(statements)	82.8%

update params

9144aec

add APIKey

091ffa9

ysfbsf reviewed Nov 19, 2024

View reviewed changes

fix APIKey not present in macro

9398c8a

follow go naming convention

75e77ba

simpler

7c92744

better

dd7c2c1

SyntaxNode changed the title ~~update missena's params~~ missena: update params Nov 20, 2024

SyntaxNode reviewed Nov 20, 2024

View reviewed changes

bsardo changed the title ~~missena: update params~~ Missena: Update params Nov 22, 2024

handle floor currency

8f5c3f5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missena: Update params #4057

Missena: Update params #4057

jney commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

ysfbsf Nov 19, 2024

jney Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

SyntaxNode Nov 20, 2024

jney Nov 25, 2024

SyntaxNode Nov 20, 2024

jney Nov 25, 2024

jney Nov 26, 2024

github-actions bot commented Nov 26, 2024

	url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&t={{.APIKey}}&redirect={{.RedirectURL}}
	url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}

Missena: Update params #4057

Are you sure you want to change the base?

Missena: Update params #4057

Conversation

jney commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

Code coverage summary

missena

github-actions bot commented Nov 19, 2024

Code coverage summary

missena

ysfbsf Nov 19, 2024

Choose a reason for hiding this comment

jney Nov 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 19, 2024

Code coverage summary

missena

github-actions bot commented Nov 19, 2024

Code coverage summary

missena

github-actions bot commented Nov 19, 2024

Code coverage summary

missena

github-actions bot commented Nov 19, 2024

Code coverage summary

missena

SyntaxNode Nov 20, 2024

Choose a reason for hiding this comment

jney Nov 25, 2024

Choose a reason for hiding this comment

SyntaxNode Nov 20, 2024

Choose a reason for hiding this comment

jney Nov 25, 2024

Choose a reason for hiding this comment

jney Nov 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024

Code coverage summary

missena