New Adapter: Loopme

[ambalashov]

No description provided.

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 7d984d9

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:	parseBidderExt	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:	Builder		75.0%
total:									(statements)	94.5%

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, a239d73

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:	MakeRequests	88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:	parseBidderExt	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:	Builder		75.0%
total:									(statements)	94.5%

[bsardo]

Hi @ambalashov, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, e74eb4e

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:20:	MakeRequests	88.9%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:54:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:92:	parseBidderExt	100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:105:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:123:	Builder		75.0%
total:									(statements)	94.5%

[bsardo]

@PyjamaWarrior can you please review?

[PyjamaWarrior]

Endpoint is reachable:
curl -i --location --request POST http://prebid.loopmertb.com
HTTP/1.1 204 No Content
date: Thu, 14 Nov 2024 08:44:47 GMT

[PyjamaWarrior]

Verified gvl id:
{
"id": 109,
"name": "LoopMe Limited",
"purposes": [
1,
2,
3,
4,
7,
9,
10
],
"legIntPurposes": [],
"flexiblePurposes": [],
"specialPurposes": [
1,
2,
3
],
"features": [
1,
2,
3
],
"specialFeatures": [
1,
2
],
"overflow": {
"httpGetLimit": 32
},
"cookieMaxAgeSeconds": 7776000,
"usesCookies": true,
"cookieRefresh": true,
"urls": [
{
"langId": "en",
"privacy": "https://legal.loopme.com/privacy-center#contract-hyartvn1o",
"legIntClaim": "https://legal.loopme.com/privacy-center#contract-hyartvn1o"
}
],
"usesNonCookieAccess": true,
"dataRetention": {
"stdRetention": 396,
"purposes": {},
"specialPurposes": {}
},
"dataDeclaration": [
1,
2,
3,
4,
6,
7,
8,
9,
10,
11
],
"deviceStorageDisclosureUrl": "https://co.loopme.com/deviceStorageDisclosure.json"
}

[MaksymTeqBlaze]

After the first error in the loop adapter returns one error and nil value. Maybe continuing and returning all errors at the end (like in MakeRequests) would probably be better so that any valid bids are processed? I would recommend this approach but it is ultimately up to you.

[ambalashov]

Make sense. Thanks.

[MaksymTeqBlaze]

I have sent a verification email. Please respond

• verified

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 0ad799a

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:19:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:48:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:97:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:115:	Builder		100.0%
total:									(statements)	95.9%

[Chandrahaas]

I have sent a verification email. Please respond

We sent a response on Nov 21, 9:59 AM . Thanks.