-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the User EID object if the all the ID values are empty #3859
Labels
Comments
Discussed in committee. This sounds fine except that we'd also like warnings to be emitted when in debug mode:
Received a clarification question:
I would say 'yes', there could be a series of warnings:
|
PR: #3891 |
13 tasks
Done with PBS-Java 3.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prebid Server has validation on the user EIDS object where User.Id is a required field. There can be situations where the publisher has set a macro in the GAM tag for the User.Id field. For some requests, it's possible that this macro value is missing. Instead of returning a bad request, we can add a check to remove the Id field if it is not present.
Example
Valid EID:
[{"source":"uidapi.com","uids":[{"id":"AgAACYa0cG2jcVcM42xG"}]}]
Invalid EID:
[{"source":"uidapi.com","uids":[{"id":""}]}]
So with this, problem is like if we have mix of valid and invalid id's for same source then its returning invalid request.
Example:
[{"source":"uidapi.com","uids":[{"id":""}, {"id":"AgAACYa0cG2jcVcM42xG"}]}, {"source":"liveramp.com","uids":[{"id":"AgAACYa0cG2jcVcM42xG"}]}, {"source":"yahoo.com","uids":[{"id":""},{"id":""}]}]
Here expectation is like valid id's should get considerd and invalid Id's can be dropped.
Example:
[{"source":"uidapi.com","uids":[{"id":""}, {"id":"AgAACYa0cG2jcVcM42xG"}]}, {"source":"liveramp.com","uids":[{"id":"AgAACYa0cG2jcVcM42xG"}]}, {"source":"yahoo.com","uids":[{"id":""},{"id":""}]}]
After adding new logic to drop invalid ID's it should return valid ID's only like below
[{"source":"uidapi.com","uids":[{"id":"AgAACYa0cG2jcVcM42xG"}]}{"source":"liveramp.com","uids":[{"id":"AgAACYa0cG2jcVcM42xG"}]}]
If No valid id present then drop complete EIDS object
Example:
[{"source":"uidapi.com","uids":[{"id":""}]}]
The text was updated successfully, but these errors were encountered: