Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currency array warning #3827

Open
bretg opened this issue Jul 26, 2024 · 2 comments
Open

Update currency array warning #3827

bretg opened this issue Jul 26, 2024 · 2 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jul 26, 2024

PBS currently converts incoming currency arrays to a containing the first element of the array. So bid adapters only see this first element.

We discussed in committee the ability to preserve the incoming array and just use the first element as the currency for bid response conversion.

However, the ORTB response structure doesn't support bids in multiple currencies -- cur is at the very top level - the same level as seatbid. So if some bidders were to bid in USD and others in CAD, there's no standard place to put that info. seatbid.bid has a price but not a cur. Of course Prebid could add an extension, but that wouldn't be standard.
We could add a non-default Prebid-specific behavior where a request parameter says "let bidders bid in any of the currencies in the cur array", which indicates that the client is ready to receive seatbid.bid.ext.cur as the bid currency. I don't see this becoming the default in PBS because AMP, Mobile, etc.

At this point, we don't view this as high enough priority to define or implement.

Instead, the suggestion is that we update the warning. Currently the message is: Cur parameter contains more than one currency. CAD will be used

The proposal is to update it to: a single currency (CAD) has been chosen for the request. ORTB 2.6 requires that all responses are in the same currency.

@bretg bretg added the PBS 4.0 label Jul 26, 2024
@bretg bretg moved this from Triage to Needs Requirements in Prebid Server Prioritization Aug 1, 2024
@bretg bretg removed the PBS 4.0 label Aug 1, 2024
@bretg bretg changed the title Pass currency arrays to bid adapters Update currency array warning Aug 1, 2024
@patmmccann
Copy link
Contributor

This wording works well and instead of reading like a concern, reads as informational

@bretg bretg moved this from Needs Requirements to Ready for Dev in Prebid Server Prioritization Aug 1, 2024
@bretg
Copy link
Contributor Author

bretg commented Oct 8, 2024

done with PBS-Java 3.13

@bretg bretg added the PBS-Go label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants