-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account specific fetchRate to select source of floors #2755
Comments
PRD updated with fetch.use-data-rate feature. https://docs.google.com/document/d/1YAt00RfQaU2Ugciqw1LnirLgjyUz9ibfyjfxWUHR_P0/edit#heading=h.yglzagui7gzp |
Can we have some field in floors JSON to control source of floors i.e. req.ext.prebid.floors.dataRate ? This would help in updating data rate through dynamically updated floors data, consume updated dataRate dynamically and no need to update account config as per updated floors data. Having data-rate at account config and floors data would be same as existing enforceRate field. |
@pm-jaydeep-mohite - sorry, I'm not following. You want both dataRate and fetchRate? This feature is already complicated as it is. Please simplify and propose a minimal working solution for your use case. |
In current PRD version, we have dataRate which is account level config parameter. If the value of dataRate is not provided then default value 100 shall be considered to be backward compatible. |
Thanks, but I'm going to push back on this as overly complicated. If This floors feature is already stupendously complicated and having two interacting flags adds a bunch of edge cases that would require documentation and testing. |
In this case we can eliminate one flag from account level config and keep only field from floor data. |
I'm going to challenge you a bit more on this. The feature doesn't seem useful to me. I get why a publisher might want to ease into fetched data, but why would a floors provider say "Only use my data X% of the time." ? It seems similar to "skip rate". How would analytics know which data is used? How would a floors provider know when to change this value? |
|
Very well. The analytics adapter could use ext.prebid.floors.location to tell whether 'request' or 'fetch' floors were used.
Please review both documents to make sure this is what you want. Would prefer not to have make another round of changes here. |
Can we close this issue @pm-jaydeep-mohite ? |
* Floors: add useFetchDataRate feature Per prebid/prebid-server#2755 * Add alt text to images * 50px for mile logo too * Update floors.md --------- Co-authored-by: Muki Seiler <[email protected]>
This proposal is for selecting source of floors i.e. fetched dynamically or from request req.ext.prebid.floors.
Issue
As per floors feature PRD https://docs.google.com/document/d/1YAt00RfQaU2Ugciqw1LnirLgjyUz9ibfyjfxWUHR_P0, If floors data is fetched successfully then it should be used and due to this fetched floors data will get used for 100% of the requests.
There is no option to use fetched floors data for limited requests (e.g. 50%) and static floors data from req.ext.prebid.floors for remaining requests (i.e. 50%)
Proposal
We can have account specific fetchRate to select source floors from dynamically fetched data and from request.
Range of valid values can be 0 to 100, 0 means do not use fetched data and 100 means use fetched floors data for all the requests.
Default value : 0
The text was updated successfully, but these errors were encountered: