Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: classify whatever.BUILD files as bazel files #103

Open
TheButlah opened this issue Apr 14, 2020 · 2 comments
Open

Feature request: classify whatever.BUILD files as bazel files #103

TheButlah opened this issue Apr 14, 2020 · 2 comments

Comments

@TheButlah
Copy link

TheButlah commented Apr 14, 2020 •
edited
Loading

Currently identify has support for BUILD and BUILD.bazel files. it would be good to add support for *.BUILD files as well.

In case its helpful, here is the relevant regex that should describe a bazel file, when matching against a filepath:

^(.*/)?(BUILD\.bazel|BUILD)$|\.BUILD$
@TheButlah TheButlah changed the title Feature request: support whatever.BUILD files Feature request: classify whatever.BUILD files as bazel files Apr 17, 2020
@asottile
Copy link
Member

can you provide a reference for this? as far as I can tell in the official bazel docs they only use BUILD or BUILD.bazel

@TheButlah
Copy link
Author

TheButlah commented Nov 19, 2021 •
edited
Loading

Here you go!
https://docs.bazel.build/versions/1.2.0/external.html#depending-on-non-bazel-projects

Common to have a third_party folder, with dep1.BUILD, dep2.BUILD, to bazelify non bazel projects

@Slowki Slowki mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asottile @TheButlah