Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubyLSP compatibility: locking prism at 0.22.0 disables Ruby language server updates #6

Open
nimmolo opened this issue Jul 14, 2024 · 4 comments

Comments

@nimmolo
Copy link

nimmolo commented Jul 14, 2024

Thanks for this gem!

An odd dependency issue just cropped up for me yesterday after updating VSCode's extension for RubyLSP. Any gem that locks the version of prism seems to block updates of their language server, which also depends on prism. On our app, this is the only gem that depends on prism. (RubyLSP no longer requires an app to use the gem ruby-lsp-rails, which is not up to date - it loads dependencies on its own.)

The issue, documented on their site, is that blocking LSP server updates now results in false positives when linting ERB files.

I know, it doesn't seem related. The full explanation of the situation is on a new thread on Shopify's ruby-lsp GitHub page.

I'd rather not go without prawn-manual_builder and I wonder if the prism version in your Gemfile can be made into a minimum requirement, or otherwise adjusted?

@nimmolo nimmolo changed the title RubyLSP compatibility: locking prism at 0.22.0 disables language server updates RubyLSP compatibility: locking prism at 0.22.0 disables Ruby language server updates Jul 14, 2024
@pointlessone
Copy link
Member

I'm not sure why this gem gets installed at all as it's a development dependency. I thought bundler wouldn't consider dev dependencies in normal installations.

@pointlessone
Copy link
Member

I will look into relaxing Prism version requirement.

@nimmolo
Copy link
Author

nimmolo commented Jul 14, 2024

Thanks. If I knew more about it, i'd offer to do a PR, but I don't know the first thing about how Prawn works. 🙏

@nimmolo
Copy link
Author

nimmolo commented Aug 9, 2024

Is there anything I can do to help get this moving?
It's blocking me from using current Ruby linting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants