Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runlog download error 400s #40

Open
AdnaneKhan opened this issue Jul 19, 2023 · 0 comments
Open

Runlog download error 400s #40

AdnaneKhan opened this issue Jul 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@AdnaneKhan
Copy link
Contributor

AdnaneKhan commented Jul 19, 2023 •
edited
Loading

The GET request for run logs appears to be returning the following response after some time:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
<HTML><HEAD><TITLE>Bad Request</TITLE>
<META HTTP-EQUIV="Content-Type" Content="text/html; charset=us-ascii"></HEAD>
<BODY><h2>Bad Request</h2>
<hr><p>HTTP Error 400. The request is badly formed.</p>
</BODY></HTML>

GitHub likely has an undocumented rate limit for their run-log download API. I will keep an eye on this issue. The mitigation might be to run the run-log download feature only after exhausting YAML-based analysis to ensure we are not downloading excessive duplicate logs. For example, we can check the yaml associated with each run and confirm that it is associated with a self-hosted runner before pulling the run logs.

EDIT: This behavior only seems to manifest when proxying through Burp.
@AdnaneKhan AdnaneKhan added the bug Something isn't working label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AdnaneKhan