Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Attack Feature Parity #22

Open
mas0nd opened this issue Feb 16, 2023 · 1 comment
Open

PR Attack Feature Parity #22

mas0nd opened this issue Feb 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mas0nd
Copy link
Collaborator

mas0nd commented Feb 16, 2023

Currently, the workflow attack supports monitoring job execution, downloading logs, and cleaning up. This is not supported in the PR attack method. We should generalize this post attack flow and achieve parity between the two attack methods.
@mas0nd mas0nd added the enhancement New feature or request label Feb 16, 2023
@AdnaneKhan
Copy link
Contributor

The solution here would be the following:

  • If the workflow runs and requires approval, Gato should report this. Optionally, there could be a flag to close the PR if it requires approval. PRs closed without a force push will clear the pending workflow run.
  • If the workflow does run, then Gato should report that the fork PR was successful and then download the run log and print the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdnaneKhan @mas0nd