Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly support implicit build deps #40

Closed
wants to merge 3 commits into from
Closed

Explicitly support implicit build deps #40

wants to merge 3 commits into from

Conversation

jaraco
Copy link
Contributor

@jaraco jaraco commented Jan 14, 2022

This change uses the --use-pep517 flag in a parameter to pip to ensure that any projects that implicitly require Setuptools will get it, removing the implicit dependency on setuptools in the user's environment.

Additionally, explicitly declares the dependency on pip and invokes it from the environment where vendoring is installed rather than relying on the user to have pip installed somewhere in their system path.

Fixes the issue reported in #39.

setuptools feature/vendoring $ pip-run -q git+https://github.com/jaraco/vendoring@bugfix/39-explicit-build-deps -- -m vendoring sync
Working in .
Load configuration... Done!
Clean existing libraries... Done!
Add vendored libraries... Done!
Fetch licenses... Done!
Generate static-typing stubs... Done!

@jaraco jaraco marked this pull request as draft January 14, 2022 22:47
@pradyunsg
Copy link
Owner

Happy to merge this, whenever you mark this as ready for review. :)

@jaraco jaraco marked this pull request as ready for review January 15, 2022 15:11
@jaraco
Copy link
Contributor Author

jaraco commented Jan 15, 2022

Yep. Thanks for the reminder. I marked it draft when I'd noticed I'd missed one of the pip calls, since corrected and now ready.

@pradyunsg
Copy link
Owner

Closing this since the underlying issue has been fixed in pip.

@pradyunsg pradyunsg closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants