-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error out if the requirements
is not in protected-files
(if destination contains requirements)
#38
Comments
I'd also suggest that |
I'll take a look tomorrow evening. :) |
requirements
is not in protected-files
(if destination contains requirements)
I noticed you changed the bug title to only error rather than honor the original request to ignore these expected ignores by default. In my opinion, requiring each user of vendoring to supply the same "ignore" entries in their config is clumsy. In my opinion, I'd rather it "just work", rather than have it fail and then direct the user to investigate and/or copy/paste the fix from one repo to another. That said, since #37 indicates that this project won't support the Setuptools requirements, it's not particularly important to me to address this issue. |
I'd still like to address this. :) |
369308a resolves this. |
In pypa/setuptools#2825, I started working on applying vendoring to setuptools. I stated with this definition:
I then ran
vendoring sync
, and it failed with:It seems that it's necessary to specify:
Perhaps vendoring could be smart enough to not delete the file indicated by
requirements
rather than requiring it to be specified twice.The text was updated successfully, but these errors were encountered: