Skip to content
This repository has been archived by the owner on Dec 27, 2018. It is now read-only.

Error 'sinon not defined' when running tests in --production mode #11

Open
mcbain opened this issue Jun 18, 2015 · 6 comments
Open

Error 'sinon not defined' when running tests in --production mode #11

mcbain opened this issue Jun 18, 2015 · 6 comments

Comments

@mcbain
Copy link

mcbain commented Jun 18, 2015

Testing with --production flag ensures that the source wich gets deploymed afterwards was tested.
Sometimes - like in this issue - things do not work after getting minified.

@ryneeverett
Copy link
Contributor

@mcbain As of #9, the package is debugOnly.

@mcbain
Copy link
Author

mcbain commented Jun 18, 2015

It's the debugOnly flag

@ryneeverett
Copy link
Contributor

@mcbain Yeah, it's poorly named. It prevents the package from being included in production bundles.

@mcbain
Copy link
Author

mcbain commented Jun 18, 2015

I just read about it - seems that --production testing is dead :(

@mcbain mcbain closed this as completed Jun 18, 2015
@ryneeverett
Copy link
Contributor

@mcbain Please post a comment here if you find a solution. Your use case ought to be supported.

@rbabayoff
Copy link
Member

It can be easily fixed by supporting a DISABLE_DEBUG_ONLY=1 env var and if it is set, not set debugOnly in package.js. PRs welcome.

@rbabayoff rbabayoff reopened this Jun 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants