Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image attachments hosted in s-ul.eu do not show in game #30791

Open
jojohnathon opened this issue Nov 20, 2024 · 7 comments · May be fixed by #30866
Open

Image attachments hosted in s-ul.eu do not show in game #30791

jojohnathon opened this issue Nov 20, 2024 · 7 comments · May be fixed by #30866
Assignees
@frenzibyte
Labels
area:overlays priority:0 Showstopper. Critical to the next release. type:online

Comments

@jojohnathon
Copy link

Type

Game behaviour

Bug description

Open in-game beatmap listing --> go to a beatmap comment w/ image or gif

Beatmap in my example

Screenshots or videos

image

image

Version

2024.1115.3-lazer

Logs

compressed-logs.zip
@bdach
Copy link
Collaborator

bdach commented Nov 20, 2024

Both of these shown on the screenshot are gifs.

Support for gif display has been considered out of scope previously. Not sure if anything changed.

@jojohnathon
Copy link
Author

jojohnathon commented Nov 20, 2024 •
edited by frenzibyte
Loading

image
image

Here's an example with images.

Another one. Not sure if these are secretly gifs, since other images load fine.
image
image

@bdach
Copy link
Collaborator

bdach commented Nov 20, 2024

Emoji support is a different matter entirely, not one that should be in this thread.

@frenzibyte
Copy link
Member

Both of the examples you attached above contain images hosted on the s-ul.eu domain. Those fail the SSL handshake, therefore not loading in the game:

[network] 2024-11-24 08:38:13 [verbose]: Request to https://prdec.s-ul.eu/eiU27EFf.jpg failed with System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
[network] 2024-11-24 08:38:13 [verbose]: ---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
[network] 2024-11-24 08:38:13 [verbose]: ---> Interop+AppleCrypto+SslException: handshake failure
[network] 2024-11-24 08:38:13 [verbose]: --- End of inner exception stack trace ---
[network] 2024-11-24 08:38:13 [verbose]: at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](Boolean receiveFirst, Byte[] reAuthenticationData, CancellationToken cancellationToken)
[network] 2024-11-24 08:38:13 [verbose]: at System.Net.Http.ConnectHelper.EstablishSslConnectionAsync(SslClientAuthenticationOptions sslOptions, HttpRequestMessage request, Boolean async, Stream stream, CancellationToken cancellationToken)

This can also be confirmed in the logs you have attached:

2024-11-20 08:52:59 [verbose]: Request to https://ashi.s-ul.eu/A8lGZMuj failed with System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
2024-11-20 08:52:59 [verbose]: ---> System.Security.Authentication.AuthenticationException: Authentication failed because the remote party sent a TLS alert: 'HandshakeFailure'.
2024-11-20 08:52:59 [verbose]: ---> System.ComponentModel.Win32Exception (0x80090326): The message received was unexpected or badly formatted.
2024-11-20 08:52:59 [verbose]: --- End of inner exception stack trace ---

may need @ppy/team-client attention since s-ul.eu is commonly used by the osu! community as far my quick google and discord searches go, although I'm not quite sure what can be done from our side to fix this (other than to figure out how it still loads on osu-web and in browsers in general).

@frenzibyte frenzibyte changed the title Beatmap comment embeddings not displaying correctly in in-game beatmap listing Image attachments hosted in s-ul.eu do not show in game Nov 24, 2024
@peppy
Copy link
Member

peppy commented Nov 24, 2024 •
edited
Loading

No image should ever be requested directly from a third party domain. What the hell is going on here?? @ppy/team-web are comment images not being proxied?

@peppy peppy added the priority:0 Showstopper. Critical to the next release. label Nov 24, 2024
@nanaya
Copy link

nanaya commented Nov 24, 2024 •
edited
Loading

oh yeah, markdown images are proxied on web during parsing phase which for comments happens on frontend (proxied url is obtained through /beatmapsets/discussions/media-url?url=...)

edit: it's only for chat and beatmap discussion but the principle is the same. raw markdown has the original url and only proxied during parsing - either by backend (returning raw html) or frontend

@peppy
Copy link
Member

peppy commented Nov 24, 2024

Hmm, right. We need to be doing that in the client then 💦

@frenzibyte frenzibyte self-assigned this Nov 25, 2024
@frenzibyte frenzibyte linked a pull request Nov 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frenzibyte frenzibyte

Labels
area:overlays priority:0 Showstopper. Critical to the next release. type:online
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some image attachments in comments not loading in game frenzibyte/osu
5 participants
@peppy @nanaya @bdach @frenzibyte @jojohnathon