Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by "Rank Achieved: SS" does not work in mania #11057

Closed
AkiraMorilas opened this issue Mar 2, 2024 · 3 comments · Fixed by #11109
Closed

Filtering by "Rank Achieved: SS" does not work in mania #11057

AkiraMorilas opened this issue Mar 2, 2024 · 3 comments · Fixed by #11109

Comments

@AkiraMorilas
Copy link

Screenshot 2024-03-02 at 14-54-07 beatmap listing osu!
As shown in screenshot, none of my 36 mania SS ranks appear, despite mania being set as my main gamemode.
I am assuming that this is because none of them are lazer SSes(rainbow 300 only)?
Would be nice to get a clarification on whether this is a bug or intentional.

@bdach
Copy link
Contributor

bdach commented Mar 15, 2024

Similarly to ppy/osu-infrastructure#27 I'm not sure what should happen. I see basically two outcomes:

  • We say that this is intended because that's how lazer grades work and it's a wontfix
  • We add support for filtering on old/new rank based on lazer mode being active (involves changes to osu-queue-score-statistics to store the old rank somewhere, reindexing at least all stable scores, etc.)

@bdach
Copy link
Contributor

bdach commented Mar 21, 2024

@peppy fyi

@nanaya
Copy link
Collaborator

nanaya commented Mar 21, 2024

adding the legacy rank to index (and updating search field based on lazer mode) is probably enough.

...wait, no, that's not even needed. The rank filtering is done at the last step at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants