From c7f4b5b27c1c2da24f499c917b84aefb80914e00 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Mon, 9 Dec 2024 13:46:22 +0900 Subject: [PATCH 1/2] Fix unobserved exceptions on named pipe shutdown --- osu.Framework/Platform/NamedPipeIpcProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Framework/Platform/NamedPipeIpcProvider.cs b/osu.Framework/Platform/NamedPipeIpcProvider.cs index 9d747647f6..838bb17a19 100644 --- a/osu.Framework/Platform/NamedPipeIpcProvider.cs +++ b/osu.Framework/Platform/NamedPipeIpcProvider.cs @@ -100,7 +100,7 @@ private async Task listen(NamedPipeServerStream pipe) } } } - catch (TaskCanceledException) + catch (OperationCanceledException) { } finally From b1ca41e0ad20fc882dcdc99f4cffa119fead42f9 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Mon, 9 Dec 2024 13:59:07 +0900 Subject: [PATCH 2/2] Catch in second place to avoid sentry logging --- osu.Framework/Platform/NamedPipeIpcProvider.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/osu.Framework/Platform/NamedPipeIpcProvider.cs b/osu.Framework/Platform/NamedPipeIpcProvider.cs index 838bb17a19..32f6daea2f 100644 --- a/osu.Framework/Platform/NamedPipeIpcProvider.cs +++ b/osu.Framework/Platform/NamedPipeIpcProvider.cs @@ -94,6 +94,9 @@ private async Task listen(NamedPipeServerStream pipe) pipe.Disconnect(); } + catch (OperationCanceledException) + { + } catch (Exception e) { Logger.Error(e, "Error handling incoming IPC request.");