Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Moves translation #10

Open
Teelve opened this issue Aug 26, 2016 · 5 comments
Open

Add Moves translation #10

Teelve opened this issue Aug 26, 2016 · 5 comments

Comments

@Teelve
Copy link

Teelve commented Aug 26, 2016

You translated pokemon names, okay fine, but you should translate moves aswell, way more useful ;)

@pperle
Copy link
Owner

pperle commented Aug 26, 2016

There are about 300 moves ... https://github.com/chuparCh0pper/PoGoIV_xposed/blob/master/app/src/main/java/com/github/aeonlucid/pogoprotos/Enums.java#L870

You can start translating if you want ;)

@pperle pperle closed this as completed Aug 26, 2016
@pperle pperle reopened this Aug 26, 2016
@Xelwon
Copy link

Xelwon commented Sep 3, 2016

I made a java class to can translate all movements easily.
you only need put
getMovement(Languages.[your_language], [string id])
for example:
getMovement(Languages.ENGLISH, 10);

EDIT:
I changed the attached file for another more recient file.
PogoMovements.txt

pperle added a commit that referenced this issue Sep 5, 2016
This is broken, PoGO movesets do not match up with list.
#10
@pperle
Copy link
Owner

pperle commented Sep 5, 2016

@Xelwon thank you for your work.
While implementing your solution I realized that the order of the moves do not match up.
The first move on bulbapedia is "Pound" but the first one in pokémon go is "THUNDER_SHOCK".

@Xelwon
Copy link

Xelwon commented Sep 5, 2016

OMG, I will try a quick reordering using pokemon go ids

EDIT: Done.
This new version, changes Pokemon go IDs to Bulbapedia IDs.
PogoMovements.txt

@pperle
Copy link
Owner

pperle commented Sep 17, 2016

@Xelwon sorry I did not see your edit until now. I will try to merge it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants