Editing ASP grammar to permit _ in object constants and predicate sym… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this change doesn't seem to be sufficient to remove all of the inconsistency as the FOL grammar allows |
teiesti
requested changes
Feb 23, 2024
teiesti
added
E-easy
teiesti
force-pushed
the
zach/underscore
branch
from
f93e6a0
to
6f83937
Compare
teiesti
force-pushed
the
zach/underscore
branch
from
6f83937
to
25719aa
Compare
teiesti
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bols.
The FOL grammar defines symbolic constants as
symbolic_constant = @{ !keyword ~ ""? ~ ASCII_ALPHA_LOWER ~ (ASCII_ALPHANUMERIC | "")* }
whereas the ASP grammar (prior to this update) defined them as
symbol = @{ !negation ~ ASCII_ALPHA_LOWER ~ ASCII_ALPHANUMERIC* }
which seems to be an oversight.
Closes #62