Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Use builder image versions according to peer version #7

Open
djboris9 opened this issue Jun 29, 2020 · 1 comment
Open

Use builder image versions according to peer version #7

djboris9 opened this issue Jun 29, 2020 · 1 comment

Comments

@djboris9
Copy link
Contributor

Issue

Solves image version problems like #6

Proposal

Instead of hard coding builder image versions in k8scc.yaml, we should use the same substitution mechanism as in core.yaml to set the image version according to the peer version.

Example from core.yaml:

$(DOCKER_NS)/fabric-ccenv:$(TWO_DIGIT_VERSION)

Implementation hint

Something like this, but at runtime. We may need to start the peer binary in order to get the version. And maybe we can also process the core.yaml and remove the image versions from the k8scc.yaml.

@aldredb
Copy link
Contributor

aldredb commented Jun 30, 2020

Hi @djboris9 a simpler alternative would be removing hardcoded k8scc.yaml from the image and relying on user-provided ConfigMap e.g.

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: org1-peer1-k8scc
data:
  k8scc.yaml: |
    ---
    images:
      golang: "hyperledger/fabric-ccenv:2.1.1"
      java: "hyperledger/fabric-javaenv:2.1.1"
      node: "hyperledger/fabric-nodeenv:2.1.1"
    transfer_volume:
      path: "/var/lib/k8scc/transfer/"
      claim: "shared-pvc"
    builder:
      resources:
        memory_limit: "500M"
        cpu_limit: "0.5"
    launcher:
      resources:
        memory_limit: "200M"
        cpu_limit: "0.1"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants