Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for postcss-nesting support #170

Closed
wants to merge 1 commit into from

Conversation

adam-lynch
Copy link

I had a weird issue in my codebase. While looking into it, I saw #153 (comment) and wrote a test for it. It turned out my issue was due to my PostCSS dependency being out of date.

The test fails due to whitespace;

│   expected: 'div:active:hover { a: 1; }'
│   actual: ' div:active:hover { a: 1; }'

I'm probably missing something obvious.

@ai
Copy link
Member

ai commented Oct 29, 2024

The issue is just a whitespace?

Whitespace is low priority task for me, since they require ton of work and most people will not see the result (since they will run minifier later).

@adam-lynch
Copy link
Author

adam-lynch commented Oct 29, 2024 via email

@ai
Copy link
Member

ai commented Oct 29, 2024

Honestly, it looks like over complicating project maintenance.

I have 20+ open source project to support and a lot of practical experience taught me to add something only if there is a reason to do it.

If you have no practical reason, let’s keep it as-is.

@adam-lynch
Copy link
Author

No problem

@adam-lynch adam-lynch closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants