pb-6586 | chore: add version field for cluster objects #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
strivedi-px
requested review from
prashanthpx,
vikasit12,
lalat-das,
siva-portworx,
vsundarraj-px,
t-nidhin and
aks-px
dbinnal-px
reviewed
Apr 10, 2024
pkg/apis/v1/api.proto
Outdated
| @@ -66,6 +66,7 @@ message ClusterInfo { | |||
| (gogoproto.moretags) = "secure:\"true\"" | |||
| ]; | |||
| Provider provider = 17; | |||
| string version = 18; | |||
There was a problem hiding this comment.
I thinks this would make it more clear on what version details it is.
Suggested change
| string version = 18; | |
| string k8sversion = 18; |
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
pb-6586 | chore: add version field for cluster objects
|
License Evaluation Results:
Total License Issues: 0 |
vikasit12
approved these changes
Apr 10, 2024
prashanthpx
approved these changes
Apr 10, 2024
strivedi-px
added a commit
that referenced
this pull request
Apr 12, 2024
Adds `k8s_version` field in the ClusterInfo API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the
versionfield inclusterobject for storing the Kubernetes version of the cluster.Which issue(s) this PR fixes (optional)
Addresses PB-6586