-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pb-4263: email alert and latest vendor changes from kubevirt #233
Conversation
pb-4403: service receiver | email alerting - Email Alerting feature receiver CRUD; allowing admin to add SMTP details pb-4403: vendor changes | email alerting -vendor changes for service receiver pb-4945 | recipient service Recipient Service API for email notification, this will allow users to add new email id's where they will receive alerts for the owned cluster. pb-5305: smtp validation | Receiver Service New service added to validate smtp configuration: 1. Either from saved configuration 2. Sending a configuration and validation before saving. PB-4263: Email Alert | object reference for recipient Review changes for Email Alert and object ref added for recipient to refer parent receiver pb-4263: vendor changes | email alert pb-4263 | vendor changes
OSS Scan Results:
Total issues: 26 |
License Evaluation Results:
Total License Issues: 0 |
@t-nidhin please check once by vendoring this version of px-backup-api doesn't break px-backup build. This ensures after merge of this we can gracefully vendor px-backup-api master to px-backup master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease make sure the vendoring of this chnage to px-backup master , doen't break build. Thanks
This was vendor on px-backup and the tests and image ran successfully. We are good to go. |
pb-4403: service receiver | email alerting
pb-4403: vendor changes | email alerting
-vendor changes for service receiver
pb-4945 | recipient service
Recipient Service API for email notification, this will allow users to add new email id's where they will receive alerts for the owned cluster.
pb-5305: smtp validation | Receiver Service
New service added to validate smtp configuration:
PB-4263: Email Alert | object reference for recipient
Review changes for Email Alert and object ref added for recipient to refer parent receiver
pb-4263: vendor changes | email alert
pb-4263 | vendor changes
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
This was already reviewed in 2.7.0 branch, this is just to merge all changed into master.
This has vendor changes of alerting and kubevirt phase 2.