Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from deprecated heroku/buildpacks:20 and heroku/builder-classic:22 CNB builder images #3896

Open
edmorley opened this issue Oct 30, 2023 · 7 comments

Comments

@edmorley
Copy link

Hi 👋

This project uses Heroku's heroku/buildpacks:20 and heroku/builder-classic:22 CNB builder images:
https://github.com/search?q=repo%3Aporter-dev%2Fporter+%28%22heroku%2Fbuilder-classic%3A22%22+OR+%22heroku%2Fbuildpacks%3A20%22%29&type=code

We have deprecated this builder image as of heroku/cnb-builder-images#429.

Please migrate to heroku/builder:22 or heroku/builder:20, to continue to receive security updates, and to avoid disruption when the build time deprecation warning is upgraded to an error in the future.

More information on the difference between the various builder images can be seen here:
https://github.com/heroku/cnb-builder-images#heroku-cnb-builder-images

I also see there are references to the even older (and EOL/insecure) heroku/buildpacks:18 - these need to be migrated too:
https://github.com/search?q=repo%3Aporter-dev%2Fporter+%22heroku%2Fbuildpacks%3A18%22&type=code

The docs here will also need updating:
https://github.com/search?q=repo%3Aporter-dev%2Fdocs+%22heroku%2Fbuildpacks%22&type=code

@jose-fully-ported
Copy link
Contributor

Hi @edmorley, I'll reach out to you on the CNCF slack :)

@edmorley
Copy link
Author

@jose-fully-ported Gentle nudge that Porter is still using these deprecated images - builds using these images will start erroring in the future (likely in the next couple of months; there will be an env var opt out), and the underlying images will stop receiving security updates.

@edmorley
Copy link
Author

@edmorley
Copy link
Author

edmorley commented Mar 7, 2024

and to avoid disruption when the build time deprecation warning is upgraded to an error in the future.

This will be happening within the next couple of weeks in heroku/cnb-builder-images#474. We'll be adding an env var override for the errors, but I strongly recommend you switch from heroku/buildpacks:20 and heroku/builder-classic:22 to heroku/builder:* as soon as possible.

@edmorley
Copy link
Author

Please migrate to heroku/builder:22 or heroku/builder:20, to continue to receive security updates, and to avoid disruption when the build time deprecation warning is upgraded to an error in the future.

The deprecation warnings were upgraded to errors this morning:
heroku/cnb-builder-images#478

@edmorley
Copy link
Author

It looks like the errors were suppressed for this project in #4420, which is not what I'd recommend.

End users need to be made aware of this change, and so ideally they should be the ones setting the env var themselves.

@edmorley
Copy link
Author

edmorley commented May 4, 2024

As of yesterday, the legacy heroku/buildpacks:20 and heroku/builder-classic:22 builder images are no longer updated, and so won't receive security updates, fixes or support for new language runtime version releases. Please switch to using the heroku/builder:* images instead:
https://github.com/heroku/cnb-builder-images#available-images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants