Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterIP instruction in NOTES.txt is not complete #90

Open
guivin opened this issue Jan 7, 2022 · 0 comments · May be fixed by #97
Open

ClusterIP instruction in NOTES.txt is not complete #90

guivin opened this issue Jan 7, 2022 · 0 comments · May be fixed by #97
Assignees

Comments

@guivin
Copy link

guivin commented Jan 7, 2022

Hello,

The instruction section for ClusterIP in NOTES.txt is not complete. Here is the diff to apply:

diff --git a/charts/portainer/templates/NOTES.txt b/charts/portainer/templates/NOTES.txt
index 604843e..cd3a259 100644
--- a/charts/portainer/templates/NOTES.txt
+++ b/charts/portainer/templates/NOTES.txt
@@ -18,6 +18,7 @@
   echo http://$SERVICE_IP:{{ .Values.service.httpsPort }}
 {{- else if contains "ClusterIP" .Values.service.type }}
   Get the application URL by running these commands:
-  export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "portainer.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].me$  echo "Visit http://127.0.0.1:9443 to use your application"
+  export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "portainer.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}")
+  echo "Visit http://127.0.0.1:9443 to use your application"
   kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 9443:9443
 {{- end }}

Guillaume,

d1mnewz added a commit to d1mnewz/k8s that referenced this issue Feb 8, 2022
@d1mnewz d1mnewz linked a pull request Feb 8, 2022 that will close this issue
@d1mnewz d1mnewz self-assigned this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants