Moving away from file concat

[KZachariassen]

Hi,

I will soon create a new branch, where I have moved away from file concat based on erb template. The new module will be based on Puppet Hashes, merge them together and then I'm reusing this template to make a structured and sorted yaml representation out of the hash.

I will keep the same structure in the module, but I'm just not a big fan of file concatenation and erb templating. Hope you will give it a go when it's ready

[poolski]

Curious - I'd be interested to see how that pans out!

[KZachariassen]

I have pushed a new branch where I have done some rework on the Filebeat part of the project.

The module is now using 100% Puppet Hashes for configuration and writing the config file is done by this piece of code:

# Filebeat config
class beats::filebeat::config{

  $shipper_data_template = {
    shipper => {
      ignore_outgoing       => true,
      name                  => $::fqdn,
      refresh_topology_freq => '10',
    }
  }
  $shipper= deep_merge($shipper_data_template, $beats::shipper_data)
  $prospectors = $beats::filebeat::prospectors
  $outputs = $beats::filebeat::outputs

  $filebeat_conf = merge($prospectors,$outputs,$shipper)

  file {'/etc/filebeat/filebeat.yml':
    ensure  => present,
    content => inline_template('<%= @filebeat_conf.to_yaml %>'),
    }
}

$shipper_data_template is a example of creating a default hash if you want some default values for pieces of your config file. The rest of the magic is provided by hash merge and <%= @filebeat_conf.to_yaml %>

This makes is really simple and remove a lot of pain regarding erb templates(spaces, newlines). Furthermore it allows us to handle changes in the Beat product, without the need to update .pp and .erb files.

I would like some feedback before I will rework the rest of the module.

[KZachariassen]

Could someone have a look and test the brance I created?