Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please clarify the licence, is it GPL or MPL-2.0? #36

Open
Mayeu opened this issue Apr 12, 2018 · 8 comments
Open

Please clarify the licence, is it GPL or MPL-2.0? #36

Mayeu opened this issue Apr 12, 2018 · 8 comments

Comments

@Mayeu
Copy link

Mayeu commented Apr 12, 2018

Hello,

From the licence file in the repository it looks like this project is using MPL-2.0, but when opening the source code each file has the GPL header.

Can you clarify your position on the licence? I'm happy to create a pull request containing the needed change, but I would need to know the adequate licence for that :)

Thank you for your great plugin 🙏

@poohsen
Copy link
Owner

poohsen commented May 8, 2018

I meant to just MPL and I'll gladly merge your pr ;)

@Mayeu
Copy link
Author

Mayeu commented May 8, 2018

Thank you for your response! I'll try to a PR during this week then :)

@mikehardy
Copy link
Contributor

Hi there! I can totally understand not having the time to work on things, but I have a bit of time and could work on new releases if you want to transition the add-on.

It would be great to merge the MPL2 license first just to make sure there were no license issues, then if you were interested, you could have a look at the beta release I just packaged up on my fork:

https://github.com/mikehardy/thunderlink/releases

And add me as a contributor on AMO (I'm MikeHardy / [email protected] over there) - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/Distribution

Regardless if you're interested or not, thanks for any work you've done on the plugin, it's integrated into my main task workflow :-)

@poohsen poohsen closed this as completed in c50f649 Sep 5, 2018
poohsen pushed a commit that referenced this issue Sep 5, 2018
@poohsen
Copy link
Owner

poohsen commented Sep 5, 2018

I'm currently having trouble logging into developer.mozilla.org but I can log in to addons.thunderbird.net so I added you as a dev in the addon settings @mikehardy
is that enough? how come developer.mozilla.org only offers github login?

@poohsen poohsen reopened this Sep 5, 2018
@mikehardy
Copy link
Contributor

Thanks @poohsen - I think that's enough, I see the "manage" button now and it looks like it works. I'll see what I can do going forward but I'm of course happy to leave you on there unless you'd prefer I remove you. Fingers crossed I can maintain it well enough just so it works as new versions are released, I'm addicted to deep mail links in external todo lists, and likewise prefer thunderbird over other clients on Linux :-). Thanks again for creating this

@mikehardy
Copy link
Contributor

Ah wait - @poohsen - turns out unless you make me an "Owner" I can't manage all aspects. Obviously that role designation is at your discretion though - with the current Developer role I can publish new versions, so that's functional enough to implement forward-compatibility and release it to others...

@poohsen
Copy link
Owner

poohsen commented Sep 11, 2018

@mikehardy AFAICS the only permissions not included in the developer role compared to the owner role are for adding/removing users and roles. You should be able to alter all other aspects of the addon as you see fit.

@mikehardy
Copy link
Contributor

@poohsen this may be a random place to drop a note - but I just wanted to mention for you (in case you still have this in your workflow?) that thunderlink with TB60+ has link creation and use working (I think).

Preferences still aren't working, but the "daily use" cases are back.

I need to finish forward-porting and addressing mozilla.org's concerns for an official release but in case it's useful to you personally since you created it, I thought you should know - https://github.com/mikehardy/thunderlink/releases/tag/1.2.2-beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants